From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5234EC4338F for ; Thu, 19 Aug 2021 05:41:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 03027608FE for ; Thu, 19 Aug 2021 05:41:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 03027608FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 9D1A06B0073; Thu, 19 Aug 2021 01:41:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9833D6B0074; Thu, 19 Aug 2021 01:41:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D55E8D0001; Thu, 19 Aug 2021 01:41:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id 641F76B0073 for ; Thu, 19 Aug 2021 01:41:25 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0B1C9181BCDDA for ; Thu, 19 Aug 2021 05:41:25 +0000 (UTC) X-FDA: 78490732530.33.65F5EF3 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf29.hostedemail.com (Postfix) with ESMTP id BE5C5901E59A for ; Thu, 19 Aug 2021 05:41:24 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id w6so3240324plg.9 for ; Wed, 18 Aug 2021 22:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X40twNuUzE3XmXzdn7oC63jTsAYe8TLwgZJqPK62/Bw=; b=PpGbgxwRwy9qvrBfzI5BPxYXv+Me68BOJn/inChLaH5pJiGm3ZH3LTsTqN7I5qMCjb U1sQl8iUXqJsenXuolEo0eLTYm0xosg3mxOQNDMgo7zh+2h2ajeS84kNDMta/3jM64J7 Ba3NwwTlOG5N1OlKGzNN1UM8Wc2CGNqhb/B9v0S7NHv8qHMxADsGxFBPAN29Yehdxb6i Uhdbcu0wUPmzzj10NPK25q9KKs7diD0jDoVFKjNsumplzyiqmXkxhF8Z/9DnDv56FiKc ckKbBvW+yZjP9qp0iaDEQH/p5p11czoQx72KR0U9NQr31iy5X5tbeunFATtQDlKZNPuT iXZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X40twNuUzE3XmXzdn7oC63jTsAYe8TLwgZJqPK62/Bw=; b=rTfpopt8zao2QMDWZHsHVPIaogQnJDklb0Une1B4kmpqjlky+/CPgSiAEGyCWx8+Gg WEqF5WYHzshz+6z7UvpVQN1hZwFzpid7SfCMM1eS0sj1dDRcoKwZ+KEqzfMLjciGH5KG /lytQtFT3oB41BaYBA0mvqJATxbBq3/saJQloNQmwvodZUPSgC+i7MfAEC/1GvTsrd8S D7oeY9vlQgCk3oA2Kipz2bd33gLYnx7zpHHS/009+A1JLFYFKZPJPV9lfb1VEYdHBgnz VFmehzf/qTLRePaE07m9lTI04wFkxsS+0Le+umfD1K5LdzC5AqHCA5xbzkOo+uQyMmf5 7dZw== X-Gm-Message-State: AOAM530ZmvWS/0IQcfj56bQn7r+7Q5gn7q8DJBl4qImWmOcWMWpywXSs uT5zl1I42o/Y36v33eT4Mmd7xiKf2btSuQ== X-Google-Smtp-Source: ABdhPJzSc2ESnEMB8pnICcxfybX3I1DbquopD7QOl27N2POjjalvV22HoQM/H18rVmTmceMyCTSf8A== X-Received: by 2002:a17:902:8f8b:b029:12c:d085:7918 with SMTP id z11-20020a1709028f8bb029012cd0857918mr10423716plo.10.1629351683886; Wed, 18 Aug 2021 22:41:23 -0700 (PDT) Received: from localhost.localdomain (c-73-93-239-127.hsd1.ca.comcast.net. [73.93.239.127]) by smtp.gmail.com with ESMTPSA id s188sm1708312pfb.4.2021.08.18.22.41.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 22:41:22 -0700 (PDT) From: Yang Shi To: naoya.horiguchi@nec.com, osalvador@suse.de, tdmackey@twitter.com, david@redhat.com, willy@infradead.org, akpm@linux-foundation.org, corbet@lwn.net Cc: shy828301@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [v2 PATCH 3/3] mm: hwpoison: dump page for unhandlable page Date: Wed, 18 Aug 2021 22:41:16 -0700 Message-Id: <20210819054116.266126-3-shy828301@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210819054116.266126-1-shy828301@gmail.com> References: <20210819054116.266126-1-shy828301@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: BE5C5901E59A X-Stat-Signature: ftuuunknnjc8cs6mjs17djggdsym1os4 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=PpGbgxwR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of shy828301@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-HE-Tag: 1629351684-249089 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently just very simple message is shown for unhandlable page, e.g. non-LRU page, like: soft_offline: 0x1469f2: unknown non LRU page type 5ffff0000000000 () It is not very helpful for further debug, calling dump_page() could show more useful information. Calling dump_page() in get_any_page() in order to not duplicate the call in a couple of different places. It may be called with pcp disabled and holding memory hotplug lock, it should be not a big deal since hwpoison handler is not called very often. Suggested-by: Matthew Wilcox Cc: Naoya Horiguchi Cc: Oscar Salvador Signed-off-by: Yang Shi --- mm/memory-failure.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 7cfa134b1370..60df8fcd0444 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -1228,6 +1228,9 @@ static int get_any_page(struct page *p, unsigned lo= ng flags) ret =3D -EIO; } out: + if (ret =3D=3D -EIO) + dump_page(p, "hwpoison: unhandlable page"); + return ret; } =20 --=20 2.26.2