From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A8EDC4338F for ; Tue, 17 Aug 2021 15:39:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 381E960FE6 for ; Tue, 17 Aug 2021 15:39:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 381E960FE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5A80B8D0001; Tue, 17 Aug 2021 11:39:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 557646B0072; Tue, 17 Aug 2021 11:39:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 445A78D0001; Tue, 17 Aug 2021 11:39:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id 270486B0071 for ; Tue, 17 Aug 2021 11:39:43 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A715B8249980 for ; Tue, 17 Aug 2021 15:39:42 +0000 (UTC) X-FDA: 78484982604.21.F4196F5 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf24.hostedemail.com (Postfix) with ESMTP id 3ACA8B000803 for ; Tue, 17 Aug 2021 15:39:42 +0000 (UTC) Date: Tue, 17 Aug 2021 17:39:37 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1629214778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VijU9XyWJmgrJnMm1liziV+i68ZEXkpFrVAD78kLVvY=; b=srIWTjAHSBKRX4Ko/AoyjMsWogoODmGdhFAuZ9fDrDzwxKS5UwZAQjYP9hTXb2byQF0R0e Ghk3RpScGKHLnzAgPm3+pzlEHsR9jPldf626uUglIi753fAb05a43SJ8qeooAWAXcFIMCh cHNMh9BLl6UTk4hBjNhIL3EObdkPcKedf8IqiahQNXr9Sy4DP/4mqRxMPcivvcXn75orF3 XhSRL5jDU2QP6kWL6J8hEZhfn4SR0INvXGIOWlYrXu1HfyqjLmFu68BZoOwuSoATvPx2aL LGbPAitILUS1TNMwTab9r7AZxXmb9CtnVv13i8u5BPTN5HWtmKtFW1UNnLW3Iw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1629214778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VijU9XyWJmgrJnMm1liziV+i68ZEXkpFrVAD78kLVvY=; b=5YdvNXY8zZaHutR7hCZ2S7eiejzeEkVg4K8AjM98dNRTM/1T2YoVZzf2YqVdME35afRafB lRMZNCVDmpzOVQBQ== From: Sebastian Andrzej Siewior To: Vlastimil Babka Cc: Andrew Morton , Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Galbraith , Thomas Gleixner , Mel Gorman , Jesper Dangaard Brouer , Jann Horn Subject: Re: [PATCH v4 35/35] mm, slub: convert kmem_cpu_slab protection to local_lock Message-ID: <20210817153937.hxnuh7mqp6vuiyws@linutronix.de> References: <20210805152000.12817-1-vbabka@suse.cz> <20210805152000.12817-36-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210805152000.12817-36-vbabka@suse.cz> Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=srIWTjAH; dkim=pass header.d=linutronix.de header.s=2020e header.b=5YdvNXY8; spf=pass (imf24.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3ACA8B000803 X-Stat-Signature: s756aet88s6if7e4qp5x47h1i4pohmgz X-HE-Tag: 1629214782-714440 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021-08-05 17:20:00 [+0200], Vlastimil Babka wrote: > @@ -2849,7 +2891,11 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, > > load_freelist: > > - lockdep_assert_irqs_disabled(); > +#ifdef CONFIG_PREEMPT_RT > + lockdep_assert_held(this_cpu_ptr(&s->cpu_slab->lock.lock)); > +#else > + lockdep_assert_held(this_cpu_ptr(&s->cpu_slab->lock)); > +#endif Could you please make this hunk only lockdep_assert_held(this_cpu_ptr(&s->cpu_slab->lock)); i.e. the non-RT version? > /* > * freelist is pointing to the list of objects to be used. Sebastian