From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 979B6C4320E for ; Tue, 17 Aug 2021 05:49:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5B64F60F5C for ; Tue, 17 Aug 2021 05:49:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5B64F60F5C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EFA206B0073; Tue, 17 Aug 2021 01:49:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E80506B0072; Tue, 17 Aug 2021 01:49:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D48498D0001; Tue, 17 Aug 2021 01:49:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id BC01A6B006C for ; Tue, 17 Aug 2021 01:49:03 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5239022ADC for ; Tue, 17 Aug 2021 05:49:03 +0000 (UTC) X-FDA: 78483494166.08.B202563 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf28.hostedemail.com (Postfix) with ESMTP id F0CEB9007A93 for ; Tue, 17 Aug 2021 05:49:02 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 140406736F; Tue, 17 Aug 2021 07:49:01 +0200 (CEST) Date: Tue, 17 Aug 2021 07:49:00 +0200 From: Christoph Hellwig To: "Sierra Guiza, Alejandro (Alex)" Cc: Christoph Hellwig , akpm@linux-foundation.org, Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, jgg@nvidia.com, jglisse@redhat.com Subject: Re: [PATCH v6 05/13] drm/amdkfd: generic type as sys mem on migration to ram Message-ID: <20210817054900.GB4895@lst.de> References: <20210813063150.2938-1-alex.sierra@amd.com> <20210813063150.2938-6-alex.sierra@amd.com> <20210815153825.GB32384@lst.de> <694ea624-9dc7-7a25-78a6-308ee0debaea@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <694ea624-9dc7-7a25-78a6-308ee0debaea@amd.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: F0CEB9007A93 Authentication-Results: imf28.hostedemail.com; dkim=none; spf=none (imf28.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspamd-Server: rspam01 X-Stat-Signature: fkofmftsrpfzun3c98codos9qzkwfryx X-HE-Tag: 1629179342-324202 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 16, 2021 at 02:53:18PM -0500, Sierra Guiza, Alejandro (Alex) = wrote: > For above=E2=80=99s condition equal to connected_to_cpu , we=E2=80=99re= explicitly=20 > migrating from > device memory to system memory with device generic type. In this type,=20 > device PTEs are > present in CPU page table. > > During migrate_vma_collect_pmd walk op at migrate_vma_setup call, there= =E2=80=99s=20 > a condition > for present pte that require migrate->flags be set for=20 > MIGRATE_VMA_SELECT_SYSTEM. > Otherwise, the migration for this entry will be ignored. I think we might need a new SELECT flag here for IOMEM.