From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30B01C4338F for ; Mon, 16 Aug 2021 13:05:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A82AA632B1 for ; Mon, 16 Aug 2021 13:05:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A82AA632B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 073B18D0001; Mon, 16 Aug 2021 09:05:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 023CD6B0072; Mon, 16 Aug 2021 09:05:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7C468D0001; Mon, 16 Aug 2021 09:05:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id CDF5F6B0071 for ; Mon, 16 Aug 2021 09:05:50 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5D7B41808F54F for ; Mon, 16 Aug 2021 13:05:50 +0000 (UTC) X-FDA: 78480966060.34.9EF970F Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf14.hostedemail.com (Postfix) with ESMTP id C8D4A6008F47 for ; Mon, 16 Aug 2021 13:05:49 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BA9821FB; Mon, 16 Aug 2021 06:05:48 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 628673F66F; Mon, 16 Aug 2021 06:05:47 -0700 (PDT) Date: Mon, 16 Aug 2021 14:05:44 +0100 From: Cristian Marussi To: Arnd Bergmann Cc: kernel test robot , Igor Skalkin , kbuild-all@lists.01.org, Linux Memory Management List , Sudeep Holla , Peter Hilber Subject: Re: [linux-next:master 5053/7963] virtio.c:undefined reference to `virtio_check_driver_offered_feature' Message-ID: <20210816130544.GZ6592@e120937-lin> References: <202108151230.lcHk2Pkk-lkp@intel.com> <20210816102209.GY6592@e120937-lin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf14.hostedemail.com: domain of cristian.marussi@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=cristian.marussi@arm.com X-Stat-Signature: mxryciza8sbp1i1hzzb6mic98q87oooi X-Rspamd-Queue-Id: C8D4A6008F47 X-Rspamd-Server: rspam05 X-HE-Tag: 1629119149-650243 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 16, 2021 at 02:11:19PM +0200, Arnd Bergmann wrote: > On Mon, Aug 16, 2021 at 12:22 PM Cristian Marussi > wrote: > > On Sun, Aug 15, 2021 at 12:54:38PM +0800, kernel test robot wrote: > > > > diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig > > index 7f4d2435503b..daa349615e91 100644 > > --- a/drivers/firmware/arm_scmi/Kconfig > > +++ b/drivers/firmware/arm_scmi/Kconfig > > @@ -4,6 +4,7 @@ menu "ARM System Control and Management Interface Protocol" > > config ARM_SCMI_PROTOCOL > > tristate "ARM System Control and Management Interface (SCMI) Message Protocol" > > depends on ARM || ARM64 || COMPILE_TEST > > + select VIRTIO if ARM_SCMI_TRANSPORT_VIRTIO > > help > > ARM System Control and Management Interface (SCMI) protocol is a > > set of operating system-independent software interfaces that are > > @@ -68,7 +69,6 @@ config ARM_SCMI_TRANSPORT_SMC > > > > config ARM_SCMI_TRANSPORT_VIRTIO > > bool "SCMI transport based on VirtIO" > > - depends on VIRTIO > > select ARM_SCMI_HAVE_TRANSPORT > > select ARM_SCMI_HAVE_MSG > > help > Hi Arnd, > Generally speaking it's bad to have both 'select' and 'depends on' for > drivers using > the same subsystem. This can lead to both circular dependencies, and to general > confusion when users are surprised by this. > Thanks a lot for the feedback/explanation. > My recommendation is to stick with 'depends on' in general, as that is usually > what you want. In this case, there are two things you could do that work better > to solve this problem: > > a) add 'depends on VIRTIO || !VIRTIO' under ARM_SCMI_PROTOCOL, to prevent > it from being built-in when virtio is a loadable module > > b) change the dependency in ARM_SCMI_TRANSPORT_VIRTIO to list the > correct thing, as in 'depends on VIRTIO=y || VIRTIO=ARM_SCMI_PROTOCOL'. > > I don't have a strong preference between those two, as neither of them is > perfect: either you and up not seeing the virtio transport option, or you force > ARM_SCMI_PROTOCOL to be non-built-in when virtio is a module even > when the virtio transport is disabled. I'll go for b) and post a fix. Thanks, Cristian