From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3BD3C4338F for ; Sun, 15 Aug 2021 15:38:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5470F6120E for ; Sun, 15 Aug 2021 15:38:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5470F6120E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EA4DE6B0072; Sun, 15 Aug 2021 11:38:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E54F46B0073; Sun, 15 Aug 2021 11:38:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6B136B0074; Sun, 15 Aug 2021 11:38:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id BDADE6B0072 for ; Sun, 15 Aug 2021 11:38:28 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 71ABA20301 for ; Sun, 15 Aug 2021 15:38:28 +0000 (UTC) X-FDA: 78477721896.39.8CDC7BB Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf15.hostedemail.com (Postfix) with ESMTP id 1F8B5D003FC4 for ; Sun, 15 Aug 2021 15:38:28 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 38F4867357; Sun, 15 Aug 2021 17:38:26 +0200 (CEST) Date: Sun, 15 Aug 2021 17:38:25 +0200 From: Christoph Hellwig To: Alex Sierra Cc: akpm@linux-foundation.org, Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jgg@nvidia.com, jglisse@redhat.com Subject: Re: [PATCH v6 05/13] drm/amdkfd: generic type as sys mem on migration to ram Message-ID: <20210815153825.GB32384@lst.de> References: <20210813063150.2938-1-alex.sierra@amd.com> <20210813063150.2938-6-alex.sierra@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210813063150.2938-6-alex.sierra@amd.com> User-Agent: Mutt/1.5.17 (2007-11-01) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=none (imf15.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1F8B5D003FC4 X-Stat-Signature: kdwz43msh1ix7azidwb9uuebozgixtce X-HE-Tag: 1629041908-1066 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 13, 2021 at 01:31:42AM -0500, Alex Sierra wrote: > migrate.vma = vma; > migrate.start = start; > migrate.end = end; > - migrate.flags = MIGRATE_VMA_SELECT_DEVICE_PRIVATE; > migrate.pgmap_owner = SVM_ADEV_PGMAP_OWNER(adev); > > + if (adev->gmc.xgmi.connected_to_cpu) > + migrate.flags = MIGRATE_VMA_SELECT_SYSTEM; > + else > + migrate.flags = MIGRATE_VMA_SELECT_DEVICE_PRIVATE; It's been a while since I touched this migrate code, but doesn't this mean that if the range already contains system memory the migration now won't do anything? for the connected_to_cpu case?