From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42079C432BE for ; Sat, 14 Aug 2021 05:26:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E883460E9B for ; Sat, 14 Aug 2021 05:26:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E883460E9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 92D638D000D; Sat, 14 Aug 2021 01:26:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DD568D0002; Sat, 14 Aug 2021 01:26:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A5A68D000D; Sat, 14 Aug 2021 01:26:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 61CA68D0002 for ; Sat, 14 Aug 2021 01:26:38 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 051CE1803619A for ; Sat, 14 Aug 2021 05:26:38 +0000 (UTC) X-FDA: 78472551276.36.1CFDF7C Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf15.hostedemail.com (Postfix) with ESMTP id B1695D0020F6 for ; Sat, 14 Aug 2021 05:26:37 +0000 (UTC) Received: by mail-pj1-f53.google.com with SMTP id j12-20020a17090aeb0c00b00179530520b3so3426671pjz.0 for ; Fri, 13 Aug 2021 22:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QA9/p/h+KpQBCu0VXssIO4coGl6opMzNI5lAhcd+PlA=; b=KDQ5YMhgkeEAvreorbhUVEHxzOIds006yyG7sFmzuFq31cEDc/SNg2TOFchU4xbqWa 1XBG/aepaxXn4ctwfkD+f/wOUrWBRIMwaiB/0STszbdDRmsudQEoxsiLYs+6OMrNMJmB lNnQy25bdCLe9AuL4d7jAWRz+ndeHYY94Nn9oZEZoNugTMW9s5H3sbODiyzgNZyUnu+R y5KbGSFShj/a7gotHGrE44xj0sl1YilJ1zP19RRFJhAZpTYnFgzpUTJG5HHTeNOY75vA ZCLc90EFBuIz3S94EHEGHwZZxcvZnVnCXiwTvgtNKIrH0DnSsXops3lWSlu3cQ7tjJNW tHqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QA9/p/h+KpQBCu0VXssIO4coGl6opMzNI5lAhcd+PlA=; b=KOwAYVdYYKdc+qG6dPwOvXbKkLX/x5Jh0uOa94MYlMg3w51ltcvZgrIv3CY/sSqb4f qCUTftt1yKAOmTb3Rikxfy10VIcsx64WmEFAtKZgFUuI3H88oxSa4Fi2yMmIAn/rPNaB dwUJElYWOAL85IHdeyPB3fGsSaICmspwsLTIFbQTDlfjACfOPqYXuPb1vZicuRYNoNZ8 LxajqXjJRT97himbg6gUPPo5gS9ym5vthCYs712PKih1YgGLU8M08NivxMstYauXBAPU N2UVBzc2b9BcNZSIJEIV9aQ18Zj4NZ/VeK3HoO4+pWIPlURT5gdhOXjFFivq8KtzmDEw v7uA== X-Gm-Message-State: AOAM531ig8VzLB9iHjfYNn3eNXFy0v58iIGhPl65vm2aJup51IDw7dx5 cHBu1zFFQkjNjCBs6TpoC2SYLw== X-Google-Smtp-Source: ABdhPJxgg7nnSBePeld5ZlmypZa6XkSzDz0hdBCtPjQN0Tp1f4d/XEOeVbI75li7/4OYOqGU73DoMg== X-Received: by 2002:a65:62c1:: with SMTP id m1mr5447376pgv.339.1628918796923; Fri, 13 Aug 2021 22:26:36 -0700 (PDT) Received: from localhost.localdomain ([139.177.225.237]) by smtp.gmail.com with ESMTPSA id s5sm4783133pgp.81.2021.08.13.22.26.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Aug 2021 22:26:36 -0700 (PDT) From: Muchun Song To: guro@fb.com, hannes@cmpxchg.org, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, fam.zheng@bytedance.com, bsingharora@gmail.com, shy828301@gmail.com, alexs@kernel.org, smuchun@gmail.com, zhengqi.arch@bytedance.com, Muchun Song Subject: [PATCH v1 11/12] mm: lru: add VM_BUG_ON_FOLIO to lru maintenance function Date: Sat, 14 Aug 2021 13:25:18 +0800 Message-Id: <20210814052519.86679-12-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) In-Reply-To: <20210814052519.86679-1-songmuchun@bytedance.com> References: <20210814052519.86679-1-songmuchun@bytedance.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: B1695D0020F6 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=KDQ5YMhg; spf=pass (imf15.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam01 X-Stat-Signature: 1expqacqyzxgeqkofhrif5a58h4scxud X-HE-Tag: 1628918797-691462 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We need to make sure that the page is deleted from or added to the correct lruvec list. So add a VM_BUG_ON_FOLIO() to catch invalid users. Signed-off-by: Muchun Song --- include/linux/mm_inline.h | 15 ++++++++++++--- mm/vmscan.c | 1 - 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h index e2ec68b0515c..60eb827a41fe 100644 --- a/include/linux/mm_inline.h +++ b/include/linux/mm_inline.h @@ -103,7 +103,10 @@ void lruvec_add_folio(struct lruvec *lruvec, struct = folio *folio) static __always_inline void add_page_to_lru_list(struct page *page, struct lruvec *lruvec) { - lruvec_add_folio(lruvec, page_folio(page)); + struct folio *folio =3D page_folio(page); + + VM_BUG_ON_FOLIO(!folio_matches_lruvec(folio, lruvec), folio); + lruvec_add_folio(lruvec, folio); } =20 static __always_inline @@ -119,7 +122,10 @@ void lruvec_add_folio_tail(struct lruvec *lruvec, st= ruct folio *folio) static __always_inline void add_page_to_lru_list_tail(struct page *page, struct lruvec *lruvec) { - lruvec_add_folio_tail(lruvec, page_folio(page)); + struct folio *folio =3D page_folio(page); + + VM_BUG_ON_FOLIO(!folio_matches_lruvec(folio, lruvec), folio); + lruvec_add_folio_tail(lruvec, folio); } =20 static __always_inline @@ -133,6 +139,9 @@ void lruvec_del_folio(struct lruvec *lruvec, struct f= olio *folio) static __always_inline void del_page_from_lru_list(struct page *page, struct lruvec *lruvec) { - lruvec_del_folio(lruvec, page_folio(page)); + struct folio *folio =3D page_folio(page); + + VM_BUG_ON_FOLIO(!folio_matches_lruvec(folio, lruvec), folio); + lruvec_del_folio(lruvec, folio); } #endif diff --git a/mm/vmscan.c b/mm/vmscan.c index 8ce42858ad5d..902d36ec91a3 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2204,7 +2204,6 @@ static unsigned int move_pages_to_lru(struct list_h= ead *list) continue; } =20 - VM_BUG_ON_PAGE(!folio_matches_lruvec(folio, lruvec), page); add_page_to_lru_list(page, lruvec); nr_pages =3D thp_nr_pages(page); nr_moved +=3D nr_pages; --=20 2.11.0