From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7774CC432BE for ; Fri, 13 Aug 2021 07:03:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 46C2F610CC for ; Fri, 13 Aug 2021 07:03:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 46C2F610CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id DB4B46B006C; Fri, 13 Aug 2021 03:03:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D64E06B0072; Fri, 13 Aug 2021 03:03:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7B5B6B0073; Fri, 13 Aug 2021 03:03:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id B38496B006C for ; Fri, 13 Aug 2021 03:03:37 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6DF848249980 for ; Fri, 13 Aug 2021 07:03:37 +0000 (UTC) X-FDA: 78469166874.33.20BA179 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf27.hostedemail.com (Postfix) with ESMTP id 17C8970053FE for ; Fri, 13 Aug 2021 07:03:37 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 314E46736F; Fri, 13 Aug 2021 09:03:35 +0200 (CEST) Date: Fri, 13 Aug 2021 09:03:34 +0200 From: Christoph Hellwig To: David Howells Cc: willy@infradead.org, Seth Jennings , Bob Liu , Minchan Kim , Dan Magenheimer , trond.myklebust@primarydata.com, darrick.wong@oracle.com, hch@lst.de, viro@zeniv.linux.org.uk, jlayton@kernel.org, sfrench@samba.org, torvalds@linux-foundation.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 2/5] mm: Remove the callback func argument from __swap_writepage() Message-ID: <20210813070334.GB26339@lst.de> References: <162879971699.3306668.8977537647318498651.stgit@warthog.procyon.org.uk> <162879973548.3306668.4893577928865857447.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162879973548.3306668.4893577928865857447.stgit@warthog.procyon.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Stat-Signature: 6jstzwunjhakqqssfu9banh4q9ti7za6 X-Rspamd-Queue-Id: 17C8970053FE X-Rspamd-Server: rspam05 X-HE-Tag: 1628838217-931131 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 12, 2021 at 09:22:15PM +0100, David Howells wrote: > Remove the callback func argument from __swap_writepage() as it's > end_swap_bio_write() in both places that call it. Yeah. I actually had a similar patch in a WIP tree for a while but never got to end it out. > /* linux/mm/page_io.c */ > extern int swap_readpage(struct page *page, bool do_poll); > extern int swap_writepage(struct page *page, struct writeback_control *wbc); > -extern void end_swap_bio_write(struct bio *bio); > -extern int __swap_writepage(struct page *page, struct writeback_control *wbc, > - bio_end_io_t end_write_func); > +extern int __swap_writepage(struct page *page, struct writeback_control *wbc); Please also drop the extern while you're at it. With that: Reviewed-by: Christoph Hellwig