From: Christoph Hellwig <hch@lst.de>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, linux-s390@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v2 2/3] mm/gup: small refactoring: simplify try_grab_page()
Date: Thu, 12 Aug 2021 11:20:43 +0200 [thread overview]
Message-ID: <20210812092043.GA4827@lst.de> (raw)
In-Reply-To: <20210811070542.3403116-3-jhubbard@nvidia.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
Note: the __maybe_unused on try_grab_compound_head should be dropped now
that there is always a user.
next prev parent reply other threads:[~2021-08-12 9:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 7:05 [PATCH v2 0/3] A few gup refactorings and documentation updates John Hubbard
2021-08-11 7:05 ` [PATCH v2 1/3] mm/gup: documentation corrections for gup/pup John Hubbard
2021-08-11 7:05 ` [PATCH v2 2/3] mm/gup: small refactoring: simplify try_grab_page() John Hubbard
2021-08-12 9:20 ` Christoph Hellwig [this message]
2021-08-12 21:59 ` John Hubbard
2021-08-11 7:05 ` [PATCH v2 3/3] mm/gup: Remove try_get_page(), call try_get_compound_head() directly John Hubbard
2021-08-11 20:35 ` William Kucharski
2021-08-11 22:07 ` John Hubbard
2021-08-12 2:17 ` William Kucharski
2021-08-12 9:22 ` Christoph Hellwig
2021-08-12 18:19 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812092043.GA4827@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jhubbard@nvidia.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox