From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C57C4320A for ; Wed, 11 Aug 2021 05:22:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 54AB161008 for ; Wed, 11 Aug 2021 05:22:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 54AB161008 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id AF0696B0073; Wed, 11 Aug 2021 01:22:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA0148D0001; Wed, 11 Aug 2021 01:22:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B5EB6B0075; Wed, 11 Aug 2021 01:22:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0145.hostedemail.com [216.40.44.145]) by kanga.kvack.org (Postfix) with ESMTP id 808726B0073 for ; Wed, 11 Aug 2021 01:22:34 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 35B118249980 for ; Wed, 11 Aug 2021 05:22:34 +0000 (UTC) X-FDA: 78461654628.39.AD00946 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf10.hostedemail.com (Postfix) with ESMTP id 8B28C600AAA9 for ; Wed, 11 Aug 2021 05:22:33 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id C851668AFE; Wed, 11 Aug 2021 07:22:29 +0200 (CEST) Date: Wed, 11 Aug 2021 07:22:29 +0200 From: Christoph Hellwig To: Guenter Roeck Cc: Christoph Hellwig , Jens Axboe , Tejun Heo , Jan Kara , linux-block@vger.kernel.org, Andrew Morton , cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/5] mm: hide laptop_mode_wb_timer entirely behind the BDI API Message-ID: <20210811052229.GA1696@lst.de> References: <20210809141744.1203023-1-hch@lst.de> <20210809141744.1203023-2-hch@lst.de> <20210810215622.GA874076@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210810215622.GA874076@roeck-us.net> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8B28C600AAA9 Authentication-Results: imf10.hostedemail.com; dkim=none; spf=none (imf10.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Stat-Signature: 3rmfqt6dcciunzy15mthoq54ojpofm9o X-HE-Tag: 1628659353-466828 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 10, 2021 at 02:56:22PM -0700, Guenter Roeck wrote: > On Mon, Aug 09, 2021 at 04:17:40PM +0200, Christoph Hellwig wrote: > > Don't leak the deta=D1=96ls of the timer into the block layer, instea= d > > initialize the timer in bdi_alloc and delete it in bdi_unregister. > > Note that this means the timer is initialized (but not armed) for > > non-block queues as well now. > >=20 > > Signed-off-by: Christoph Hellwig > > --- >=20 > Just in case this hasn't been reported yet. > This patch results in a widespread build failure. Example: Sorry. This was reported before and a fix is already queued up here: https://git.kernel.dk/cgit/linux-block/commit/?h=3Dfor-5.15/block&id=3D99= d26de2f6d79badc80f55b54bd90d4cb9d1ad90