From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C57AFC4338F for ; Tue, 10 Aug 2021 21:56:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 37EBD60FDA for ; Tue, 10 Aug 2021 21:56:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 37EBD60FDA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 948C66B0072; Tue, 10 Aug 2021 17:56:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F8416B0073; Tue, 10 Aug 2021 17:56:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BFB26B0074; Tue, 10 Aug 2021 17:56:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id 602AA6B0072 for ; Tue, 10 Aug 2021 17:56:25 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1A545824999B for ; Tue, 10 Aug 2021 21:56:25 +0000 (UTC) X-FDA: 78460530330.03.B28A725 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by imf07.hostedemail.com (Postfix) with ESMTP id BCB0D10038E2 for ; Tue, 10 Aug 2021 21:56:24 +0000 (UTC) Received: by mail-oi1-f170.google.com with SMTP id bi32so1367506oib.2 for ; Tue, 10 Aug 2021 14:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=JhQsCvjsX4aQ7AO0EcBhog4UmHjKzja8YKewWn/brBE=; b=NW6MnPyrxBCjdUNnbAdmDsnldUDzEXZD36UQwc7aL97R33BDGIc/OHc9ppOitiH2lE 0jYNPSNPthFpMB5rIgY+POar807qjsE8bwv7pAFb82Ia4c0eakrMfq0ioZth6y5tKnJy 2UzPnKG2J95PKPW+dC6i8cXlP5EWxfcc8UDn4Vdhh4dF50iyqL7Q6HIVEQZ91mtwI8dK qZkcKgmA1qvebHnr9ZAWPW0pLDjaygLbXIm+jrPc7EJZENzxE/FrF69cg/uhoeivFIIu kifuuPta/ThocQD8ZiJyb2UxrmtwUtyLRXTzLs7x0InuuhV8u5AHFtZM6+8HZrcGAXxn vO2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=JhQsCvjsX4aQ7AO0EcBhog4UmHjKzja8YKewWn/brBE=; b=fipNIsnsThhfuxe22zdbzgXOVxlvqhA2uvi4iR2PGl6dl0+SecXkNQ+7/16VMgtORk pgDkl2K46gYZPLP78GJki7rZNCICSEXvtlyoJMGxsrnsO64ZdVMD/vfKRXNjnhKSMWAK KAbiUgZodFc1UYgcX5VkfFSaXbJY5RLnJzydZMa2uIrtoEAd9n42IQ3uY+9NwU7BL8l/ Lp/ADXZK3mcK43BQb9+2Cvp5t/f1jj34MI4X7ZUJ9Q2dZ/SQeXgtdDsQx5wzrAVi3K2E PM+bv8UHq8AkpSZ/ZN4d7NEg7Gf7ARG4B7ICsf4XL6uHuCOqBQo4kaUGsN7RkFifBqxB UFzQ== X-Gm-Message-State: AOAM530Nj8Vbw08YZJ5EQsW0en5nSuyoxiZZgnKlj0vDCnKrZj7iUiwh GcOhSRys5cpBbvsGwbLxj9Y= X-Google-Smtp-Source: ABdhPJw6/9eEqccmAinCUXjeXr3qCuw+fiIj44SxsWN9sSw4bECkVmOOmTmRzmqaEcSTW0NcExehIg== X-Received: by 2002:a54:468d:: with SMTP id k13mr5181021oic.125.1628632584113; Tue, 10 Aug 2021 14:56:24 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id c26sm4129659otu.38.2021.08.10.14.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 14:56:23 -0700 (PDT) Date: Tue, 10 Aug 2021 14:56:22 -0700 From: Guenter Roeck To: Christoph Hellwig Cc: Jens Axboe , Tejun Heo , Jan Kara , linux-block@vger.kernel.org, Andrew Morton , cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/5] mm: hide laptop_mode_wb_timer entirely behind the BDI API Message-ID: <20210810215622.GA874076@roeck-us.net> References: <20210809141744.1203023-1-hch@lst.de> <20210809141744.1203023-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210809141744.1203023-2-hch@lst.de> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: BCB0D10038E2 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=NW6MnPyr; dmarc=none; spf=pass (imf07.hostedemail.com: domain of groeck7@gmail.com designates 209.85.167.170 as permitted sender) smtp.mailfrom=groeck7@gmail.com X-Stat-Signature: ohjqk51bgpbhyemouq1mhyubox6gdzqz X-HE-Tag: 1628632584-5221 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 09, 2021 at 04:17:40PM +0200, Christoph Hellwig wrote: > Don't leak the deta=D1=96ls of the timer into the block layer, instead > initialize the timer in bdi_alloc and delete it in bdi_unregister. > Note that this means the timer is initialized (but not armed) for > non-block queues as well now. >=20 > Signed-off-by: Christoph Hellwig > --- Just in case this hasn't been reported yet. This patch results in a widespread build failure. Example: Building x86_64:tinyconfig ... failed -------------- Error log: mm/page-writeback.c:2044:6: error: redefinition of 'laptop_sync_completio= n' 2044 | void laptop_sync_completion(void) | ^~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/memcontrol.h:22, from include/linux/swap.h:9, from mm/page-writeback.c:20: include/linux/writeback.h:345:20: note: previous definition of 'laptop_sy= nc_completion' with type 'void(void)' 345 | static inline void laptop_sync_completion(void) { } | ^~~~~~~~~~~~~~~~~~~~~~ make[2]: *** [scripts/Makefile.build:272: mm/page-writeback.o] Error 1 Guenter --- bisect log: # bad: [92d00774360dfd4151f15ab9905c643347b9f242] Add linux-next specific= files for 20210810 # good: [36a21d51725af2ce0700c6ebcb6b9594aac658a6] Linux 5.14-rc5 git bisect start 'HEAD' 'v5.14-rc5' # good: [01dda625c9b7cfd3bf5ac05f73da8c512792f94c] Merge remote-tracking = branch 'crypto/master' git bisect good 01dda625c9b7cfd3bf5ac05f73da8c512792f94c # bad: [75cadd49361c6650764d35bcbb6c9cb9f0a9d9a3] Merge remote-tracking b= ranch 'irqchip/irq/irqchip-next' git bisect bad 75cadd49361c6650764d35bcbb6c9cb9f0a9d9a3 # good: [511b0c991c9d49fd6d8188f799b10aa0465cecf3] Merge remote-tracking = branch 'drm-intel/for-linux-next' git bisect good 511b0c991c9d49fd6d8188f799b10aa0465cecf3 # good: [f3b48aa06fb8b4384b90e41220da8be5a4013a6d] Merge remote-tracking = branch 'input/next' git bisect good f3b48aa06fb8b4384b90e41220da8be5a4013a6d # bad: [87470038c43f9577a300a29ba6c2c95d28039464] Merge remote-tracking b= ranch 'regulator/for-next' git bisect bad 87470038c43f9577a300a29ba6c2c95d28039464 # bad: [e1796683109e4ba27c73f099486555a36820b175] Merge remote-tracking b= ranch 'device-mapper/for-next' git bisect bad e1796683109e4ba27c73f099486555a36820b175 # bad: [a11d7fc2d05fb509cd9e33d4093507d6eda3ad53] block: remove the bd_bd= i in struct block_device git bisect bad a11d7fc2d05fb509cd9e33d4093507d6eda3ad53 # good: [a291bb43e5c9fdedc4be3dfd496e64e7c5a78b1f] block: use the %pg for= mat specifier in show_partition git bisect good a291bb43e5c9fdedc4be3dfd496e64e7c5a78b1f # good: [2112f5c1330a671fa852051d85cb9eadc05d7eb7] loop: Select I/O sched= uler 'none' from inside add_disk() git bisect good 2112f5c1330a671fa852051d85cb9eadc05d7eb7 # good: [ba30585936b0b88f0fb2b19be279b346a6cc87eb] dm: move setting md->t= ype into dm_setup_md_queue git bisect good ba30585936b0b88f0fb2b19be279b346a6cc87eb # bad: [5ed964f8e54eb3191b8b7b45aeb52672a0c995dc] mm: hide laptop_mode_wb= _timer entirely behind the BDI API git bisect bad 5ed964f8e54eb3191b8b7b45aeb52672a0c995dc # good: [d1254a8749711e0d7441036a74ce592341f89697] block: remove support = for delayed queue registrations git bisect good d1254a8749711e0d7441036a74ce592341f89697 # first bad commit: [5ed964f8e54eb3191b8b7b45aeb52672a0c995dc] mm: hide l= aptop_mode_wb_timer entirely behind the BDI API