From: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
To: Gavin Shan <gshan@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
anshuman.khandual@arm.com, aneesh.kumar@linux.ibm.com,
christophe.leroy@csgroup.eu, cai@lca.pw, catalin.marinas@arm.com,
will@kernel.org, vgupta@synopsys.com, akpm@linux-foundation.org,
chuhu@redhat.com, shan.gavin@gmail.com
Subject: Re: [PATCH v6 00/12] mm/debug_vm_pgtable: Enhancements
Date: Tue, 10 Aug 2021 18:05:35 +0200 [thread overview]
Message-ID: <20210810180535.08ecc800@thinkpad> (raw)
In-Reply-To: <20210809092631.1888748-1-gshan@redhat.com>
On Mon, 9 Aug 2021 17:26:19 +0800
Gavin Shan <gshan@redhat.com> wrote:
> There are couple of issues with current implementations and this series
> tries to resolve the issues:
>
> (a) All needed information are scattered in variables, passed to various
> test functions. The code is organized in pretty much relaxed fashion.
>
> (b) The page isn't allocated from buddy during page table entry modifying
> tests. The page can be invalid, conflicting to the implementations
> of set_xxx_at() on ARM64. The target page is accessed so that the
> iCache can be flushed when execution permission is given on ARM64.
> Besides, the target page can be unmapped and accessing to it causes
> kernel crash.
>
> "struct pgtable_debug_args" is introduced to address issue (a). For issue
> (b), the used page is allocated from buddy in page table entry modifying
> tests. The corresponding tets will be skipped if we fail to allocate the
> (huge) page. For other test cases, the original page around to kernel
> symbol (@start_kernel) is still used.
>
> The patches are organized as below. PATCH[2-10] could be combined to one
> patch, but it will make the review harder:
>
> PATCH[1] introduces "struct pgtable_debug_args" as place holder of all
> needed information. With it, the old and new implementation
> can coexist.
> PATCH[2-10] uses "struct pgtable_debug_args" in various test functions.
> PATCH[11] removes the unused code for old implementation.
> PATCH[12] fixes the issue of corrupted page flag for ARM64
Tested on s390, all seems to work fine.
Gerald
next prev parent reply other threads:[~2021-08-10 16:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 9:26 Gavin Shan
2021-08-09 9:26 ` [PATCH v6 01/12] mm/debug_vm_pgtable: Introduce struct pgtable_debug_args Gavin Shan
2021-08-09 9:26 ` [PATCH v6 02/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in basic tests Gavin Shan
2021-08-09 9:26 ` [PATCH v6 03/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in leaf and savewrite tests Gavin Shan
2021-08-09 9:26 ` [PATCH v6 04/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in protnone and devmap tests Gavin Shan
2021-08-09 9:26 ` [PATCH v6 05/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in soft_dirty and swap tests Gavin Shan
2021-08-09 9:26 ` [PATCH v6 06/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in migration and thp tests Gavin Shan
2021-08-09 9:26 ` [PATCH v6 07/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in PTE modifying tests Gavin Shan
2021-08-09 9:26 ` [PATCH v6 08/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in PMD " Gavin Shan
2021-08-09 9:26 ` [PATCH v6 09/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in PUD " Gavin Shan
2021-08-09 9:26 ` [PATCH v6 10/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in PGD and P4D " Gavin Shan
2021-08-09 9:26 ` [PATCH v6 11/12] mm/debug_vm_pgtable: Remove unused code Gavin Shan
2021-08-09 9:26 ` [PATCH v6 12/12] mm/debug_vm_pgtable: Fix corrupted page flag Gavin Shan
2021-08-09 10:08 ` [PATCH v6 00/12] mm/debug_vm_pgtable: Enhancements Christophe Leroy
2021-08-10 16:05 ` Gerald Schaefer [this message]
2021-08-12 11:11 ` Anshuman Khandual
2021-08-13 9:25 ` Gavin Shan
2021-08-13 19:43 ` Vineet Gupta
2021-08-14 2:57 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210810180535.08ecc800@thinkpad \
--to=gerald.schaefer@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=anshuman.khandual@arm.com \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=chuhu@redhat.com \
--cc=gshan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shan.gavin@gmail.com \
--cc=vgupta@synopsys.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox