linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: kbuild-all@lists.01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org,
	Jacopo Mondi <jacopo+renesas@jmondi.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: [linux-next:master 5146/6223] drivers/media/platform/rcar-vin/rcar-core.c:220:18: warning: Same value in both branches of ternary operator. [duplicateValueTernary]
Date: Tue, 10 Aug 2021 13:42:04 +0800	[thread overview]
Message-ID: <202108101353.VuDfxbHo-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   da454ebf578f6c542ba9f5b3ddb98db3ede109c1
commit: 0c56f9597adc870e6761822668868fe2930f08bd [5146/6223] media: rcar-vin: Add r8a779a0 support
compiler: riscv64-linux-gcc (GCC) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck warnings: (new ones prefixed by >>)
>> drivers/media/platform/rcar-vin/rcar-core.c:220:18: warning: Same value in both branches of ternary operator. [duplicateValueTernary]
    for (i = 0; i < RVIN_REMOTES_MAX; i++)
                    ^

vim +220 drivers/media/platform/rcar-vin/rcar-core.c

3bb4c3bc85bf77 Niklas Söderlund 2018-04-14  210  
87932605cce9cd Niklas Söderlund 2021-07-09  211  /* group lock should be held when calling this function. */
87932605cce9cd Niklas Söderlund 2021-07-09  212  static int rvin_group_entity_to_remote_id(struct rvin_group *group,
87932605cce9cd Niklas Söderlund 2021-07-09  213  					  struct media_entity *entity)
87932605cce9cd Niklas Söderlund 2021-07-09  214  {
87932605cce9cd Niklas Söderlund 2021-07-09  215  	struct v4l2_subdev *sd;
87932605cce9cd Niklas Söderlund 2021-07-09  216  	unsigned int i;
87932605cce9cd Niklas Söderlund 2021-07-09  217  
87932605cce9cd Niklas Söderlund 2021-07-09  218  	sd = media_entity_to_v4l2_subdev(entity);
87932605cce9cd Niklas Söderlund 2021-07-09  219  
87932605cce9cd Niklas Söderlund 2021-07-09 @220  	for (i = 0; i < RVIN_REMOTES_MAX; i++)
87932605cce9cd Niklas Söderlund 2021-07-09  221  		if (group->remotes[i].subdev == sd)
87932605cce9cd Niklas Söderlund 2021-07-09  222  			return i;
87932605cce9cd Niklas Söderlund 2021-07-09  223  
87932605cce9cd Niklas Söderlund 2021-07-09  224  	return -ENODEV;
87932605cce9cd Niklas Söderlund 2021-07-09  225  }
87932605cce9cd Niklas Söderlund 2021-07-09  226  

:::::: The code at line 220 was first introduced by commit
:::::: 87932605cce9cd2a7c986abcbf73666855a2ebc7 media: rcar-vin: Move and rename CSI-2 link notifications

:::::: TO: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org


             reply	other threads:[~2021-08-10  5:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10  5:42 kernel test robot [this message]
2021-08-10  8:15 ` Niklas Söderlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108101353.VuDfxbHo-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=jacopo+renesas@jmondi.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mchehab@kernel.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox