From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5956FC432BE for ; Tue, 10 Aug 2021 14:43:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DD6AA60F25 for ; Tue, 10 Aug 2021 14:43:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DD6AA60F25 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 33FF68D000C; Tue, 10 Aug 2021 10:43:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F1058D0001; Tue, 10 Aug 2021 10:43:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E0558D000C; Tue, 10 Aug 2021 10:43:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id F34C48D0001 for ; Tue, 10 Aug 2021 10:43:10 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9AB9A8249980 for ; Tue, 10 Aug 2021 14:43:10 +0000 (UTC) X-FDA: 78459438540.05.15EF6A6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf27.hostedemail.com (Postfix) with ESMTP id 4C8327001F5A for ; Tue, 10 Aug 2021 14:43:10 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id C80D860F02; Tue, 10 Aug 2021 14:43:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628606589; bh=ozD8cwZNKn3odTH+KqEJhMRr1mfhtpueWtbLeeuQTmE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mLjCOt7dgwO3Zw6T1I+BApb8RKELVC4ldw0jU3X52uRYEIQL2zkrQg440QC/WFMDe nW5UTk4L3ZqdynsL7GZZ3lsdQQSnV8AKzUtAQPlY4QcqwT0GvPLa78U93zPZZ6S+M7 rwANNXfmInPEaG2qoYobRKdfc941y5vYjHTfHPwOumy5R7NTQE7U0t6xpDokyF9Fhc X7tqZRWmk6YlYmXf0p7zvhAPaBaUCCuqw2Ab7Wz7ciP8Ouw7d6QpS2e0jR5MybIRo8 53ezwlvnSoOKt2C7QIr3LndUAFzQUceqfk36RdN/37xp9bZZzPmS/EuRkZW7JE1Phu 6REpU9Y8oDpHQ== Date: Tue, 10 Aug 2021 07:43:06 -0700 From: Jakub Kicinski To: Jesper Dangaard Brouer Cc: Yunsheng Lin , brouer@redhat.com, davem@davemloft.net, alexander.duyck@gmail.com, linux@armlinux.org.uk, mw@semihalf.com, linuxarm@openeuler.org, yisen.zhuang@huawei.com, salil.mehta@huawei.com, thomas.petazzoni@bootlin.com, hawk@kernel.org, ilias.apalodimas@linaro.org, ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, akpm@linux-foundation.org, peterz@infradead.org, will@kernel.org, willy@infradead.org, vbabka@suse.cz, fenghua.yu@intel.com, guro@fb.com, peterx@redhat.com, feng.tang@intel.com, jgg@ziepe.ca, mcroce@microsoft.com, hughd@google.com, jonathan.lemon@gmail.com, alobakin@pm.me, willemb@google.com, wenxu@ucloud.cn, cong.wang@bytedance.com, haokexin@gmail.com, nogikh@google.com, elver@google.com, yhs@fb.com, kpsingh@kernel.org, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, chenhao288@hisilicon.com, Linux-MM Subject: Re: [PATCH net-next v2 0/4] add frag page support in page pool Message-ID: <20210810074306.6cbd1a73@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1eb903a5-a954-e405-6088-9b9209703f5e@redhat.com> References: <1628217982-53533-1-git-send-email-linyunsheng@huawei.com> <20210810070159.367e680e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <1eb903a5-a954-e405-6088-9b9209703f5e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4C8327001F5A Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mLjCOt7d; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of kuba@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=kuba@kernel.org X-Stat-Signature: 9gj1gsi1hy991ngspzdgq9ogwr94hq8t X-HE-Tag: 1628606590-871482 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 10 Aug 2021 16:23:52 +0200 Jesper Dangaard Brouer wrote: > On 10/08/2021 16.01, Jakub Kicinski wrote: > > On Fri, 6 Aug 2021 10:46:18 +0800 Yunsheng Lin wrote: > >> enable skb's page frag recycling based on page pool in > >> hns3 drvier. > > > > Applied, thanks! > > I had hoped to see more acks / reviewed-by before this got applied. > E.g. from MM-people as this patchset changes struct page and page_pool > (that I'm marked as maintainer of). Sorry, it was on the list for days and there were 7 or so prior versions, I thought it was ripe. If possible, a note that review will come would be useful. > And I would have appreciated an reviewed-by credit to/from Alexander > as he did a lot of work in the RFC patchset for the split-page tricks. I asked him off-list, he said something I interpreted as "code is okay, but the review tag is not coming".