From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28796C4338F for ; Tue, 10 Aug 2021 01:51:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B153261040 for ; Tue, 10 Aug 2021 01:51:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B153261040 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C95666B0071; Mon, 9 Aug 2021 21:51:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C45FC8D0001; Mon, 9 Aug 2021 21:51:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B32FE6B0073; Mon, 9 Aug 2021 21:51:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0115.hostedemail.com [216.40.44.115]) by kanga.kvack.org (Postfix) with ESMTP id 96DD96B0071 for ; Mon, 9 Aug 2021 21:51:16 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2EDD5181EBF21 for ; Tue, 10 Aug 2021 01:51:16 +0000 (UTC) X-FDA: 78457493352.01.C4E3DC0 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf06.hostedemail.com (Postfix) with ESMTP id DA973801B0FF for ; Tue, 10 Aug 2021 01:51:14 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10070"; a="201988682" X-IronPort-AV: E=Sophos;i="5.84,309,1620716400"; d="scan'208";a="201988682" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2021 18:51:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,309,1620716400"; d="scan'208";a="444771470" Received: from lkp-server01.sh.intel.com (HELO d053b881505b) ([10.239.97.150]) by fmsmga007.fm.intel.com with ESMTP; 09 Aug 2021 18:51:10 -0700 Received: from kbuild by d053b881505b with local (Exim 4.92) (envelope-from ) id 1mDGv7-000K5p-IY; Tue, 10 Aug 2021 01:51:09 +0000 Date: Tue, 10 Aug 2021 09:50:26 +0800 From: kernel test robot To: Quinn Tran Cc: kbuild-all@lists.01.org, Linux Memory Management List , "Martin K. Petersen" , Hannes Reinecke , Himanshu Madhani , Larry Wisneski , Duane Grigsby , Rick Hicksted Jr , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, "James E.J. Bottomley" Subject: [PATCH] scsi: qla2xxx: edif: fix returnvar.cocci warnings Message-ID: <20210810015026.GA36100@85d76ceac87d> References: <202108100950.5Fau738z-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202108100950.5Fau738z-lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DA973801B0FF Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none); spf=none (imf06.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=lkp@intel.com X-Stat-Signature: qa897zc61z55u1a6ucjg5unrps9mb7xc X-HE-Tag: 1628560274-737046 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: kernel test robot drivers/scsi/qla2xxx/qla_edif.c:213:25-29: Unneeded variable: "rval". Return "0" on line 264 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: 7ebb336e45ef ("scsi: qla2xxx: edif: Add start + stop bsgs") CC: Quinn Tran Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: da454ebf578f6c542ba9f5b3ddb98db3ede109c1 commit: 7ebb336e45ef1ce23462c3bbd03779929008901f [2910/6223] scsi: qla2xxx: edif: Add start + stop bsgs :::::: branch date: 14 hours ago :::::: commit date: 2 weeks ago qla_edif.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/scsi/qla2xxx/qla_edif.c +++ b/drivers/scsi/qla2xxx/qla_edif.c @@ -210,7 +210,6 @@ qla_edif_app_start(scsi_qla_host_t *vha, static int qla_edif_app_stop(scsi_qla_host_t *vha, struct bsg_job *bsg_job) { - int32_t rval = 0; struct app_stop appstop; struct fc_bsg_reply *bsg_reply = bsg_job->reply; struct fc_port *fcport, *tf; @@ -261,7 +260,7 @@ qla_edif_app_stop(scsi_qla_host_t *vha, /* no return interface to app - it assumes we cleaned up ok */ - return rval; + return 0; } int32_t