From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18B1BC4320A for ; Mon, 9 Aug 2021 15:18:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B2D9261040 for ; Mon, 9 Aug 2021 15:18:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B2D9261040 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1F1A36B0071; Mon, 9 Aug 2021 11:18:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17CB48D0002; Mon, 9 Aug 2021 11:18:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01C7D8D0001; Mon, 9 Aug 2021 11:18:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id DAEFE6B0071 for ; Mon, 9 Aug 2021 11:18:22 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8F06F202F8 for ; Mon, 9 Aug 2021 15:18:22 +0000 (UTC) X-FDA: 78455898444.24.168CD1D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf23.hostedemail.com (Postfix) with ESMTP id 0B75C9000394 for ; Mon, 9 Aug 2021 15:18:21 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 059912000C; Mon, 9 Aug 2021 15:18:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1628522301; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+7LQfr+QS70hPlEzdXU5UNfASl0hm6MYjCpn/TJE3Bc=; b=R4vTQk1xooDBp9mWzIXzqhwLD4CIHqYAxE00uuxm9oLbJhzDcwNh6qmud4FPuBHxoWpTKs /uupXehqAF9P9KZgz9j+mFeb0T4LfBlR3IfbjX03lQLinlhL1epZQVP3/ha2pv01dqhbhx Q4tSeteWdiPwWSpi+KBAapfqQhD7tok= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1628522301; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+7LQfr+QS70hPlEzdXU5UNfASl0hm6MYjCpn/TJE3Bc=; b=dm/cqvOl95qsMUroycYmEaR6xavGIMxMc49ZUMkfh0XYG2GNLNuYmbuk7HNcvA2Psn69/P q05ZLbbK32ovACDg== Received: from quack2.suse.cz (unknown [10.100.224.230]) by relay2.suse.de (Postfix) with ESMTP id EAE89A3B81; Mon, 9 Aug 2021 15:18:20 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id D3AB21E3BFC; Mon, 9 Aug 2021 17:18:20 +0200 (CEST) Date: Mon, 9 Aug 2021 17:18:20 +0200 From: Jan Kara To: Christoph Hellwig Cc: Jens Axboe , Tejun Heo , Jan Kara , linux-block@vger.kernel.org, Andrew Morton , cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/5] block: add a queue_has_disk helper Message-ID: <20210809151820.GG30319@quack2.suse.cz> References: <20210809141744.1203023-1-hch@lst.de> <20210809141744.1203023-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210809141744.1203023-4-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0B75C9000394 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=R4vTQk1x; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="dm/cqvOl"; dmarc=none; spf=pass (imf23.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz X-Stat-Signature: ukqfwhgi5wrx71xwq88c69xe6azsr9b5 X-HE-Tag: 1628522301-955603 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 09-08-21 16:17:42, Christoph Hellwig wrote: > Add a helper to check if a gendisk is associated with a request_queue. > > Signed-off-by: Christoph Hellwig Looks fine. Feel free to add: Reviewed-by: Jan Kara Honza > --- > include/linux/blkdev.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index ac3642c88a4d..96f3d9617cd8 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -664,6 +664,7 @@ extern void blk_clear_pm_only(struct request_queue *q); > dma_map_page_attrs(dev, (bv)->bv_page, (bv)->bv_offset, (bv)->bv_len, \ > (dir), (attrs)) > > +#define queue_has_disk(q) ((q)->kobj.parent != NULL) > #define queue_to_disk(q) (dev_to_disk(kobj_to_dev((q)->kobj.parent))) > > static inline bool queue_is_mq(struct request_queue *q) > -- > 2.30.2 > -- Jan Kara SUSE Labs, CR