From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2200CC4320A for ; Mon, 9 Aug 2021 18:24:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BDCED6101E for ; Mon, 9 Aug 2021 18:24:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BDCED6101E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EB2108D0002; Mon, 9 Aug 2021 14:24:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E62A36B0073; Mon, 9 Aug 2021 14:24:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D51038D0002; Mon, 9 Aug 2021 14:24:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id B6C906B0072 for ; Mon, 9 Aug 2021 14:24:50 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 650148249980 for ; Mon, 9 Aug 2021 18:24:50 +0000 (UTC) X-FDA: 78456368340.11.AFC4C89 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf12.hostedemail.com (Postfix) with ESMTP id 19CC510003F6 for ; Mon, 9 Aug 2021 18:24:49 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 16BF961004; Mon, 9 Aug 2021 18:24:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1628533489; bh=tDOfWjGdsyuIyylW8J8O8/FCq1h6g+rfI7buXbmQ0Jg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sFLArbVGTyA8p27aYlQGpKtrlV0EUYQTK5d9eFT2P/e8nkcpdB4iWP2zB04li1DAr xYZTpkl2DKt61PYuQuJxZwfvs64rJiMh7mKyC40xfec+ZUPvYbUY4Edzr2MDXwH0X/ YI1L6iPzZ73xXNo/r0HLNl0Cc8K77GWOF4zDdYcE= Date: Mon, 9 Aug 2021 11:24:48 -0700 From: Andrew Morton To: Vasily Averin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel@openvz.org Subject: Re: [PATCH] mm: use in_task() in __gfp_pfmemalloc_flags() Message-Id: <20210809112448.3d7d8f2522e18e75ba6e31c0@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=sFLArbVG; dmarc=none; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: 7cauheaeo7sjaxst16rmffny9yubr5fb X-Rspamd-Queue-Id: 19CC510003F6 X-Rspamd-Server: rspam01 X-HE-Tag: 1628533489-128838 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 9 Aug 2021 11:23:29 +0300 Vasily Averin wrote: > obsoleted in_interrupt() include task context with disabled BH, > it's better to use in_task() instead. Are these just blind conversions, or have you verified in each case that it is correct to newly take these code paths inside local_bh_disable()? If "yes" then please provide the reasoning in each changelog?