From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E763EC4338F for ; Fri, 6 Aug 2021 09:22:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 71A2C61154 for ; Fri, 6 Aug 2021 09:22:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 71A2C61154 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A8BA56B006C; Fri, 6 Aug 2021 05:22:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3BD36B0071; Fri, 6 Aug 2021 05:22:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 903C58D0001; Fri, 6 Aug 2021 05:22:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id 731E96B006C for ; Fri, 6 Aug 2021 05:22:56 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1CC7E181AF5E1 for ; Fri, 6 Aug 2021 09:22:56 +0000 (UTC) X-FDA: 78444116352.01.DDACD83 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by imf16.hostedemail.com (Postfix) with ESMTP id CB5B6F00376F for ; Fri, 6 Aug 2021 09:22:55 +0000 (UTC) Received: by mail-qk1-f175.google.com with SMTP id t3so7915994qkg.11 for ; Fri, 06 Aug 2021 02:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version:in-reply-to :content-transfer-encoding; bh=CMsmmLe070UmWwr4znuaFaK+prUVayJ14rPFcIrKVzs=; b=NGkl4Dl/yMygd8Y2VWGA2keG/LEtrEGfTiP/5VZ9bFG2f7ETuV3fS1hVEJyUUxzxsy /dQgjVennMhknl4yNtbIa4kBL4SWuxiqac2KA71a6KQDbTBu85cCZ1UdLt8/kwK5MlmU 76N9Js/SAt6sAa7g4LCBttRWSvBRRT2X9AM+2C2VPxCZeirDVqaNvwWIulMD97z1mOdo qsFeOhaw8ExrvKdnTR8ucXoCDefrhHjx3ZVAUEVwN6lOkMQ1w/L8zuTwVWBU8qbiA+RB LEoPmov53nQudg5+l0rMr6CeJuQiDPi9oX5KxMqBJPLqUkCOvNsmIUfTt/elpEIFTG+a t6Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :in-reply-to:content-transfer-encoding; bh=CMsmmLe070UmWwr4znuaFaK+prUVayJ14rPFcIrKVzs=; b=kuCSEDNCCx4GPvsVYIduCGzaOvvuZxDu7vJ7022CTha4IDrI8rhZdHHfpp8SfOWk0N uME6NhtGTsx27LF7UJx7R1DcuQZqUu224eTEs2WauSC9vT+m9y+cqMPnh5yVK6eoZKZa zQXK7SBMyJT7zQXr3fjDs0vNxCPYKSe7a/EpbLwEJ2BLfUCKlVvgGdb4VhWaxA/m/mdA vBfOZcfoBM0TWTtczNAJBVT4VaUTcebkb7exTq0arbIDVSbo2D123xM9xmBp0RfSDBR1 bC+YYg5dY6M0pIymUAjqFyUz2x3fx0o2arUFkmfKyTUc9wwHhucenXV+04NgKjew66j+ Y1fA== X-Gm-Message-State: AOAM532q/RPL2oq4Mxn/JJuJpleXtiN9hFz6br1OAPizk8Edx/eVy15X Upvk+m6c1BmsndLPo/QRTjw= X-Google-Smtp-Source: ABdhPJyrme3xLBPC4a8NUEb8cvLc9wRMeNJl6RI/6UaUHnI853QRF1eczjBxoNx6PBui3Pr6t4I0ww== X-Received: by 2002:ae9:f005:: with SMTP id l5mr1738905qkg.355.1628241775125; Fri, 06 Aug 2021 02:22:55 -0700 (PDT) Received: from localhost.localdomain (ec2-35-169-212-159.compute-1.amazonaws.com. [35.169.212.159]) by smtp.gmail.com with ESMTPSA id r202sm2106039qke.45.2021.08.06.02.22.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Aug 2021 02:22:54 -0700 (PDT) From: SeongJae Park X-Google-Original-From: SeongJae Park To: Randy Dunlap Cc: akpm@linux-foundation.org, broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au, Matthew Wilcox , SeongJae Park Subject: Re: mmotm 2021-08-05-19-46 uploaded (mm/filemap.c) Date: Fri, 6 Aug 2021 09:22:46 +0000 Message-Id: <20210806092246.30301-1-sjpark@amazon.de> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 In-Reply-To: <43bf8d13-505c-35b3-c865-a62bdcbafcf8@infradead.org> Content-Type: text/plain; charset=UTF-8 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b="NGkl4Dl/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of sj38park@gmail.com designates 209.85.222.175 as permitted sender) smtp.mailfrom=sj38park@gmail.com X-Stat-Signature: cwmk9mbwypyre1cyzeg934o85w9u8jzt X-Rspamd-Queue-Id: CB5B6F00376F X-Rspamd-Server: rspam01 X-HE-Tag: 1628241775-465623 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: SeongJae Park Hello Randy, On Thu, 5 Aug 2021 22:00:11 -0700 Randy Dunlap wr= ote: [...] >=20 > on i386, I am seeing lots of build errors due to references to > some PAGE_ flags that are only defined for 64BIT: >=20 > In file included from ../mm/filemap.c:44:0: > ../include/linux/page_idle.h: In function =E2=80=98folio_test_young=E2=80= =99: > ../include/linux/page_idle.h:25:18: error: =E2=80=98PAGE_EXT_YOUNG=E2=80= =99 undeclared (first use in this function); did you mean =E2=80=98PAGEOU= TRUN=E2=80=99? > return test_bit(PAGE_EXT_YOUNG, &page_ext->flags); > ^~~~~~~~~~~~~~ > PAGEOUTRUN [...] >=20 > See: > --- a/include/linux/page_ext.h~mm-idle_page_tracking-make-pg_idle-reusa= ble > +++ a/include/linux/page_ext.h > @@ -19,7 +19,7 @@ struct page_ext_operations { > enum page_ext_flags { > PAGE_EXT_OWNER, > PAGE_EXT_OWNER_ALLOCATED, > -#if defined(CONFIG_IDLE_PAGE_TRACKING) && !defined(CONFIG_64BIT) > +#if defined(CONFIG_PAGE_IDLE_FLAG) && !defined(CONFIG_64BIT) > PAGE_EXT_YOUNG, > PAGE_EXT_IDLE, > #endif Thanks for this report! However, the flag is not defined for only-64BIT = but none-64BIT. 'enum page_ext_flags' is defined when 'CONFIG_PAGE_EXTENSION' is set. It= is automatically set for non-64BIT when 'CONFIG_IDLE_PAGE_TRACKING' or 'CONFIG_DAMON_VADDR' is set. However, 'CONFIG_PAGE_IDLE_FLAG' doesn't. = So, if 'CONFIG_PAGE_IDLE_FLAG' is set but 'CONFIG_PAGE_EXTENSION' is not, this i= ssue can be reproduced. I was able to reproduce this issue with: make ARCH=3Di386 allnoconfig echo 'CONFIG_PAGE_IDLE_FLAG=3Dy' >> .config make olddefconfig make ARCH=3Di386 And, confirmed below change fixes it. --- a/mm/Kconfig +++ b/mm/Kconfig @@ -741,6 +741,7 @@ config DEFERRED_STRUCT_PAGE_INIT =20 config PAGE_IDLE_FLAG bool "Add PG_idle and PG_young flags" + select PAGE_EXTENSION if !64BIT help This feature adds PG_idle and PG_young flags in 'struct page'. PTE Accessed bit writers can set the state of the bit in the flags to let Also, below change would make more sense: @@ -749,7 +750,6 @@ config PAGE_IDLE_FLAG config IDLE_PAGE_TRACKING bool "Enable idle page tracking" depends on SYSFS && MMU && BROKEN - select PAGE_EXTENSION if !64BIT select PAGE_IDLE_FLAG help This feature allows to estimate the amount of user pages that have diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig index 455995152697..37024798a97c 100644 --- a/mm/damon/Kconfig +++ b/mm/damon/Kconfig @@ -27,7 +27,6 @@ config DAMON_KUNIT_TEST config DAMON_VADDR bool "Data access monitoring primitives for virtual address spaces" depends on DAMON && MMU - select PAGE_EXTENSION if !64BIT select PAGE_IDLE_FLAG help This builds the default data access monitoring primitives for DAMON I will format these as patches and post soon. Thanks, SeongJae Park >=20 >=20 > --=20 > ~Randy > Reported-by: Randy Dunlap