From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F541C432BE for ; Thu, 5 Aug 2021 19:55:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0AA4860720 for ; Thu, 5 Aug 2021 19:55:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0AA4860720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 7FCF96B0071; Thu, 5 Aug 2021 15:55:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 785DA6B0072; Thu, 5 Aug 2021 15:55:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 627788D0001; Thu, 5 Aug 2021 15:55:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 47B7F6B0071 for ; Thu, 5 Aug 2021 15:55:18 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id F2E8E1829B8E2 for ; Thu, 5 Aug 2021 19:55:17 +0000 (UTC) X-FDA: 78442081074.39.2030E81 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf18.hostedemail.com (Postfix) with ESMTP id 78DB74001894 for ; Thu, 5 Aug 2021 19:55:17 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 57322603E7; Thu, 5 Aug 2021 19:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628193316; bh=CklEGTLSjtGz5W3FSSFDdfwi4ff4VBJKQOOpB1LNgs4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=hK6wUqtRxY7yibprEdBkECYoBCIZlEuo9VGuimrJKkFzhiclll648HdD1Zy7SJYcN 2i5r/hTsGs7nvQiddUyX1hCUlhEJk/0/S2bzA8oA+ROkc+QFBqN61LP+oWXwMfWbxF Tzp9gl3PSSA6Nwf2tusnBkY5WRGQPPa+s/y4ZtA4ObaidNSVjTsUHtIPY9TLCQPG0E F6zw4OCi0zh4FZ6zy0807XD/zND8R0URGJX77eUM4B8BDPnTxlfiz+ngfr+1r92TN5 9UszIGTuWgfWDt+hY8WshMyOIn8k1FEwCTbomfVObblyHHhgaMnck/HpY2EMQZ8994 H29YWM+L+Gmsw== Date: Thu, 5 Aug 2021 14:55:15 -0500 From: Bjorn Helgaas To: Dan Carpenter Cc: kbuild@lists.01.org, Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:master 4244/5318] drivers/pci/syscall.c:82 __do_sys_pciconfig_read() error: uninitialized symbol 'dev'. Message-ID: <20210805195515.GA1743394@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <202108051314.rzRzb79i-lkp@intel.com> Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hK6wUqtR; spf=pass (imf18.hostedemail.com: domain of helgaas@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=helgaas@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 78DB74001894 X-Stat-Signature: efsjoguxjawsmzt4w83j7gft6kgnuwyy X-HE-Tag: 1628193317-881775 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 05, 2021 at 02:54:10PM +0300, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= .git master > head: 2f73937c9aa561e2082839bc1a8efaac75d6e244 > commit: 61a6199787d97660d99aa3399c9165c0cf752211 [4244/5318] PCI: Retur= n ~0 data on pciconfig_read() CAP_SYS_ADMIN failure > config: ia64-randconfig-m031-20210804 (attached as .config) > compiler: ia64-linux-gcc (GCC) 10.3.0 >=20 > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter >=20 > smatch warnings: > drivers/pci/syscall.c:82 __do_sys_pciconfig_read() error: uninitialized= symbol 'dev'. > drivers/pci/syscall.c:82 __do_sys_pciconfig_read() error: uninitialized= symbol 'dev'. Thanks, fixed by https://lore.kernel.org/r/20210803200836.500658-1-nathan@kernel.org, I think. > vim +/dev +82 drivers/pci/syscall.c >=20 > c4ea37c26a691a Heiko Carstens 2009-01-14 15 SYSCALL_DEFINE5(pci= config_read, unsigned long, bus, unsigned long, dfn, > c4ea37c26a691a Heiko Carstens 2009-01-14 16 unsigned long, of= f, unsigned long, len, void __user *, buf) > ^1da177e4c3f41 Linus Torvalds 2005-04-16 17 { > ^1da177e4c3f41 Linus Torvalds 2005-04-16 18 struct pci_dev *de= v; > ^^^^^^^^^^^^^^^= ^^^^^ >=20 > ^1da177e4c3f41 Linus Torvalds 2005-04-16 19 u8 byte; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 20 u16 word; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 21 u32 dword; > e4585da22ad04a Alan Cox 2007-04-23 22 long err; > ef9e4005cbaf02 Heiner Kallweit 2021-01-24 23 int cfg_ret; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 24 =20 > 61a6199787d976 Krzysztof Wilczy=C5=84ski 2021-07-29 25 err =3D -EPER= M; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 26 if (!capable(CAP_S= YS_ADMIN)) > 61a6199787d976 Krzysztof Wilczy=C5=84ski 2021-07-29 27 goto error; > ^^^^^^^= ^^^ >=20 > ^1da177e4c3f41 Linus Torvalds 2005-04-16 28 =20 > ^1da177e4c3f41 Linus Torvalds 2005-04-16 29 err =3D -ENODEV; > 39c9465204e8f4 Sinan Kaya 2017-12-19 30 dev =3D pci_get_do= main_bus_and_slot(0, bus, dfn); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 31 if (!dev) > ^1da177e4c3f41 Linus Torvalds 2005-04-16 32 goto error; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 33 =20 > ^1da177e4c3f41 Linus Torvalds 2005-04-16 34 switch (len) { > ^1da177e4c3f41 Linus Torvalds 2005-04-16 35 case 1: > e04b0ea2e0f9c1 Brian King 2005-09-27 36 cfg_ret =3D pci_u= ser_read_config_byte(dev, off, &byte); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 37 break; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 38 case 2: > e04b0ea2e0f9c1 Brian King 2005-09-27 39 cfg_ret =3D pci_u= ser_read_config_word(dev, off, &word); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 40 break; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 41 case 4: > e04b0ea2e0f9c1 Brian King 2005-09-27 42 cfg_ret =3D pci_u= ser_read_config_dword(dev, off, &dword); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 43 break; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 44 default: > ^1da177e4c3f41 Linus Torvalds 2005-04-16 45 err =3D -EINVAL; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 46 goto error; > f7625980f5820e Bjorn Helgaas 2013-11-14 47 } > ^1da177e4c3f41 Linus Torvalds 2005-04-16 48 =20 > ^1da177e4c3f41 Linus Torvalds 2005-04-16 49 err =3D -EIO; > ef9e4005cbaf02 Heiner Kallweit 2021-01-24 50 if (cfg_ret) > ^1da177e4c3f41 Linus Torvalds 2005-04-16 51 goto error; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 52 =20 > ^1da177e4c3f41 Linus Torvalds 2005-04-16 53 switch (len) { > ^1da177e4c3f41 Linus Torvalds 2005-04-16 54 case 1: > ^1da177e4c3f41 Linus Torvalds 2005-04-16 55 err =3D put_user(= byte, (unsigned char __user *)buf); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 56 break; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 57 case 2: > ^1da177e4c3f41 Linus Torvalds 2005-04-16 58 err =3D put_user(= word, (unsigned short __user *)buf); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 59 break; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 60 case 4: > ^1da177e4c3f41 Linus Torvalds 2005-04-16 61 err =3D put_user(= dword, (unsigned int __user *)buf); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 62 break; > e4585da22ad04a Alan Cox 2007-04-23 63 } > e4585da22ad04a Alan Cox 2007-04-23 64 pci_dev_put(dev); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 65 return err; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 66 =20 > ^1da177e4c3f41 Linus Torvalds 2005-04-16 67 error: > ^1da177e4c3f41 Linus Torvalds 2005-04-16 68 /* ??? XFree86 doe= sn't even check the return value. They > ^1da177e4c3f41 Linus Torvalds 2005-04-16 69 just look for 0= xffffffff in the output, since that's what > ^1da177e4c3f41 Linus Torvalds 2005-04-16 70 they get instea= d of a machine check on x86. */ > ^1da177e4c3f41 Linus Torvalds 2005-04-16 71 switch (len) { > ^1da177e4c3f41 Linus Torvalds 2005-04-16 72 case 1: > ^1da177e4c3f41 Linus Torvalds 2005-04-16 73 put_user(-1, (uns= igned char __user *)buf); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 74 break; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 75 case 2: > ^1da177e4c3f41 Linus Torvalds 2005-04-16 76 put_user(-1, (uns= igned short __user *)buf); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 77 break; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 78 case 4: > ^1da177e4c3f41 Linus Torvalds 2005-04-16 79 put_user(-1, (uns= igned int __user *)buf); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 80 break; > e4585da22ad04a Alan Cox 2007-04-23 81 } > e4585da22ad04a Alan Cox 2007-04-23 @82 pci_dev_put(dev); > ^^^ > Uninitialized. >=20 > ^1da177e4c3f41 Linus Torvalds 2005-04-16 83 return err; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 84 } >=20 > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >=20