From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57373C432BE for ; Fri, 6 Aug 2021 00:43:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E64B161186 for ; Fri, 6 Aug 2021 00:43:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E64B161186 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 2E8F76B006C; Thu, 5 Aug 2021 20:43:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 299768D0002; Thu, 5 Aug 2021 20:43:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 188F76B0072; Thu, 5 Aug 2021 20:43:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id F20256B006C for ; Thu, 5 Aug 2021 20:43:18 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B26D2180AE7E1 for ; Fri, 6 Aug 2021 00:43:18 +0000 (UTC) X-FDA: 78442806876.13.24C95A8 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf13.hostedemail.com (Postfix) with ESMTP id 5C48D101C9C1 for ; Fri, 6 Aug 2021 00:43:18 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A2BF361181; Fri, 6 Aug 2021 00:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1628210597; bh=a8GIAZH/SrBiqNH9BfQy1X36iX6vj+iZLd00Z0SVfgE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DhlFY1lMKQ3RbhQZoE/nkYwgdmKHCGaYfF/iaIVuM08g3mg8UWNhPDXSkCebZ2yCd tUEb8JFKycvqjRoVeODVekA7k9Zif/vtubqAx8UjQI465+GAkytdf2cnutDjtUK2Qb FkoPdcROQhXi9A1B9oz9268OgyffP9K6SstrtnxU= Date: Thu, 5 Aug 2021 17:43:16 -0700 From: Andrew Morton To: SeongJae Park Cc: SeongJae Park , Jonathan.Cameron@Huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, brendanhiggins@google.com, corbet@lwn.net, david@redhat.com, dwmw@amazon.com, elver@google.com, fan.du@intel.com, foersleo@amazon.de, greg@kroah.com, gthelen@google.com, guoju.fgj@alibaba-inc.com, jgowans@amazon.com, joe@perches.com, mgorman@suse.de, mheyne@amazon.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, riel@surriel.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, shakeelb@google.com, shuah@kernel.org, sieberf@amazon.com, snu@zelle79.org, vbabka@suse.cz, vdavydov.dev@gmail.com, zgf574564920@gmail.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v34 07/13] mm/damon: Implement a debugfs-based user space interface Message-Id: <20210805174316.ff4b6eee629f9f05259058d9@linux-foundation.org> In-Reply-To: <20210716081449.22187-8-sj38.park@gmail.com> References: <20210716081449.22187-1-sj38.park@gmail.com> <20210716081449.22187-8-sj38.park@gmail.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5C48D101C9C1 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=DhlFY1lM; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: br3q7g797b1ngmnets9uszzrrfqhnjz9 X-HE-Tag: 1628210598-164089 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 16 Jul 2021 08:14:43 +0000 SeongJae Park wrote: > +#define targetid_is_pid(ctx) \ > + (ctx->primitive.target_valid == damon_va_target_valid) > + I think this can be implemented as a static inline C function? --- a/mm/damon/dbgfs.c~mm-damon-implement-a-debugfs-based-user-space-interface-fix-fix +++ a/mm/damon/dbgfs.c @@ -97,8 +97,10 @@ out: return ret; } -#define targetid_is_pid(ctx) \ - (ctx->primitive.target_valid == damon_va_target_valid) +static inline bool targetid_is_pid(const struct damon_ctx *ctx) +{ + return ctx->primitive.target_valid == damon_va_target_valid; +} static ssize_t sprint_target_ids(struct damon_ctx *ctx, char *buf, ssize_t len) { We prefer this because it looks better, provides typechecking and can in some situations suppress unused variable warnings.