From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F8BC4338F for ; Thu, 5 Aug 2021 11:45:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F25146112E for ; Thu, 5 Aug 2021 11:45:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F25146112E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 431768D0001; Thu, 5 Aug 2021 07:45:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E1D96B0071; Thu, 5 Aug 2021 07:45:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25AC38D0001; Thu, 5 Aug 2021 07:45:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id 0CB5F6B006C for ; Thu, 5 Aug 2021 07:45:19 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id AACC0181C34DE for ; Thu, 5 Aug 2021 11:45:18 +0000 (UTC) X-FDA: 78440846316.17.1E91E12 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [85.220.165.71]) by imf22.hostedemail.com (Postfix) with ESMTP id E297419A6 for ; Thu, 5 Aug 2021 11:45:17 +0000 (UTC) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBboI-00027g-Fs; Thu, 05 Aug 2021 13:45:14 +0200 Received: from pengutronix.de (unknown [IPv6:2a02:810a:8940:aa0:68e7:ca3:e3f1:364e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 924F2661360; Thu, 5 Aug 2021 11:45:11 +0000 (UTC) Date: Thu, 5 Aug 2021 13:45:09 +0200 From: Marc Kleine-Budde To: Dan Carpenter Cc: kbuild@lists.01.org, Angelo Dureghello , lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:master 2764/5318] drivers/net/can/flexcan.c:666 flexcan_clks_enable() error: uninitialized symbol 'err'. Message-ID: <20210805114509.rjcptwrjscm257cd@pengutronix.de> References: <202108050850.IaTFXHsB-lkp@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wgyx5enqg7gdfhza" Content-Disposition: inline In-Reply-To: <202108050850.IaTFXHsB-lkp@intel.com> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mm@kvack.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E297419A6 Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of mkl@pengutronix.de designates 85.220.165.71 as permitted sender) smtp.mailfrom=mkl@pengutronix.de; dmarc=none X-Stat-Signature: 8ai78xq3i9kofe5yrx19rtkrspapous6 X-HE-Tag: 1628163917-24107 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --wgyx5enqg7gdfhza Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 05.08.2021 14:22:24, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it master > head: 2f73937c9aa561e2082839bc1a8efaac75d6e244 > commit: d9cead75b1c66b4660b4f87ff339234042d7c6a5 [2764/5318] can: flexcan= : add mcf5441x support > config: h8300-randconfig-m031-20210804 (attached as .config) > compiler: h8300-linux-gcc (GCC) 10.3.0 >=20 > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter >=20 > smatch warnings: > drivers/net/can/flexcan.c:666 flexcan_clks_enable() error: uninitialized = symbol 'err'. >=20 > vim +/err +666 drivers/net/can/flexcan.c >=20 > ca10989632d882 Aisheng Dong 2018-11-30 650 static int flexc= an_clks_enable(const struct flexcan_priv *priv) > ca10989632d882 Aisheng Dong 2018-11-30 651 { > ca10989632d882 Aisheng Dong 2018-11-30 652 int err; > ca10989632d882 Aisheng Dong 2018-11-30 653 =20 > d9cead75b1c66b Angelo Dureghello 2021-07-02 654 if (priv->clk_i= pg) { > ca10989632d882 Aisheng Dong 2018-11-30 655 err =3D clk_pr= epare_enable(priv->clk_ipg); > ca10989632d882 Aisheng Dong 2018-11-30 656 if (err) > ca10989632d882 Aisheng Dong 2018-11-30 657 return err; > d9cead75b1c66b Angelo Dureghello 2021-07-02 658 } > ca10989632d882 Aisheng Dong 2018-11-30 659 =20 > d9cead75b1c66b Angelo Dureghello 2021-07-02 660 if (priv->clk_p= er) { > ca10989632d882 Aisheng Dong 2018-11-30 661 err =3D clk_pr= epare_enable(priv->clk_per); > ca10989632d882 Aisheng Dong 2018-11-30 662 if (err) > ca10989632d882 Aisheng Dong 2018-11-30 663 clk_disable_u= nprepare(priv->clk_ipg); > d9cead75b1c66b Angelo Dureghello 2021-07-02 664 } >=20 > Smatch is complaining that both priv->clk_ipg and priv->clk_per can be > false... Probably impossible in real life. Fixed in net-next with: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/= ?id=3D3362666972137724496984b4db2b06071aca4b69 Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --wgyx5enqg7gdfhza Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmELz0MACgkQqclaivrt 76mOvQf+J0GudeKmydLd9RZIl+QyPatfQOWaL6Mtn4vzWkiDRT21htRQYaiiwHrs wlzpviaepz5UkXeTFvF0b01EaveK6vcFkEsXXtek8WZEF1uNh/Eh14tbia++DkHN Jz0XMbbwnIen7YF96wuD3181Zi5a94pGj/vVLzUcmJSOJs6rnnYXxL8CYQhKhB+q c1Bf+7l6avUZLdCEKNTzMXAGHr61TWnGGQcmCqE/Vw2NfOuzY20N3F9WODcm1jjP N8wcAL1nkveh8+qgQBsc0fVwBwUqkuc4uheJEdfIBieZB0aHpJLjz9P7WrRKUvSF zgRaiRwvhQBpqZSaTPbysvaq4nx40A== =tsMf -----END PGP SIGNATURE----- --wgyx5enqg7gdfhza--