From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5118C4338F for ; Wed, 4 Aug 2021 15:21:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0FE7860C51 for ; Wed, 4 Aug 2021 15:21:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0FE7860C51 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 830B66B007D; Wed, 4 Aug 2021 11:21:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E1468D0006; Wed, 4 Aug 2021 11:21:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A8A66B0080; Wed, 4 Aug 2021 11:21:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id 4D0676B007D for ; Wed, 4 Aug 2021 11:21:52 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EE3C4824999B for ; Wed, 4 Aug 2021 15:21:51 +0000 (UTC) X-FDA: 78437763222.32.9DD6F81 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf19.hostedemail.com (Postfix) with ESMTP id 7BA36B00BCAA for ; Wed, 4 Aug 2021 15:21:51 +0000 (UTC) Received: by mail-qt1-f175.google.com with SMTP id d9so1586011qty.12 for ; Wed, 04 Aug 2021 08:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PVQ1V3ExogsGaCtov6jk1dJHF06/mvxhxmainNfgf8Y=; b=WhDDPEFlFUnZ/n4mkY5wKuDd9D4NlnpC53nPyhaUXTsS9ANdhKzdNVx5fakLYg2ld5 53GgyApWfpJWTWn512PJAEbrjzkH1y6DcLkbSv2qLBD9Qp6s79jweDq44mCbnJeSulGL WMiUkGI5b+AsRhjGG1rnpemgEjwWKyOWN33wp7OWMq/D0VuLpRLrLJlXxBVAUrmslAbI JCDt2vljmNoDdhI3HK6gynnaCSn8i1E1Ua/ZiIq4ia1LBLlm1Zz/bQwBCUxfKmy24Dgn qU15RgjA75W5WwHdDOF6zqkIj19IRt3f14tZD1T5Op7jFviKOqpCdNSW7BYRhvpDGETc jA3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PVQ1V3ExogsGaCtov6jk1dJHF06/mvxhxmainNfgf8Y=; b=jjmYUCf8NoY91TscUiAEh+ssCpnZHQQ8iJWJwrB1bppcZnzPyfiM37EaVEp+FwIeGE 2XDNMUfTJ0W8krEcFB1xXt8u+gvw+YZBmYnGjyJ2ibAWXS2PT+BmXhq8SkebGCUiI3ZQ WOp2fyIvT7IU0xUJUM85XzmmsVQS73JrIeGCmnZ1mTV+H1nCCtsIkwVqJMpjoj9hHuHK U3+m8GTcLgGdfXcKDs7yTq9TqSNs5HYd6CK/qBhUmM+RmknmnFILLIcCwbqsBWSIavM6 C6A6RcXoSh+JZWm907LLnqLtu49DwnpGOyKm9DIq7Tz/e1KX8+YA5wa5age0n1Bttxaf 6jfw== X-Gm-Message-State: AOAM531PStZQey+BoPLcoaigmOrdKLzI5a2V0XHn2J0+iuaSadZlR0tK EiWQ853npHLAPbY0my/kB4FCmA== X-Google-Smtp-Source: ABdhPJzIvP8prj+GuCuMKLyFZYhXKJCHI+G2lNJeGYxKjjOccHbhkJhB2OzLb/YU60cvxkm3wxDViw== X-Received: by 2002:ac8:5b95:: with SMTP id a21mr104029qta.275.1628090510844; Wed, 04 Aug 2021 08:21:50 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id c16sm988323qtv.32.2021.08.04.08.21.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Aug 2021 08:21:50 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1mBIiK-00CeGf-Ja; Wed, 04 Aug 2021 12:21:48 -0300 Date: Wed, 4 Aug 2021 12:21:48 -0300 From: Jason Gunthorpe To: Jann Horn Cc: Liam Howlett , Luigi Rizzo , linux-kernel , Andrew Morton , David Rientjes , "linux-mm@kvack.org" Subject: Re: [PATCH] Add mmap_assert_locked() annotations to find_vma*() Message-ID: <20210804152148.GI543798@ziepe.ca> References: <20210731175341.3458608-1-lrizzo@google.com> <20210803160803.GG543798@ziepe.ca> <20210803230725.ao3i2emejyyor36n@revolver> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=WhDDPEFl; dmarc=none; spf=pass (imf19.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.175 as permitted sender) smtp.mailfrom=jgg@ziepe.ca X-Stat-Signature: tidk3boqjqdnqcjq4j85kd85ssprfxo3 X-Rspamd-Queue-Id: 7BA36B00BCAA X-Rspamd-Server: rspam01 X-HE-Tag: 1628090511-266704 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000019, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 04, 2021 at 04:42:23PM +0200, Jann Horn wrote: > Since I haven't sent a new version of my old series for almost a year, > I think it'd be fine to take Luigi's patch for now, and undo it at a > later point when/if we want to actually use proper locking here > because we're worried about concurrent access to the MM. IIRC one of the major points of that work was not "proper locking" but to have enough locking to be complatible with lockdep so we could add assertions like in get_user_pages and find_vma. Jason