From: Aaron Tomlin <atomlin@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@suse.com,
penguin-kernel@i-love.sakura.ne.jp, llong@redhat.com,
neelx@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm/oom_kill: show oom eligibility when displaying the current memory state of all tasks
Date: Mon, 2 Aug 2021 15:50:41 +0100 [thread overview]
Message-ID: <20210802145041.w7lqdt77qguwbwag@ava.usersys.com> (raw)
In-Reply-To: <fa6e3682-abae-f656-fec4-178a608face5@google.com>
On Sun 2021-08-01 20:49 -0700, David Rientjes wrote:
> oom_score_adj is shown already in the tasklist dump, I'm not sure what
> value this adds.
Fair enough.
>
> > + else if (test_bit(MMF_OOM_SKIP, &p->mm->flags)
> > + return "R";
> > + else if (in_vfork(p))
> > + return "V";
>
> This is going to be racy, we can't show that a task that is emitted as
> part of the tasklist dump was did not have in_vfork() == true at the time
> oom_badness() was called.
Yes, this is true.
> Wouldn't it be better to simply print the output of oom_badness() to the
> tasklist dump instead so we get complete information?
I think this would be acceptable.
> We could simply special case a LONG_MIN return value as -1000 or "min".
Agreed.
Kind regards,
--
Aaron Tomlin
next prev parent reply other threads:[~2021-08-02 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 16:20 Aaron Tomlin
2021-08-01 20:01 ` Andrew Morton
2021-08-02 3:49 ` David Rientjes
2021-08-02 14:50 ` Aaron Tomlin [this message]
2021-08-02 6:34 ` Michal Hocko
2021-08-02 15:12 ` Aaron Tomlin
2021-08-03 7:05 ` Michal Hocko
2021-08-03 10:32 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210802145041.w7lqdt77qguwbwag@ava.usersys.com \
--to=atomlin@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llong@redhat.com \
--cc=mhocko@suse.com \
--cc=neelx@redhat.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox