From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D95A4C4338F for ; Sun, 1 Aug 2021 19:49:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 354E060F55 for ; Sun, 1 Aug 2021 19:49:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 354E060F55 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 7B2826B0033; Sun, 1 Aug 2021 15:49:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 762C58D0001; Sun, 1 Aug 2021 15:49:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 677BF6B005D; Sun, 1 Aug 2021 15:49:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0122.hostedemail.com [216.40.44.122]) by kanga.kvack.org (Postfix) with ESMTP id 4FE496B0033 for ; Sun, 1 Aug 2021 15:49:19 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E10D21267C for ; Sun, 1 Aug 2021 19:49:18 +0000 (UTC) X-FDA: 78427550796.01.F63D2FB Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf15.hostedemail.com (Postfix) with ESMTP id 8CE2AD0004AE for ; Sun, 1 Aug 2021 19:49:18 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9265E60F48; Sun, 1 Aug 2021 19:49:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1627847357; bh=NTAguXKSk7YmzRLIg8c4guzvhTisx0c9C03a7Nlyj0c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YOoCmi2lFdEaPtaYD77vZpRAJf2VVhXEelHOrQjZnwTuHmEANlsEWHa7qsVv9OGH8 CGDu7AxTpCDyR+YmCJ9k77b+6YOgTJY16BAynxC8wnyLZT7DMjaCKoDudJcH4ztoj4 /hGHSFfDBsTSKnv0otaLCFi95EH3O8zY+QH1txas= Date: Sun, 1 Aug 2021 12:49:17 -0700 From: Andrew Morton To: Mina Almasry Cc: Ken Chen , Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chris Kennelly Subject: Re: [PATCH v1] mm, hugepages: add mremap() support for hugepage backed vma Message-Id: <20210801124917.ca6fce3972866dc738bfcb7b@linux-foundation.org> In-Reply-To: <20210730221522.524256-1-almasrymina@google.com> References: <20210730221522.524256-1-almasrymina@google.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=YOoCmi2l; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8CE2AD0004AE X-Stat-Signature: wjnnz5d69otd6139bsunm1datxq84a44 X-HE-Tag: 1627847358-381300 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 30 Jul 2021 15:15:22 -0700 Mina Almasry wrote: > Support mremap() for hugepage backed vma segment by simply repositioning > page table entries. The page table entries are repositioned to the new > virtual address on mremap(). > > Hugetlb mremap() support is of course generic; my motivating use case > is a library (hugepage_text), which reloads the ELF text of executables > in hugepages. This significantly increases the execution performance of > said executables. > > Restricts the mremap operation on hugepages to up to the size of the > original mapping as the underlying hugetlb reservation is not yet > capable of handling remapping to a larger size. > > Tested with a simple mmap/mremap test case, roughly: > > void* haddr = mmap(NULL, size, PROT_READ | PROT_WRITE | PROT_EXEC, > MAP_ANONYMOUS | MAP_SHARED, -1, 0); > > void* taddr = mmap(NULL, size, PROT_NONE, > MAP_HUGETLB | MAP_ANONYMOUS | MAP_SHARED, -1, 0); > > void* raddr = mremap(haddr, size, size, MREMAP_MAYMOVE | MREMAP_FIXED, taddr); Could we please get testing for this added into tools/testing/selftests/?