From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B3DDC4338F for ; Mon, 26 Jul 2021 09:55:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 171E660F49 for ; Mon, 26 Jul 2021 09:55:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 171E660F49 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5B44D6B0033; Mon, 26 Jul 2021 05:55:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53D4C8D0002; Mon, 26 Jul 2021 05:55:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DD7F8D0001; Mon, 26 Jul 2021 05:55:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 253E86B0033 for ; Mon, 26 Jul 2021 05:55:52 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id AB30618011ACA for ; Mon, 26 Jul 2021 09:55:51 +0000 (UTC) X-FDA: 78404282502.24.F9CF4CC Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by imf26.hostedemail.com (Postfix) with ESMTP id C125F202B683 for ; Mon, 26 Jul 2021 09:55:50 +0000 (UTC) Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16Q9prAE015362; Mon, 26 Jul 2021 11:55:43 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=selector1; bh=giOM4HnaEqC2qcIT64URAdWvI8eeLWVeP5WNigHDj+4=; b=dSdmwFVs84e6GxHJeBNTvVS7ETgvRQw8DrKUPur4dm0nZHPY4gYTCDyxmO6Eo/RNcwHP 8hVgCORnJYPtPCyKs2OWmvR8pByM4fi2jBIWdeAqWwfzaEo8+d5TfAp0sis7N2oAo9YB 6MDt6uAMJ+PisQSa2LCmrdP3KqiD/y+p+3XAKZNSYqCtCn0eSgUkF0fILnEwyU6NeE5y TdbwXdJzhuyzsIMozagigFS2zztNaRJ6pt08iXDeqTm5ZmZWN95qn93OFsym7AxpIVDk FS0G40gghTNLJwhqQlCMeNJy1csf6rY3ogqlNWxm74jw440tUErMOL5rzuW/3ETCzsj7 /w== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3a1swgrbqs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Jul 2021 11:55:43 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id AB6A310002A; Mon, 26 Jul 2021 11:55:40 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 9599F21B539; Mon, 26 Jul 2021 11:55:40 +0200 (CEST) Received: from gnbcxd0016.gnb.st.com (10.75.127.48) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 26 Jul 2021 11:55:40 +0200 Date: Mon, 26 Jul 2021 11:55:32 +0200 From: Alain Volmat To: kernel test robot CC: , Linux Memory Management List , Mark Brown , Maxime Coquelin , Alexandre Torgue , , , , Subject: Re: [PATCH] spi: stm32: fix excluded_middle.cocci warnings Message-ID: <20210726095532.GA11839@gnbcxd0016.gnb.st.com> Mail-Followup-To: kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List , Mark Brown , Maxime Coquelin , Alexandre Torgue , linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <202107140345.xyOobAtH-lkp@intel.com> <20210713191004.GA14729@5eb5c2cbef84> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210713191004.GA14729@5eb5c2cbef84> X-Disclaimer: ce message est personnel / this message is private X-Originating-IP: [10.75.127.48] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-07-26_05:2021-07-26,2021-07-26 signatures=0 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=foss.st.com header.s=selector1 header.b=dSdmwFVs; spf=pass (imf26.hostedemail.com: domain of "prvs=1841612ed4=alain.volmat@foss.st.com" designates 91.207.212.93 as permitted sender) smtp.mailfrom="prvs=1841612ed4=alain.volmat@foss.st.com"; dmarc=pass (policy=none) header.from=foss.st.com X-Rspamd-Server: rspam02 X-Stat-Signature: d3x19c61o8yqu1nfd5wehiw3kowzzr4y X-Rspamd-Queue-Id: C125F202B683 X-HE-Tag: 1627293350-507018 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks. Reviewed-by: Alain Volmat On Wed, Jul 14, 2021 at 03:10:04AM +0800, kernel test robot wrote: > From: kernel test robot > > drivers/spi/spi-stm32.c:915:23-25: WARNING !A || A && B is equivalent to !A || B > > > Condition !A || A && B is equivalent to !A || B. > > Generated by: scripts/coccinelle/misc/excluded_middle.cocci > > Fixes: 7ceb0b8a3ced ("spi: stm32: finalize message either on dma callback or EOT") > CC: Alain Volmat > Reported-by: kernel test robot > Signed-off-by: kernel test robot > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 8f0df15bafc1e1c92b6d96bf8ef24dd8be3aec7b > commit: 7ceb0b8a3ceddc36ae4ef1cba6c25a0e28ed65fc [1012/1340] spi: stm32: finalize message either on dma callback or EOT > :::::: branch date: 11 hours ago > :::::: commit date: 2 days ago > > spi-stm32.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > --- a/drivers/spi/spi-stm32.c > +++ b/drivers/spi/spi-stm32.c > @@ -912,8 +912,7 @@ static irqreturn_t stm32h7_spi_irq_threa > if (!spi->cur_usedma && (spi->rx_buf && (spi->rx_len > 0))) > stm32h7_spi_read_rxfifo(spi); > if (!spi->cur_usedma || > - (spi->cur_usedma && (spi->cur_comm == SPI_SIMPLEX_TX || > - spi->cur_comm == SPI_3WIRE_TX))) > + (spi->cur_comm == SPI_SIMPLEX_TX || spi->cur_comm == SPI_3WIRE_TX)) > end = true; > } >