From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B18CC63793 for ; Thu, 22 Jul 2021 09:29:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C30916120C for ; Thu, 22 Jul 2021 09:29:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C30916120C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E331A6B0036; Thu, 22 Jul 2021 05:28:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE2356B005D; Thu, 22 Jul 2021 05:28:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5BEC6B006C; Thu, 22 Jul 2021 05:28:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id A2BEC6B0036 for ; Thu, 22 Jul 2021 05:28:59 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 49A3316B08 for ; Thu, 22 Jul 2021 09:28:59 +0000 (UTC) X-FDA: 78389699598.13.8DE6F30 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf12.hostedemail.com (Postfix) with ESMTP id B709310000A8 for ; Thu, 22 Jul 2021 09:28:58 +0000 (UTC) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16M9QqR0015190; Thu, 22 Jul 2021 09:28:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2021-07-09; bh=m6f8aY4oQoKefdVDDZLeUdvdJvEd0r5KfMyoJNeuqTk=; b=aaWrgxT2dSnolnD5ep8Rq6n+ba9wAzMTrsKezOBCwx/F8lzFxChSwCDragIAvmTzzmxX osuADVYyeLkyPS7mOdUXOwlDnCwo3WRBNJEzXu/NV3ysHP4maKTPGgzjSJcOurx5fqaI 3naoGe3jTzzLcql7lDPFM/MsOLyocv54uRq4Jh42fGGTd5C7T6KeMQx7Rra243JdLISH MEZK5SFTvsMGEIxhuFWLfzD8T5dk/Z/A5SPF5K/B4Za4jm9f8asWkrhpFRVkzeP+OchT d041a+dfaRFcNnj0/tceAcHb04fmdSvD7cStUYVtM3XPGso9feT8dlJ1Obr5tQA7P+XA ZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2020-01-29; bh=m6f8aY4oQoKefdVDDZLeUdvdJvEd0r5KfMyoJNeuqTk=; b=WS4WJAbXNDy8RggywBhE5otY+MfNoLBj6vvxTRfZjEorsvE1mBgwOoYRmEo/A5ExZKDl 5xszcSRPBCwolWqG0a9l1wQis2zA87s/f4as+L2ig1/hjCoxaM1g1w/ZtUGRijJjv7q3 PErr0X+m4tUS84MQ2F9F16bm3g6QTWh7h94yxzmH8J7TMiR1HmE/wUUsv70Qt0bL1O5U pw8B0L4emYxuq6Lxn5ZwvHrPImYd3QFgCHYnbGau8U5CO2YRr45xIzF0uj8ZBGfwRkiv U5v31ft/MefBxk8NpfMwaHBlJ+euYRD7TfwyfTc401bhGPkBMgHNjqFs7wOxSZM24+TP qg== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 39y04drmfe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Jul 2021 09:28:55 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 16M9PDMt099795; Thu, 22 Jul 2021 09:28:54 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2171.outbound.protection.outlook.com [104.47.58.171]) by aserp3020.oracle.com with ESMTP id 39uq1avwjy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Jul 2021 09:28:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ToaiFkkJnLp60tSGMx+Oq2Fca9gKtCzpFk49kB0+jCgN5EC5crZMmhiMlKvxUndDtcrTj0OtgqwDSfZjKCl1bt6QW7MPDqrRUmqDettWhYDKF+tjNMHzMuk5D64wXyUrfJzGmdFOgAGP5VCEgttTShTu2379q+m1VK7AUtzRlA8SoKYby7eUW/2Q1ssabCSdIKpY/BazjF/B3lerRvMTJ6KT7l2V3mQv6USQRwo/iY4828OBToyJJPaQMgaBZRofnLdySZCW0cFbfK2v7PK13eDCx43ROwxAVBt+I6/vBtK53dE/zgevRYUeK8cxJWgmcrAgoPp6MvWQwrBXis0vYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m6f8aY4oQoKefdVDDZLeUdvdJvEd0r5KfMyoJNeuqTk=; b=bJ2B7PLiTxF6HvXK77wBY34UNJP/TvasMC+ZXbVRIL21+6d4tN7U0EaaTWEtv1sgEo/XH9rIh1t0vcSJ3NF0mSAXq25qTAzm1HFJBt1DgqjCNc9dB1GwmDVy5HlrWa4WdeTQcNPDTM/J8V4gaBVSCDMlcS4JCO0PBvYBZcdHs7x6LVf3pxf0IN1u+p3LAx45bdwq6NycTeSRCP903VywEEpx5KumhhLrqZQLHWvElFjDvl+GxZlXvWQ72uEkgUIHp9l/lJsdEl8c0U3GvDLU2ZD6JdDYboKwHEuGa5bjhyGY0Qdf27dTeabsldKNCRV6fpl1wp8lHbreyryIqcLn0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m6f8aY4oQoKefdVDDZLeUdvdJvEd0r5KfMyoJNeuqTk=; b=nRTn3RpE0BWYANs7cahO55U1VsZi0C1s3J4XltVUy1/Lsd76iKc4qSpcbR+6eIN7r/xeRC+Vcjrns4aBRzc5zoCUW0uJKWtAH+4SNq6TFL1wafStyfbSOWwXZobIAY3OQNr2ShXgp4zNrviwcJAkeCNDcye5OLAcB2feeyC6e4A= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by MWHPR10MB1728.namprd10.prod.outlook.com (2603:10b6:301:9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.25; Thu, 22 Jul 2021 09:28:51 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5820:e42b:73d7:4268]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5820:e42b:73d7:4268%7]) with mapi id 15.20.4331.034; Thu, 22 Jul 2021 09:28:51 +0000 Date: Thu, 22 Jul 2021 12:28:17 +0300 From: Dan Carpenter To: kbuild@lists.01.org, Takashi Iwai Cc: lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List Subject: [linux-next:master 1517/2389] sound/pci/als4000.c:930 snd_card_als4000_probe() warn: 'pci' not released on lines: 852,872. Message-ID: <202107221413.qyIXVv60-lkp@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: JNAP275CA0034.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4d::11) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from kadam (102.222.70.252) by JNAP275CA0034.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.25 via Frontend Transport; Thu, 22 Jul 2021 09:28:42 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 61800f40-362d-4ebf-dd91-08d94cf31dce X-MS-TrafficTypeDiagnostic: MWHPR10MB1728: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VZFCmMbsUlcl/IiFYHCLJ/7Efd+YrO6zbsBUYRBzXUKxMns97ebuZHrOhyotvNAV+D1J/k9oC7aBLp2vfcB4f/seMm52awcFoAUHQc4QJgFCV2lNuVQ4BAMdo0SAQdWNXFoILIzofL57Y3HxG/QZIE6d+B8wQYz3RKFFVUVlISbDV1oS8PIdE9luHLrr+0GURWZJZbHUDZwWzfyFhodPZm9x5OUXfmwdGL9HaI4gyDX9K62Ms0gbSSliBd83AnTaoIuJMs2fJLP6PWq7LLItQWxjEyPXIrdSfJWqxvRqGG2a3N/l36UgAhqxw7NSOK+zkQnHwkJQrPY1M7ayxfioed1KazsHfppynPv83lwxVLXKLGP6Ze1jJMLNCGIkbOi/zpKwhl1CXOl/IcueDTR86i0kKDWce8QCJDxY3Hcj9GDzF0dHab+tTBr8HbgVHZU2SW3cCLQnmEF+qQ8cKrDq/g0haa5eA31pMiA3skMFMzS3Aipp+jLh14Uou+nJJR2+YMmfuH0f9kxxBjJgw46sQU2XvxJPKAde0hxVVtKTy/soPkraK5C4cqnvJwfcIi5L4n24Stvh9JDCozJgXtWbH7JvSgBgc57bwqIJmtM1lHu99ep9WcBd7KhbdQ1cv7rp6+SwZ7KtrOrOrInnbcjfEoroUcA5pf335L8ATIKpRE7hqVM1F7ajWmR9L5tln96Spn75bPndAH+hrk9s/SDBW12Z2tV28OJ84mQnAWvBvvWDamR7+vBVIiRmv39f8aDvCimWFmRy7zFYkPDrPFZCYADRaPfDkf9bdvjgXoe2Es5IxYDiZXeG9JQuKFwpyzX5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(136003)(39860400002)(346002)(396003)(376002)(9686003)(6666004)(66946007)(66476007)(66556008)(44832011)(6486002)(86362001)(83380400001)(4326008)(478600001)(1076003)(966005)(52116002)(6496006)(186003)(36756003)(956004)(38100700002)(8936002)(38350700002)(5660300002)(6916009)(8676002)(316002)(2906002)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Q/Po2QRVGUzc6/qc8qLwJXyVatgBr1bmYOkH7zuYIY96yNdbO+v9Xrh+nnjS?= =?us-ascii?Q?9SqpBXl8HRAryPcHh43fKeQ0N3K1p5VB4889qV92W7XiXN7Jz/1uZMWBU/S8?= =?us-ascii?Q?osQn/djiw6BKon7jgcR1QPhMZwQHD54P6oUMeoAZpWYeU5wnjQfHmkvjJyxo?= =?us-ascii?Q?ZoepmZJKPy8Z2BLq6ZCALt7iTkr7kaq081tBWKFh4rf3y7D02jimFrYyDJod?= =?us-ascii?Q?PDFYdIqTjZCzqXaHEwL3lOZ2xDv1eXJ6ZHGBujMfh9DbGawP71MZN2E40ln1?= =?us-ascii?Q?JqpzGlDVTUckZu8kumqh8gIK2zy5mxVVKoMyqion/jiPctCXq2he36ZkNBV3?= =?us-ascii?Q?TueHBNAhNYdUFZLzC2XI0wkI1JvucR8G9zH0c2uBwfYk4KXTzGcXgVeJcqYe?= =?us-ascii?Q?/HzWeg6Snt4We5VNdPqw0ovdunAYUBRX6ULov5T0/tpw0oGkpQvYFY93eAT7?= =?us-ascii?Q?8116dyZCYdiUyrKZZOnr8mjXKZskMJlm31BRySZvFY3piPYXNAg487AyIgBx?= =?us-ascii?Q?tm9HjIsA+b+PR+Xk/IYUroidMM+dP5+raaFVL0oExTr4UIh9D34uDEljVk3Y?= =?us-ascii?Q?JFTWa9I3j0exrC6hkKyIYmtY9LDWWJlpxxdNC9Z4gMfvU2uxdfeLARanohZt?= =?us-ascii?Q?Gn0P+jOdkVCfyWCEm8NlnjaF7dQ1EOurVQm7gUGkfeGMDfX8KAkGQaz+uZlU?= =?us-ascii?Q?7/5kRjAAM9w04G53urLOLPAlW4u55z6SqnR0f0O7xcsLgi8ie3mxwjmOLEas?= =?us-ascii?Q?kQHS1+A6Kzspx4O/fVmllVzPzQc7z/6JvWxfEluJfksZoKc1FwUbPS1uy1hF?= =?us-ascii?Q?G67pJa9O6t7wCEzPnLIF946v5sdvbgAkM4Yq0us57GiYe/fRZjQib/lSG3+0?= =?us-ascii?Q?0IViBgBfcAguTeFPRGp3ojgTvj8tPuSPjpsb2jNJuG7hdWd5acY2qFub6bqr?= =?us-ascii?Q?jFpRAoGEgC9UREb50vFlZWjCabuMknvg+KHRJ8H5usdT8eXO3uGOD2ekIxyx?= =?us-ascii?Q?nrqWep+Lq2T3lrjdmypDzgdM+cH3eYP1QOY0BJFrIEGdQ4d4C/yuiTBrYeUv?= =?us-ascii?Q?/bI1H4klmKkANVKkiVBrAgan5FQuTcbiBpcLxxCa7JcIaDbU/sAmLQOmNucI?= =?us-ascii?Q?y2ZqCb+zzryNjuEmw3OR20GSg3B0poGYT4Q4tJfHcRpjAGHq//HWza23kwP8?= =?us-ascii?Q?VFWGa/N5rnrtVUzaWQTsVMEu7EepsJnGF6a0anzGmJ/7HS5p/yo0ie4i6dNH?= =?us-ascii?Q?rm/au+osuW7pS4GqKIzJoNlUqKInqVs0/XO14LCAvxK68ooCiI1oDQggag/Y?= =?us-ascii?Q?3/jH7cZpU8g5eKnAlhNkOihe?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61800f40-362d-4ebf-dd91-08d94cf31dce X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2021 09:28:51.6822 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TKt6h9BgdDg+9/cp5MpY/zkALf5Asy0bpEmMGg9/gUQnj6vAgNXFxpZPMP/enteHED8IL47Eh357/3Kdgmigh92v17b0m59ATRTsZv9/src= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1728 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10052 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 spamscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107220062 X-Proofpoint-GUID: CtGCcx3i43tbe5VZva2CRt7oO8OvhmWo X-Proofpoint-ORIG-GUID: CtGCcx3i43tbe5VZva2CRt7oO8OvhmWo Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=aaWrgxT2; dkim=pass header.d=oracle.com header.s=corp-2020-01-29 header.b=WS4WJAbX; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=nRTn3RpE; spf=none (imf12.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=dan.carpenter@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B709310000A8 X-Stat-Signature: d8umq7n1ac6hfajar4qrn6thr13sk178 X-HE-Tag: 1626946138-741445 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: b1347210b01daa977ea980268927aa99198ceccc commit: 0e175f665960c7be30aba47afbee4f2d121ea5fc [1517/2389] ALSA: als4000: Allocate resources with device-managed APIs config: x86_64-randconfig-m001-20210722 (attached as .config) compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: sound/pci/als4000.c:930 snd_card_als4000_probe() warn: 'pci' not released on lines: 852,872. vim +/pci +930 sound/pci/als4000.c e23e7a14362072 Bill Pemberton 2012-12-06 809 static int snd_card_als4000_probe(struct pci_dev *pci, ^1da177e4c3f41 Linus Torvalds 2005-04-16 810 const struct pci_device_id *pci_id) ^1da177e4c3f41 Linus Torvalds 2005-04-16 811 { ^1da177e4c3f41 Linus Torvalds 2005-04-16 812 static int dev; 17c39d9a59cbf4 Takashi Iwai 2005-11-17 813 struct snd_card *card; 17c39d9a59cbf4 Takashi Iwai 2005-11-17 814 struct snd_card_als4000 *acard; c0874449849175 Andreas Mohr 2008-08-20 815 unsigned long iobase; 17c39d9a59cbf4 Takashi Iwai 2005-11-17 816 struct snd_sb *chip; 17c39d9a59cbf4 Takashi Iwai 2005-11-17 817 struct snd_opl3 *opl3; ^1da177e4c3f41 Linus Torvalds 2005-04-16 818 unsigned short word; ^1da177e4c3f41 Linus Torvalds 2005-04-16 819 int err; ^1da177e4c3f41 Linus Torvalds 2005-04-16 820 ^1da177e4c3f41 Linus Torvalds 2005-04-16 821 if (dev >= SNDRV_CARDS) ^1da177e4c3f41 Linus Torvalds 2005-04-16 822 return -ENODEV; ^1da177e4c3f41 Linus Torvalds 2005-04-16 823 if (!enable[dev]) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 824 dev++; ^1da177e4c3f41 Linus Torvalds 2005-04-16 825 return -ENOENT; ^1da177e4c3f41 Linus Torvalds 2005-04-16 826 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 827 ^1da177e4c3f41 Linus Torvalds 2005-04-16 828 /* enable PCI device */ 0e175f665960c7 Takashi Iwai 2021-07-15 829 err = pcim_enable_device(pci); 61ea06e8a88163 Takashi Iwai 2021-06-08 830 if (err < 0) ^1da177e4c3f41 Linus Torvalds 2005-04-16 831 return err; 61ea06e8a88163 Takashi Iwai 2021-06-08 832 ^1da177e4c3f41 Linus Torvalds 2005-04-16 833 /* check, if we can restrict PCI DMA transfers to 24 bits */ 669f65eaeb969e Takashi Iwai 2021-01-14 834 if (dma_set_mask_and_coherent(&pci->dev, DMA_BIT_MASK(24))) { d85d878efb3047 Takashi Iwai 2014-02-25 835 dev_err(&pci->dev, "architecture does not support 24bit PCI busmaster DMA\n"); ^1da177e4c3f41 Linus Torvalds 2005-04-16 836 return -ENXIO; ^1da177e4c3f41 Linus Torvalds 2005-04-16 837 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 838 61ea06e8a88163 Takashi Iwai 2021-06-08 839 err = pci_request_regions(pci, "ALS4000"); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 0e175f665960c7 Takashi Iwai 2021-07-15 840 if (err < 0) ^1da177e4c3f41 Linus Torvalds 2005-04-16 841 return err; c0874449849175 Andreas Mohr 2008-08-20 842 iobase = pci_resource_start(pci, 0); ^1da177e4c3f41 Linus Torvalds 2005-04-16 843 ^1da177e4c3f41 Linus Torvalds 2005-04-16 844 pci_read_config_word(pci, PCI_COMMAND, &word); ^1da177e4c3f41 Linus Torvalds 2005-04-16 845 pci_write_config_word(pci, PCI_COMMAND, word | PCI_COMMAND_IO); ^1da177e4c3f41 Linus Torvalds 2005-04-16 846 pci_set_master(pci); ^1da177e4c3f41 Linus Torvalds 2005-04-16 847 0e175f665960c7 Takashi Iwai 2021-07-15 848 err = snd_devm_card_new(&pci->dev, index[dev], id[dev], THIS_MODULE, e58de7baf7de11 Takashi Iwai 2008-12-28 849 sizeof(*acard) /* private_data: acard */, e58de7baf7de11 Takashi Iwai 2008-12-28 850 &card); 0e175f665960c7 Takashi Iwai 2021-07-15 851 if (err < 0) e58de7baf7de11 Takashi Iwai 2008-12-28 852 return err; ^^^^^^^^^^ Smatch complains because there is no error handling. Maybe the other error paths use devm_ magic? Or more likely Smatch just isn't smart enough... ^1da177e4c3f41 Linus Torvalds 2005-04-16 853 c0874449849175 Andreas Mohr 2008-08-20 854 acard = card->private_data; ^1da177e4c3f41 Linus Torvalds 2005-04-16 855 acard->pci = pci; c0874449849175 Andreas Mohr 2008-08-20 856 acard->iobase = iobase; ^1da177e4c3f41 Linus Torvalds 2005-04-16 857 card->private_free = snd_card_als4000_free; ^1da177e4c3f41 Linus Torvalds 2005-04-16 858 ^1da177e4c3f41 Linus Torvalds 2005-04-16 859 /* disable all legacy ISA stuff */ c0874449849175 Andreas Mohr 2008-08-20 860 snd_als4000_set_addr(acard->iobase, 0, 0, 0, 0); ^1da177e4c3f41 Linus Torvalds 2005-04-16 861 61ea06e8a88163 Takashi Iwai 2021-06-08 862 err = snd_sbdsp_create(card, c0874449849175 Andreas Mohr 2008-08-20 863 iobase + ALS4K_IOB_10_ADLIB_ADDR0, ^1da177e4c3f41 Linus Torvalds 2005-04-16 864 pci->irq, cb780cdd85b8ae Andreas Mohr 2008-08-21 865 /* internally registered as IRQF_SHARED in case of ALS4000 SB */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 866 snd_als4000_interrupt, ^1da177e4c3f41 Linus Torvalds 2005-04-16 867 -1, ^1da177e4c3f41 Linus Torvalds 2005-04-16 868 -1, ^1da177e4c3f41 Linus Torvalds 2005-04-16 869 SB_HW_ALS4000, 61ea06e8a88163 Takashi Iwai 2021-06-08 870 &chip); 61ea06e8a88163 Takashi Iwai 2021-06-08 871 if (err < 0) 0e175f665960c7 Takashi Iwai 2021-07-15 872 return err; ^^^^^^^^^^ I don't know why only these two error paths trigger a warning. 703529140cfb77 Takashi Iwai 2005-11-17 873 acard->chip = chip; ^1da177e4c3f41 Linus Torvalds 2005-04-16 874 ^1da177e4c3f41 Linus Torvalds 2005-04-16 875 chip->pci = pci; c0874449849175 Andreas Mohr 2008-08-20 876 chip->alt_port = iobase; ^1da177e4c3f41 Linus Torvalds 2005-04-16 877 ^1da177e4c3f41 Linus Torvalds 2005-04-16 878 snd_als4000_configure(chip); ^1da177e4c3f41 Linus Torvalds 2005-04-16 879 ^1da177e4c3f41 Linus Torvalds 2005-04-16 880 strcpy(card->driver, "ALS4000"); ^1da177e4c3f41 Linus Torvalds 2005-04-16 881 strcpy(card->shortname, "Avance Logic ALS4000"); ^1da177e4c3f41 Linus Torvalds 2005-04-16 882 sprintf(card->longname, "%s at 0x%lx, irq %i", ^1da177e4c3f41 Linus Torvalds 2005-04-16 883 card->shortname, chip->alt_port, chip->irq); ^1da177e4c3f41 Linus Torvalds 2005-04-16 884 61ea06e8a88163 Takashi Iwai 2021-06-08 885 err = snd_mpu401_uart_new(card, 0, MPU401_HW_ALS4000, c0874449849175 Andreas Mohr 2008-08-20 886 iobase + ALS4K_IOB_30_MIDI_DATA, dba8b46992c559 Clemens Ladisch 2011-09-13 887 MPU401_INFO_INTEGRATED | dba8b46992c559 Clemens Ladisch 2011-09-13 888 MPU401_INFO_IRQ_HOOK, 61ea06e8a88163 Takashi Iwai 2021-06-08 889 -1, &chip->rmidi); 61ea06e8a88163 Takashi Iwai 2021-06-08 890 if (err < 0) { d85d878efb3047 Takashi Iwai 2014-02-25 891 dev_err(&pci->dev, "no MPU-401 device at 0x%lx?\n", c0874449849175 Andreas Mohr 2008-08-20 892 iobase + ALS4K_IOB_30_MIDI_DATA); 0e175f665960c7 Takashi Iwai 2021-07-15 893 return err; ^1da177e4c3f41 Linus Torvalds 2005-04-16 894 } c0874449849175 Andreas Mohr 2008-08-20 895 /* FIXME: ALS4000 has interesting MPU401 configuration features cb780cdd85b8ae Andreas Mohr 2008-08-21 896 * at ALS4K_CR1A_MPU401_UART_MODE_CONTROL cb780cdd85b8ae Andreas Mohr 2008-08-21 897 * (pass-thru / UART switching, fast MIDI clock, etc.), cb780cdd85b8ae Andreas Mohr 2008-08-21 898 * however there doesn't seem to be an ALSA API for this... cb780cdd85b8ae Andreas Mohr 2008-08-21 899 * SPECS_PAGE: 21 */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 900 61ea06e8a88163 Takashi Iwai 2021-06-08 901 err = snd_als4000_pcm(chip, 0); 61ea06e8a88163 Takashi Iwai 2021-06-08 902 if (err < 0) 0e175f665960c7 Takashi Iwai 2021-07-15 903 return err; 61ea06e8a88163 Takashi Iwai 2021-06-08 904 61ea06e8a88163 Takashi Iwai 2021-06-08 905 err = snd_sbmixer_new(chip); 61ea06e8a88163 Takashi Iwai 2021-06-08 906 if (err < 0) 0e175f665960c7 Takashi Iwai 2021-07-15 907 return err; ^1da177e4c3f41 Linus Torvalds 2005-04-16 908 c0874449849175 Andreas Mohr 2008-08-20 909 if (snd_opl3_create(card, c0874449849175 Andreas Mohr 2008-08-20 910 iobase + ALS4K_IOB_10_ADLIB_ADDR0, c0874449849175 Andreas Mohr 2008-08-20 911 iobase + ALS4K_IOB_12_ADLIB_ADDR2, ^1da177e4c3f41 Linus Torvalds 2005-04-16 912 OPL3_HW_AUTO, 1, &opl3) < 0) { d85d878efb3047 Takashi Iwai 2014-02-25 913 dev_err(&pci->dev, "no OPL device at 0x%lx-0x%lx?\n", c0874449849175 Andreas Mohr 2008-08-20 914 iobase + ALS4K_IOB_10_ADLIB_ADDR0, c0874449849175 Andreas Mohr 2008-08-20 915 iobase + ALS4K_IOB_12_ADLIB_ADDR2); ^1da177e4c3f41 Linus Torvalds 2005-04-16 916 } else { 61ea06e8a88163 Takashi Iwai 2021-06-08 917 err = snd_opl3_hwdep_new(opl3, 0, 1, NULL); 61ea06e8a88163 Takashi Iwai 2021-06-08 918 if (err < 0) 0e175f665960c7 Takashi Iwai 2021-07-15 919 return err; ^1da177e4c3f41 Linus Torvalds 2005-04-16 920 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 921 ^1da177e4c3f41 Linus Torvalds 2005-04-16 922 snd_als4000_create_gameport(acard, dev); ^1da177e4c3f41 Linus Torvalds 2005-04-16 923 61ea06e8a88163 Takashi Iwai 2021-06-08 924 err = snd_card_register(card); 61ea06e8a88163 Takashi Iwai 2021-06-08 925 if (err < 0) 0e175f665960c7 Takashi Iwai 2021-07-15 926 return err; 61ea06e8a88163 Takashi Iwai 2021-06-08 927 ^1da177e4c3f41 Linus Torvalds 2005-04-16 928 pci_set_drvdata(pci, card); ^1da177e4c3f41 Linus Torvalds 2005-04-16 929 dev++; 0e175f665960c7 Takashi Iwai 2021-07-15 @930 return 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 931 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org