From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 655ACC636CA for ; Wed, 21 Jul 2021 00:12:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 230D2610F7 for ; Wed, 21 Jul 2021 00:12:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 230D2610F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 964E86B0011; Tue, 20 Jul 2021 20:12:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93B9D6B0036; Tue, 20 Jul 2021 20:12:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 803B66B006C; Tue, 20 Jul 2021 20:12:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id 5D1526B0011 for ; Tue, 20 Jul 2021 20:12:25 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DB2661F853 for ; Wed, 21 Jul 2021 00:12:23 +0000 (UTC) X-FDA: 78384668166.29.33716EF Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf16.hostedemail.com (Postfix) with ESMTP id 7F693F000AC0 for ; Wed, 21 Jul 2021 00:12:23 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 97BA36101B; Wed, 21 Jul 2021 00:12:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626826339; bh=E65jLqKjRMg5Qkn2BhBuKgQbm8+Mo4vJ7cckyConMrM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aBguU6Ty/PN6IkRXHSBTi4XYh+X8QVVMD+fjGhgtbhCI5v/+LFaBwUNLGJmABMBlx dAjP9CclOrrJWP/+ZcleVIZUrHBzPys/XfvbFOYXx6hx90c8QXDuzfM4/+lYuqv+01 lIzktlI9vcvimUPaU3FMizlT60kkagDCIU6xy3Zu5aDXEK3OBIoyPYrBPsv8FH3QMV gPCJFhbE58hWo4Hv9QDicgoFudVJ1NHgx0QpxZp6/BXPGSSB4/pe5YnZOh8dzv5zHk U9Zu/m0DKjFbajve8zzo+w/hSEs8YOW0haTyzOaNykWNzGpWxkuSb0qZfrGqTympdt vIaNLmBsJsr5Q== Date: Tue, 20 Jul 2021 17:12:19 -0700 From: "Darrick J. Wong" To: "Matthew Wilcox (Oracle)" , Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org Subject: Re: [PATCH v15 16/17] iomap: Convert iomap_add_to_ioend to take a folio Message-ID: <20210721001219.GR22357@magnolia> References: <20210719184001.1750630-1-willy@infradead.org> <20210719184001.1750630-17-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210719184001.1750630-17-willy@infradead.org> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7F693F000AC0 X-Stat-Signature: edynwdfr9a53yi5ya6qzshhau3qahbuq Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aBguU6Ty; spf=pass (imf16.hostedemail.com: domain of djwong@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1626826343-337425 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 19, 2021 at 07:40:00PM +0100, Matthew Wilcox (Oracle) wrote: > We still iterate one block at a time, but now we call compound_head() > less often. Rename file_offset to pos to fit the rest of the file. > > Signed-off-by: Matthew Wilcox (Oracle) Everything in this patch looks ok to me, though I gather there will be further changes to bio_add_folio, so I'll leave this off for now. I /am/ beginning to wonder, though -- seeing as Christoph and Matthew both have very large patchsets changing things in fs/iomap/, how would you like those landed? Christoph's iterator refactoring looks like it could be ready to go for 5.15. Matthew's folio series looks like a mostly straightforward conversion for iomap, except that it has 91 patches as a hard dependency. Since most of the iomap changes for 5.15 aren't directly related to folios, I think I prefer iomap-for-next to be based directly off -rcX like usual, though I don't know where that leaves the iomap folio conversion. I suppose one could add them to a branch that itself is a result of the folio and iomap branches, or leave them off for 5.16? Other ideas? --D