From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09D12C07E9B for ; Tue, 20 Jul 2021 23:57:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9CB2E61007 for ; Tue, 20 Jul 2021 23:57:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CB2E61007 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 535726B0036; Tue, 20 Jul 2021 19:57:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50C276B006C; Tue, 20 Jul 2021 19:57:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D55A6B0070; Tue, 20 Jul 2021 19:57:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id 1A9F26B0036 for ; Tue, 20 Jul 2021 19:57:31 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9FA662042C for ; Tue, 20 Jul 2021 23:57:29 +0000 (UTC) X-FDA: 78384630618.12.CA5628D Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf13.hostedemail.com (Postfix) with ESMTP id 4AA0910107DA for ; Tue, 20 Jul 2021 23:57:29 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id DAEBB61007; Tue, 20 Jul 2021 23:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626825447; bh=+cUiV985wmYic24lRaCwT9f5w3aNSR/YyFMd0hJ3ZQo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=htWE3SCJxV6U3m4mDWtM3PqYvJrjcojmOCYJsBKLHefhtlctr4zkoYMESyPVOpCmJ 86SCcrcCYM+jGe9utMjcOt3iLZb3ssDojEz7vWl580aw1dOY9/UG174n+sjGmOiXfM GMm2t0kjHxNtahsw2rUFKsT/GXI6FuHC6nDhTmSmAsxBqmq5XSu9Fb7DdbgsC8LIsH DbPKaUTtgv+Ls3eZPWpxJnAmFcUfK81YNXWwUV4ItLOvutEnwaiLyM4PgvB2t67pkf gbiADXluutxxmzaTRRYWn82FHKQV9Ny956+9IzxNnbQDH5dLwj5XWUmcnMTBjmdEJx qJCsMAzbBJQVw== Date: Tue, 20 Jul 2021 16:57:26 -0700 From: "Darrick J. Wong" To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org Subject: Re: [PATCH v15 07/17] iomap: Convert iomap_invalidatepage to use a folio Message-ID: <20210720235726.GB3033223@magnolia> References: <20210719184001.1750630-1-willy@infradead.org> <20210719184001.1750630-8-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210719184001.1750630-8-willy@infradead.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4AA0910107DA X-Stat-Signature: nj5bxqnj991z9mz6iaua5htbye9r31jb Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=htWE3SCJ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of djwong@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=djwong@kernel.org X-HE-Tag: 1626825449-115589 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 19, 2021 at 07:39:51PM +0100, Matthew Wilcox (Oracle) wrote: > This is an address_space operation, so its argument must remain as a > struct page, but we can use a folio internally. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good! Reviewed-by: Darrick J. Wong --D > --- > fs/iomap/buffered-io.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index 715b25a1c1e6..0d7b6ef4c5cc 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -480,15 +480,15 @@ iomap_invalidatepage(struct page *page, unsigned int offset, unsigned int len) > { > struct folio *folio = page_folio(page); > > - trace_iomap_invalidatepage(page->mapping->host, offset, len); > + trace_iomap_invalidatepage(folio->mapping->host, offset, len); > > /* > * If we are invalidating the entire page, clear the dirty state from it > * and release it to avoid unnecessary buildup of the LRU. > */ > - if (offset == 0 && len == PAGE_SIZE) { > - WARN_ON_ONCE(PageWriteback(page)); > - cancel_dirty_page(page); > + if (offset == 0 && len == folio_size(folio)) { > + WARN_ON_ONCE(folio_test_writeback(folio)); > + folio_cancel_dirty(folio); > iomap_page_release(folio); > } > } > -- > 2.30.2 >