From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9F7CC6377C for ; Sun, 18 Jul 2021 21:28:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6698D60FEA for ; Sun, 18 Jul 2021 21:28:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6698D60FEA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 018A08D00F6; Sun, 18 Jul 2021 17:28:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0AD68D00EC; Sun, 18 Jul 2021 17:28:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DABC68D00F6; Sun, 18 Jul 2021 17:28:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id B3E348D00EC for ; Sun, 18 Jul 2021 17:28:14 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5C77C8249980 for ; Sun, 18 Jul 2021 21:28:13 +0000 (UTC) X-FDA: 78376996866.40.A2D4894 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf17.hostedemail.com (Postfix) with ESMTP id 10560F00039D for ; Sun, 18 Jul 2021 21:28:12 +0000 (UTC) Received: by mail-lj1-f174.google.com with SMTP id h9so23016915ljm.5 for ; Sun, 18 Jul 2021 14:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RDmZbfk4umt1NTgReOWa0nlo9wbj8HPSJ0b72AWtHlI=; b=m3X+8h5sNcmib/Jzd1hwMXGfSUSimXJ8rCCYFjWXgqdSTHMLURCciTa1Gkf8rtY8gF IncY0rxbJp7diuFaM+sFO05fUn4c92aIEMDVyrXI8pBY4anM35msGOlHF0MDM4G62Dk2 FhjzD5Th/XMP9NIJnqKS/cWnewOk8N41dGlkiPqK/TQK+uGp9PoN7en3TFzuESVIRDVe kr2/rVucVrHylll2n8fEOui5IgqOAIj4yZKDt0w5Td30AqPv6TC7MY5vZrLeh82nYqP9 3pq3j/JTjz9QWloFIbVWejNWh2rAHLrHh4gy2ZCayJtoD1AYG6AVo/w29miAlO0N3kz/ cokg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RDmZbfk4umt1NTgReOWa0nlo9wbj8HPSJ0b72AWtHlI=; b=cxo9a6XOC9as6GjOjVtnMJKAa9ZeZy0rALs7WLmWC9j37PZQ8HASYrrM8OvYkRn4bW 2mSQ+jYKWrJzukTlepMGTO2sk9fCICLyF9T5ccModo5JeKHX7ICv7Aku7pMVrNfPKeYD O7JhZWyfJ4rKY0Beq69X039janRRKabUMDQDhl0r705red2xiai9lPFNJ1CDCfuACnTo JpNJViMYkQNqLq2QUjgg5fewParG1w54/LAz/pM4xOjGwCBSBGM+snv7+fiUusKo1P1Z Jy/FUYibLqIsU9zH6EYG01gViC9bUy6tIx+OoBRXMS+lFW/hh99aTtOXerWZ33fjSTDx KNtA== X-Gm-Message-State: AOAM5334HCWm3Dhgif68qQYf+6HQ1xCC3cZgrgDpCFabzj/t/vXQXss/ yauYVP/cK+FgAIhde1/ZrKPCdg== X-Google-Smtp-Source: ABdhPJzslQtZZUuJs3gEJ2cjkwE33akLtrf7biZvMZ6KhTw7w+qis1t8Cmc/qZBJE6B/zyxqPlhZpA== X-Received: by 2002:a2e:3506:: with SMTP id z6mr20511573ljz.238.1626643691394; Sun, 18 Jul 2021 14:28:11 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id z13sm1232704lfb.40.2021.07.18.14.28.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jul 2021 14:28:10 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 6C5B610260F; Mon, 19 Jul 2021 00:28:14 +0300 (+03) Date: Mon, 19 Jul 2021 00:28:14 +0300 From: "Kirill A. Shutemov" To: Qi Zheng Cc: akpm@linux-foundation.org, tglx@linutronix.de, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, songmuchun@bytedance.com Subject: Re: [PATCH 1/7] mm: fix the deadlock in finish_fault() Message-ID: <20210718212814.suvziikndiyezi6m@box.shutemov.name> References: <20210718043034.76431-1-zhengqi.arch@bytedance.com> <20210718043034.76431-2-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210718043034.76431-2-zhengqi.arch@bytedance.com> Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=m3X+8h5s; spf=none (imf17.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.208.174) smtp.mailfrom=kirill@shutemov.name; dmarc=none X-Rspamd-Server: rspam05 X-Stat-Signature: hm3mny5u9w99fyfcgmgrr6wi4jj5shqh X-Rspamd-Queue-Id: 10560F00039D X-HE-Tag: 1626643692-377853 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 18, 2021 at 12:30:27PM +0800, Qi Zheng wrote: > The commit 63f3655f9501(mm, memcg: fix reclaim deadlock with writeback) > fix a deadlock bug by pre-allocating the pte page table outside of the > page lock, the commit f9ce0be71d1f(mm: Cleanup faultaround and > finish_fault() codepaths) rework the relevant code but ignore this race, > fix it. > > Fixes: f9ce0be71d1f(mm: Cleanup faultaround and finish_fault() codepaths) > Signed-off-by: Qi Zheng Acked-by: Kirill A. Shutemov and add stable@, please. -- Kirill A. Shutemov