From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0672FC636C9 for ; Sat, 17 Jul 2021 17:17:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 962626115C for ; Sat, 17 Jul 2021 17:17:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 962626115C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A8E968D00F4; Sat, 17 Jul 2021 13:17:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3EF48D00EC; Sat, 17 Jul 2021 13:17:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DF168D00F4; Sat, 17 Jul 2021 13:17:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0048.hostedemail.com [216.40.44.48]) by kanga.kvack.org (Postfix) with ESMTP id 63FF58D00EC for ; Sat, 17 Jul 2021 13:17:17 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0386820BC9 for ; Sat, 17 Jul 2021 17:17:16 +0000 (UTC) X-FDA: 78372735672.22.DA1CFAA Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf27.hostedemail.com (Postfix) with ESMTP id A823C70000B0 for ; Sat, 17 Jul 2021 17:17:15 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9629E6115A; Sat, 17 Jul 2021 17:17:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626542234; bh=9M4WiUsEgOctpJxxgPigGn9zB747+l+Fi5R2vFQb6ak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wgj/S5X46GZM/dB4/6vofbinxvayxhrJENOOUti3djByOLRx28R+0SFGDINC6x4R4 mTQ7uk66leDhUC90TuI/cLFU6+2wryRy0jftVFZPyP6Omnb+eQjQRAB1gVblIGh4Na NY1uppnoWk8jfhgmNbwAKdGLnzxqE/zGxSj5/x+by2LXH9Wu75MluQFVDHvSPwuNL2 G7JYVpWCoOo0bH7NzikWlRMw2CXxkt867wKNhqCLWhJL2EzEOZKC00h9lBviKi9EZ0 vOfsqxtAwURMRgJdAxsX5nIYFRmENdUsDECTnpZZGg+DWVSvLZGN5HE11voGMICnVO pCd5WporbfTgw== Date: Sat, 17 Jul 2021 10:17:13 -0700 From: "Darrick J. Wong" To: Roman Gushchin Cc: Murphy Zhou , Linux-Fsdevel , Linux MM Subject: Re: [fsdax xfs] Regression panic at inode_switch_wbs_work_fn Message-ID: <20210717171713.GB22357@magnolia> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Wgj/S5X4"; spf=pass (imf27.hostedemail.com: domain of djwong@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam05 X-Stat-Signature: utxxf6f6ib7ewx5b5t9u1rkyjwdxwyws X-Rspamd-Queue-Id: A823C70000B0 X-HE-Tag: 1626542235-998757 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 16, 2021 at 01:13:05PM -0700, Roman Gushchin wrote: > On Fri, Jul 16, 2021 at 01:57:55PM +0800, Murphy Zhou wrote: > > Hi, > > > > On Fri, Jul 16, 2021 at 12:07 AM Roman Gushchin wrote: > > > > > > On Thu, Jul 15, 2021 at 06:10:22PM +0800, Murphy Zhou wrote: > > > > Hi, > > > > > > > > #Looping generic/270 of xfstests[1] on pmem ramdisk with > > > > mount option: -o dax=always > > > > mkfs.xfs option: -f -b size=4096 -m reflink=0 > > > > can hit this panic now. > > > > > > > > #It's not reproducible on ext4. > > > > #It's not reproducible without dax=always. > > > > > > Hi Murphy! > > > > > > Thank you for the report! > > > > > > Can you, please, check if the following patch fixes the problem? > > > > No. Still the same panic. > > Hm, can you, please, double check this? It seems that the patch fixes the > problem for others (of course, it can be a different problem). > CCed you on the proper patch, just sent to the list. > > Otherwise, can you, please, say on which line of code the panic happens? > (using addr2line utility, for example) I experience the same problem that Murphy does, and I tracked it down to this chunk of inode_do_switch_wbs: /* * Count and transfer stats. Note that PAGECACHE_TAG_DIRTY points * to possibly dirty pages while PAGECACHE_TAG_WRITEBACK points to * pages actually under writeback. */ xas_for_each_marked(&xas, page, ULONG_MAX, PAGECACHE_TAG_DIRTY) { here >>>>>>>>>> if (PageDirty(page)) { dec_wb_stat(old_wb, WB_RECLAIMABLE); inc_wb_stat(new_wb, WB_RECLAIMABLE); } } I suspect that "page" is really a pfn to a pmem mapping and not a real struct page. --D > > Thank you!