From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25CA5C636CD for ; Fri, 16 Jul 2021 16:57:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 620BC61406 for ; Fri, 16 Jul 2021 16:57:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 620BC61406 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 717B08D00F4; Fri, 16 Jul 2021 12:57:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EE818D00EC; Fri, 16 Jul 2021 12:57:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 590078D00F4; Fri, 16 Jul 2021 12:57:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id 33B5B8D00EC for ; Fri, 16 Jul 2021 12:57:29 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EB2FB211D6 for ; Fri, 16 Jul 2021 16:57:27 +0000 (UTC) X-FDA: 78369056934.28.E79BD18 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf25.hostedemail.com (Postfix) with ESMTP id 557ADB00008E for ; Fri, 16 Jul 2021 16:57:27 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 490BB22B0B; Fri, 16 Jul 2021 16:57:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1626454644; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pxtS5Oudgec4rEwV+dOqiY1lV684Qv1oXIm2Do6XZfk=; b=hiFNsQSKFHqkGL/hKshmGNpZ5ZjicXOhEN/YtCsK88lEdh0idp4zsblQzEdVglXoiKYrdc p6thMlpmVE41Yxl0KhkO7rimQTZLZLGojpDdoiJ9mLxNfdVo5NksjmOqEElW2p9FcTO/dc rWtidrEtmI2xNoBjWEUHSwW4bb+gIwg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1626454644; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pxtS5Oudgec4rEwV+dOqiY1lV684Qv1oXIm2Do6XZfk=; b=s2c+8kdjfyur3gk7j7C5XyvF5JLV7mAnIM52+3ast7hDDkz7BxCQcxzHI0oLCb040Bok4p kH2nrdw58zKz0qCw== Received: from quack2.suse.cz (unknown [10.100.200.198]) by relay2.suse.de (Postfix) with ESMTP id 3725FA3BB9; Fri, 16 Jul 2021 16:57:24 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 12D411E0BF2; Fri, 16 Jul 2021 18:57:24 +0200 (CEST) Date: Fri, 16 Jul 2021 18:57:24 +0200 From: Jan Kara To: "Darrick J. Wong" Cc: Christoph Hellwig , Jan Kara , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Ted Tso , Dave Chinner , Matthew Wilcox , linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org Subject: Re: [PATCH 0/14 v10] fs: Hole punch vs page cache filling races Message-ID: <20210716165724.GH31920@quack2.suse.cz> References: <20210715133202.5975-1-jack@suse.cz> <20210716164311.GA22357@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210716164311.GA22357@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 557ADB00008E X-Stat-Signature: dna5pont1jt6671tcttjzmfa46n1fcny Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hiFNsQSK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=s2c+8kdj; dmarc=none; spf=pass (imf25.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz X-HE-Tag: 1626454647-984336 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 16-07-21 09:43:11, Darrick J. Wong wrote: > On Fri, Jul 16, 2021 at 07:02:19AM +0100, Christoph Hellwig wrote: > > On Thu, Jul 15, 2021 at 03:40:10PM +0200, Jan Kara wrote: > > > Hello, > > > > > > here is another version of my patches to address races between hole punching > > > and page cache filling functions for ext4 and other filesystems. The only > > > change since the last time is a small cleanup applied to changes of > > > filemap_fault() in patch 3/14 based on Christoph's & Darrick's feedback (thanks > > > guys!). Darrick, Christoph, is the patch fine now? > > > > Looks fine to me. > > Me too. Thanks guys! I've pushed the patches to linux-next. Honza -- Jan Kara SUSE Labs, CR