From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FD4BC636C9 for ; Fri, 16 Jul 2021 01:00:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7EE5A613E5 for ; Fri, 16 Jul 2021 01:00:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EE5A613E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A61A18D00F4; Thu, 15 Jul 2021 21:00:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A11AC8D00EC; Thu, 15 Jul 2021 21:00:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D92B8D00F4; Thu, 15 Jul 2021 21:00:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id 668EC8D00EC for ; Thu, 15 Jul 2021 21:00:40 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1E125824805A for ; Fri, 16 Jul 2021 01:00:39 +0000 (UTC) X-FDA: 78366645798.11.5F17E15 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf29.hostedemail.com (Postfix) with ESMTP id 1B85D9000260 for ; Fri, 16 Jul 2021 01:00:37 +0000 (UTC) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4GQt8f67j3z7tTX; Fri, 16 Jul 2021 08:56:02 +0800 (CST) Received: from dggema753-chm.china.huawei.com (10.1.198.195) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Fri, 16 Jul 2021 09:00:33 +0800 Received: from huawei.com (10.174.179.206) by dggema753-chm.china.huawei.com (10.1.198.195) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 16 Jul 2021 09:00:32 +0800 From: Bin Wang To: CC: , , , , , Subject: Re: Re: [PATCH] mm/hwpoison: dissolve error hugepages of file mapping Date: Fri, 16 Jul 2021 09:00:28 +0800 Message-ID: <20210716010028.1720-1-wangbin224@huawei.com> X-Mailer: git-send-email 2.29.2.windows.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.179.206] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggema753-chm.china.huawei.com (10.1.198.195) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1B85D9000260 X-Stat-Signature: 6qbef8ggcks5u4wo1djx3m3urn11zg34 Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of wangbin224@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangbin224@huawei.com; dmarc=pass (policy=none) header.from=huawei.com X-HE-Tag: 1626397237-389136 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Matthew, On Thu, 15 Jul 2021 at 16:22:40 +0100, Matthew Wilcox wrote: > How is that safe? If you're going to dissolve the huge page, you > need to figure out which subpage needs to have the HWPoison flag set. Thanks for your review. The p that we pass to the __page_handle_poison() is the error subpage. And we will move the HWPoison flag to subpage in the dissolve_free_huge_page(): if (PageHWPoison(head) && page !=3D head) { SetPageHWPoison(page); ClearPageHWPoison(head); } Thanks, Bin Wang