From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9409C07E96 for ; Tue, 13 Jul 2021 12:14:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8E3FF611CB for ; Tue, 13 Jul 2021 12:14:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E3FF611CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B63E56B008C; Tue, 13 Jul 2021 08:14:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AECA56B0095; Tue, 13 Jul 2021 08:14:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 966DD6B0096; Tue, 13 Jul 2021 08:14:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0138.hostedemail.com [216.40.44.138]) by kanga.kvack.org (Postfix) with ESMTP id 681DA6B008C for ; Tue, 13 Jul 2021 08:14:13 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 486EA180889D0 for ; Tue, 13 Jul 2021 12:14:12 +0000 (UTC) X-FDA: 78357456744.08.F13D3AC Received: from outbound-smtp48.blacknight.com (outbound-smtp48.blacknight.com [46.22.136.219]) by imf02.hostedemail.com (Postfix) with ESMTP id 46ABA700171E for ; Tue, 13 Jul 2021 12:14:11 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail06.blacknight.ie [81.17.255.152]) by outbound-smtp48.blacknight.com (Postfix) with ESMTPS id 960C8FAD82 for ; Tue, 13 Jul 2021 13:14:09 +0100 (IST) Received: (qmail 32481 invoked from network); 13 Jul 2021 12:14:09 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.17.255]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 13 Jul 2021 12:14:09 -0000 Date: Tue, 13 Jul 2021 13:14:08 +0100 From: Mel Gorman To: "Xu, Yanfei" Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/page_alloc: correct return value when failing at preparing Message-ID: <20210713121408.GC3809@techsingularity.net> References: <20210709102855.55058-1-yanfei.xu@windriver.com> <20210709122225.GZ3840@techsingularity.net> <98c83852-6745-bf57-2415-696edea89704@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <98c83852-6745-bf57-2415-696edea89704@windriver.com> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.219 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none X-Rspamd-Server: rspam02 X-Stat-Signature: h5pd88zo6bxtuqprrhkzdb5whmkiudnt X-Rspamd-Queue-Id: 46ABA700171E X-HE-Tag: 1626178451-733310 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 10, 2021 at 02:58:02PM +0800, Xu, Yanfei wrote: > > > On 7/9/21 8:22 PM, Mel Gorman wrote: > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > > > On Fri, Jul 09, 2021 at 06:28:54PM +0800, Yanfei Xu wrote: > > > If the array passed in is already partially populated, we should > > > return "nr_populated" even failing at preparing arguments stage. > > > > > > Signed-off-by: Yanfei Xu > > > > ff4b2b4014cb ("mm/page_alloc: correct return value of populated elements if bulk array is populated") > > > > This is a different return location from you posted. > You're right, I'll pick this up and stage it with a series of patches that should have gone in during the merge window but were too late. Thanks. -- Mel Gorman SUSE Labs