From: Jan Kara <jack@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org,
Michael Stapelberg <stapelberg+linux@google.com>,
Wu Fengguang <fengguang.wu@intel.com>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 0/5 v3] writeback: Fix bandwidth estimates
Date: Tue, 13 Jul 2021 12:46:38 +0200 [thread overview]
Message-ID: <20210713104638.GF12142@quack2.suse.cz> (raw)
In-Reply-To: <20210713103347.8364-1-jack@suse.cz>
Hello,
so this is really embarrasing but I have sent the version of patches without
the fixes :-|. I'm really sorry for the noise. I will send v4 now with
updated patch 5/5.
Honza
On Tue 13-07-21 12:36:24, Jan Kara wrote:
> Hello,
>
> Here is the third revision of the patch series to fix estimate of writeback
> throughput when device is not fully busy doing writeback. Michael Stapelberg
> has reported that such workload (e.g. generated by linking) tends to push
> estimated throughput down to 0 and as a result writeback on the device is
> practically stalled.
>
> The first three patches fix the reported issue, the remaining two patches
> are unrelated cleanups of problems I've noticed when reading the code.
>
> Andrew, can you please pick up the series? Thanks!
>
> Honza
> Changes since v2:
> * Rebased on top of 5.14-rc1
> * Fixed compilation failure introduced by patch 5/5
>
> Changes since v1:
> * Added comments to better explain the logic
> * Added Tested-by tag
> * Added WRITE_ONCE calls matching READ_ONCE in patch 5/5
>
>
> Previous versions:
> Link: http://lore.kernel.org/r/20210705161610.19406-1-jack@suse.cz # v1
> Link: http://lore.kernel.org/r/20210712165811.13163-1-jack@suse.cz # v2
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2021-07-13 10:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 10:36 Jan Kara
2021-07-13 10:36 ` [PATCH 1/5] writeback: Track number of inodes under writeback Jan Kara
2021-07-13 10:36 ` [PATCH 2/5] writeback: Reliably update bandwidth estimation Jan Kara
2021-07-13 10:36 ` [PATCH 3/5] writeback: Fix bandwidth estimate for spiky workload Jan Kara
2021-07-13 10:36 ` [PATCH 4/5] writeback: Rename domain_update_bandwidth() Jan Kara
2021-07-13 10:36 ` [PATCH 5/5] writeback: Use READ_ONCE for unlocked reads of writeback stats Jan Kara
2021-07-13 10:46 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713104638.GF12142@quack2.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=linux-mm@kvack.org \
--cc=stapelberg+linux@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox