From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87423C07E95 for ; Tue, 13 Jul 2021 10:32:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2E843611CB for ; Tue, 13 Jul 2021 10:32:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E843611CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 57FFD6B008C; Tue, 13 Jul 2021 06:32:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 530376B0095; Tue, 13 Jul 2021 06:32:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D0786B0096; Tue, 13 Jul 2021 06:32:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 120A96B008C for ; Tue, 13 Jul 2021 06:32:58 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1D7D0824559C for ; Tue, 13 Jul 2021 10:32:57 +0000 (UTC) X-FDA: 78357201594.17.E49B314 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf19.hostedemail.com (Postfix) with ESMTP id 985B5B0001A1 for ; Tue, 13 Jul 2021 10:32:56 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 7429C20090; Tue, 13 Jul 2021 10:32:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1626172375; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mjmj6Wy4hhWJ3pOZzvI2q+0g9MpMixGjLKYID6S9cZQ=; b=INglY8hi8pK11cnOkZfRNUpQ889w+ydYg5EobBF8+BL5nG1p0U/aFXYFLt+WwlADD1kD9f SStonvkGfJnRpuwq6VQDpkdo71i7XO93ViSX4lTCMDeb5jvDgRinG0/w0HO3PpCRXYqHC8 NYcArHBhKyAGbe8oLSzAKeBJ5ZzSMEo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1626172375; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mjmj6Wy4hhWJ3pOZzvI2q+0g9MpMixGjLKYID6S9cZQ=; b=BCl3q4l2sc0SSDMa5Z+a1brxSaXy2mYcsOsmagGVM1DeQhEH6bSOvwMRgtilQL2/O8nE1b MjqFSVjkpMJ2TODA== Received: from quack2.suse.cz (unknown [10.100.224.230]) by relay2.suse.de (Postfix) with ESMTP id 568DCA3B81; Tue, 13 Jul 2021 10:32:55 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 347461E0BBC; Tue, 13 Jul 2021 12:32:55 +0200 (CEST) Date: Tue, 13 Jul 2021 12:32:55 +0200 From: Jan Kara To: Andrew Morton Cc: linux-mm@kvack.org, Michael Stapelberg , Wu Fengguang , Jan Kara Subject: Re: [PATCH 0/5 v2] writeback: Fix bandwidth estimates Message-ID: <20210713103255.GE12142@quack2.suse.cz> References: <20210712165811.13163-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210712165811.13163-1-jack@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 985B5B0001A1 X-Stat-Signature: jbaqpcroi1cykqfydijj1h6sqxxorrc1 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=INglY8hi; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=BCl3q4l2; spf=pass (imf19.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none X-HE-Tag: 1626172376-723489 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Bah, please disregard this version. I did some last minute improvements to the last patch, forgot to test them and introduced compilation failure. Honza On Tue 13-07-21 12:24:39, Jan Kara wrote: > Hello, > > Here is a second revision of the patch series to fix estimate of writeback > throughput when device is not fully busy doing writeback. Michael Stapelberg > has reported that such workload (e.g. generated by linking) tends to push > estimated throughput down to 0 and as a result writeback on the device is > practically stalled. > > The first three patches fix the reported issue, the remaining two patches > are unrelated cleanups of problems I've noticed when reading the code. > > Andrew, can you please pick up the series? Thanks! > > Honza > Changes since v1: > * Added comments to better explain the logic > * Added Tested-by tag > > > Previous versions: > Link: http://lore.kernel.org/r/20210705161610.19406-1-jack@suse.cz # v1 -- Jan Kara SUSE Labs, CR