From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E67A0C07E95 for ; Tue, 13 Jul 2021 10:18:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 48DCA611CB for ; Tue, 13 Jul 2021 10:18:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48DCA611CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2D4646B008C; Tue, 13 Jul 2021 06:18:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2846D6B0095; Tue, 13 Jul 2021 06:18:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14CA66B0096; Tue, 13 Jul 2021 06:18:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id DE1296B008C for ; Tue, 13 Jul 2021 06:18:05 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DBBF4269D8 for ; Tue, 13 Jul 2021 10:18:04 +0000 (UTC) X-FDA: 78357164088.02.0EE7893 Received: from r3-21.sinamail.sina.com.cn (r3-21.sinamail.sina.com.cn [202.108.3.21]) by imf03.hostedemail.com (Postfix) with SMTP id 6855C30000B5 for ; Tue, 13 Jul 2021 10:18:02 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([1.24.238.74]) by sina.com (172.16.97.32) with ESMTP id 60ED68550002FB94; Tue, 13 Jul 2021 18:17:59 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 542348628896 From: Hillf Danton To: Desmond Cheong Zhi Xi Cc: Dmitry Vyukov , Mel Gorman , syzbot , linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] upstream test error: BUG: sleeping function called from invalid context in stack_depot_save Date: Tue, 13 Jul 2021 18:18:00 +0800 Message-Id: <20210713101800.2067-1-hdanton@sina.com> In-Reply-To: <49b84cde-647d-c4ef-4eac-d99376bb600a@gmail.com> References: <0000000000009e7f6405c60dbe3b@google.com> <20210703041256.212-1-hdanton@sina.com> MIME-Version: 1.0 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6855C30000B5 X-Stat-Signature: zkz1dtqaip7j5cgma19ubcs87njibxcm Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.21 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none X-HE-Tag: 1626171482-779489 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000228, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 13 Jul 2021 17:51:19 +0800 Desmond Cheong Zhi Xi wrote: > >I believe this particular bug should be fixed by Mel Gorman's patch that= =20 >was added into Andrew Morton's -mm tree (mm/page_alloc: Avoid page=20 >allocator recursion with pagesets.lock held): >https://lore.kernel.org/lkml/20210708081434.GV3840@techsingularity.net/ > >With the patch, we avoid recursing into stack_depot_save while holding=20 >onto the local lock. You are right. Different fixes of different tastes. Thanks for taking a look at it. Hillf