From: Hillf Danton <hdanton@sina.com>
To: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Mel Gorman <mgorman@techsingularity.net>,
syzbot <syzbot+e45919db2eab5e837646@syzkaller.appspotmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] upstream test error: BUG: sleeping function called from invalid context in stack_depot_save
Date: Tue, 13 Jul 2021 18:18:00 +0800 [thread overview]
Message-ID: <20210713101800.2067-1-hdanton@sina.com> (raw)
In-Reply-To: <49b84cde-647d-c4ef-4eac-d99376bb600a@gmail.com>
On Tue, 13 Jul 2021 17:51:19 +0800 Desmond Cheong Zhi Xi wrote:
>
>I believe this particular bug should be fixed by Mel Gorman's patch that
>was added into Andrew Morton's -mm tree (mm/page_alloc: Avoid page
>allocator recursion with pagesets.lock held):
>https://lore.kernel.org/lkml/20210708081434.GV3840@techsingularity.net/
>
>With the patch, we avoid recursing into stack_depot_save while holding
>onto the local lock.
You are right. Different fixes of different tastes.
Thanks for taking a look at it.
Hillf
next prev parent reply other threads:[~2021-07-13 10:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 11:00 syzbot
2021-07-01 11:10 ` Dmitry Vyukov
2021-07-03 4:12 ` Hillf Danton
2021-07-13 9:51 ` Desmond Cheong Zhi Xi
2021-07-13 10:18 ` Hillf Danton [this message]
2021-10-26 14:08 ` syzbot
2021-10-26 14:27 ` Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713101800.2067-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=desmondcheongzx@gmail.com \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=syzbot+e45919db2eab5e837646@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox