From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0823C07E99 for ; Fri, 9 Jul 2021 23:27:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3542E613C3 for ; Fri, 9 Jul 2021 23:27:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3542E613C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ED11A6B0073; Fri, 9 Jul 2021 19:27:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E812C6B0078; Fri, 9 Jul 2021 19:27:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D49D66B007B; Fri, 9 Jul 2021 19:27:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id A50556B0073 for ; Fri, 9 Jul 2021 19:27:46 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DC42F2CFF4 for ; Fri, 9 Jul 2021 23:27:45 +0000 (UTC) X-FDA: 78344638890.08.2DC0C4F Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf16.hostedemail.com (Postfix) with ESMTP id 6F394F00008E for ; Fri, 9 Jul 2021 23:27:45 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0B3C1613B2; Fri, 9 Jul 2021 23:27:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1625873264; bh=FPE3+BhCWyOoJj1St5NWSfhZrajf2+MELy947NPkjCA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ROq96No2ekMQXtnoNmbFZOIeTknxLfvKGyk3X33N4C4ej1+bHMjFXkjyHxVVuNlZP ySJAXi7W+6vkdrM/9uzHW0SDgxti583pfThbKzECsAybx32n9l2Blnzv3Fh3qyhh3B 34Kt75sRUCKqDUEQtwculdws9jxFO7YM6jSGFv1Y= Date: Fri, 9 Jul 2021 16:27:42 -0700 From: Andrew Morton To: Peter Collingbourne Cc: Catalin Marinas , Vincenzo Frascino , Dave Martin , Will Deacon , Andrea Arcangeli , Alistair Delva , Lokesh Gidra , William McVicker , Evgenii Stepanov , Mitch Phillips , Linux ARM , linux-mm@kvack.org, Andrey Konovalov , stable@vger.kernel.org Subject: Re: [PATCH v4 2/2] selftest: use mmap instead of posix_memalign to allocate memory Message-Id: <20210709162742.ee10cac911a6304e97ab1b5e@linux-foundation.org> In-Reply-To: <20210707184313.3697385-3-pcc@google.com> References: <20210707184313.3697385-1-pcc@google.com> <20210707184313.3697385-3-pcc@google.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ROq96No2; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: hr5b1jx4xo5xhbkworpt1t9t1dyiy5ac X-Rspamd-Queue-Id: 6F394F00008E X-Rspamd-Server: rspam01 X-HE-Tag: 1625873265-241177 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 7 Jul 2021 11:43:13 -0700 Peter Collingbourne wrote: > This test passes pointers obtained from anon_allocate_area to the > userfaultfd and mremap APIs. This causes a problem if the system > allocator returns tagged pointers because with the tagged address ABI > the kernel rejects tagged addresses passed to these APIs, which would > end up causing the test to fail. To make this test compatible with > such system allocators, stop using the system allocator to allocate > memory in anon_allocate_area, and instead just use mmap. Doesn't apply to current mainline. Can you please resync and redo? > Co-developed-by: Lokesh Gidra > Signed-off-by: Lokesh Gidra > Signed-off-by: Peter Collingbourne > Fixes: c47174fc362a ("userfaultfd: selftest") > Cc: # 5.4 This patch then won't apply to earlier kenrels, so please be prepared to help Greg resolve this.