linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Yang Huan <link@vivo.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kernel@vivo.com,
	syzbot+b07d8440edb5f8988eea@syzkaller.appspotmail.com,
	Wang Qing <wangqing@vivo.com>
Subject: Re: [PATCH] mm/page_alloc: fix alloc_pages_bulk/set_page_owner panic on irq disabled
Date: Fri, 9 Jul 2021 15:33:16 -0700	[thread overview]
Message-ID: <20210709153316.a81214a453920dbcc2714ae6@linux-foundation.org> (raw)
In-Reply-To: <20210709090600.9804-1-link@vivo.com>

On Fri,  9 Jul 2021 17:05:59 +0800 Yang Huan <link@vivo.com> wrote:

> The problem is caused by set_page_owner alloc memory to save stack with
> GFP_KERNEL in local_riq disabled.
> So, we just can't assume that alloc flags should be same with new page,
> let's split it. But in most situation, same is ok, in alloc_pages_bulk,
> input GFP_ATOMIC when prep_new_pages

Please more fully describe the bug which is being fixed.  A link to the
sysbot report would be helpful.  I assume there was a stack backtrace
available?  Seeing the will help others to understand the bug.

And if you are able to identify the patch which introduced the bug, a
Fixes: tag would be helpful as well.

Thanks.



  reply	other threads:[~2021-07-09 22:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09  9:05 Yang Huan
2021-07-09 22:33 ` Andrew Morton [this message]
2021-07-12  2:16   ` 杨欢
     [not found] <AJMANAB3D*gl9w79jvWlvaqZ.3.1626053734064.Hmail.link@vivo.com>
2024-04-26  2:59 ` Huan Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210709153316.a81214a453920dbcc2714ae6@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=kernel@vivo.com \
    --cc=link@vivo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=syzbot+b07d8440edb5f8988eea@syzkaller.appspotmail.com \
    --cc=wangqing@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox