From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BCABC07E99 for ; Thu, 8 Jul 2021 12:59:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EA57C61422 for ; Thu, 8 Jul 2021 12:59:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA57C61422 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DF6BB6B005D; Thu, 8 Jul 2021 08:59:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCDFB6B006C; Thu, 8 Jul 2021 08:59:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C96206B0070; Thu, 8 Jul 2021 08:59:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id A69286B005D for ; Thu, 8 Jul 2021 08:59:28 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EEEF4824C43B for ; Thu, 8 Jul 2021 12:59:27 +0000 (UTC) X-FDA: 78339426774.24.D1645AA Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf06.hostedemail.com (Postfix) with ESMTP id 06686801CFAE for ; Thu, 8 Jul 2021 12:59:26 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 6F1DC61481; Thu, 8 Jul 2021 12:59:22 +0000 (UTC) Date: Thu, 8 Jul 2021 13:59:19 +0100 From: Catalin Marinas To: Peter Collingbourne Cc: Vincenzo Frascino , Dave Martin , Will Deacon , Andrew Morton , Andrea Arcangeli , Alistair Delva , Lokesh Gidra , William McVicker , Evgenii Stepanov , Mitch Phillips , Linux ARM , linux-mm@kvack.org, Andrey Konovalov , stable@vger.kernel.org Subject: Re: [PATCH v4 2/2] selftest: use mmap instead of posix_memalign to allocate memory Message-ID: <20210708125919.GB9966@arm.com> References: <20210707184313.3697385-1-pcc@google.com> <20210707184313.3697385-3-pcc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210707184313.3697385-3-pcc@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf06.hostedemail.com: domain of cmarinas@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-Rspamd-Server: rspam05 X-Stat-Signature: s316jiu4q345g5t759caincdje9gzzp4 X-Rspamd-Queue-Id: 06686801CFAE X-Rspam-User: nil X-HE-Tag: 1625749166-461710 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 07, 2021 at 11:43:13AM -0700, Peter Collingbourne wrote: > This test passes pointers obtained from anon_allocate_area to the > userfaultfd and mremap APIs. This causes a problem if the system > allocator returns tagged pointers because with the tagged address ABI > the kernel rejects tagged addresses passed to these APIs, which would > end up causing the test to fail. To make this test compatible with > such system allocators, stop using the system allocator to allocate > memory in anon_allocate_area, and instead just use mmap. > > Co-developed-by: Lokesh Gidra > Signed-off-by: Lokesh Gidra > Signed-off-by: Peter Collingbourne > Fixes: c47174fc362a ("userfaultfd: selftest") > Cc: # 5.4 > Link: https://linux-review.googlesource.com/id/Icac91064fcd923f77a83e8e133f8631c5b8fc241 Reviewed-by: Catalin Marinas