From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F28E5C07E96 for ; Tue, 6 Jul 2021 06:18:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 799976198E for ; Tue, 6 Jul 2021 06:18:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 799976198E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 096C46B005D; Tue, 6 Jul 2021 02:18:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 047516B006C; Tue, 6 Jul 2021 02:18:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E29AD6B0070; Tue, 6 Jul 2021 02:18:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BEB836B005D for ; Tue, 6 Jul 2021 02:18:05 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 61B1B22ADC for ; Tue, 6 Jul 2021 06:18:04 +0000 (UTC) X-FDA: 78331157688.24.17EF7C2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id AB2E3500377C for ; Tue, 6 Jul 2021 06:18:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625552283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+ru+U+Oc29lc1AvLWBgfwb6rzCmttJjIzNLEviVazlo=; b=YljN1NHgIO4KR1+H5jrureqyjqHE8ZKTRM6+vH91ZD8FxuZzohIspO4rZJYu9dh8Lqd5Gm 792ve74Xxuv62QtFA9+1w4IVUF9GXRp+IAk2A3bC/ZJV0rFABv55j+iwAL9zvgsrac7FPf vhD8wLWkNBwWtDcNgWM7JT+emRleToo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-532-M9hHX5HRMdijwX-T4bPiOQ-1; Tue, 06 Jul 2021 02:18:01 -0400 X-MC-Unique: M9hHX5HRMdijwX-T4bPiOQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 71C94801B1C; Tue, 6 Jul 2021 06:18:00 +0000 (UTC) Received: from gshan.redhat.com (vpn2-54-119.bne.redhat.com [10.64.54.119]) by smtp.corp.redhat.com (Postfix) with ESMTP id A17102C00F; Tue, 6 Jul 2021 06:17:57 +0000 (UTC) From: Gavin Shan To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, anshuman.khandual@arm.com, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, shan.gavin@gmail.com, chuhu@redhat.com Subject: [PATCH 00/12] mm/debug_vm_pgtable: Enhancements Date: Tue, 6 Jul 2021 14:17:36 +0800 Message-Id: <20210706061748.161258-1-gshan@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AB2E3500377C X-Stat-Signature: aaenfx1y1tod9pw6huooadgkqk8ggami Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YljN1NHg; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf01.hostedemail.com: domain of gshan@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=gshan@redhat.com X-HE-Tag: 1625552283-394782 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: There are couple of issues with current implementations and this series tries to resolve the issues: (a) All needed information are scattered in variables, passed to variou= s test functions. The code is organized in pretty much relaxed fashio= n. (b) The page isn't allocated from buddy during page table entry modifyi= ng tests. The page can be invalid, conflicting to the implementations of set_{pud, pmd, pte}_at() on ARM64. The target page is accessed so that the iCache can be flushed when execution permission is give= n on ARM64. Besides, the target page can be unmapped and access to it causes kernel crash. "struct vm_pgtable_debug" is introduced to address issue (a). For issue (b), the used page is allocated from buddy in page table entry modifying tests. The corresponding tets will be skipped if we fail to allocate the (huge) page. For other test cases, the original page around to kernel symbol (@start_kernel) is still used. The patches are organized as below. PATCH[2-10] could be combined to one patch, but it will make the review harder: PATCH[1] introduces "struct vm_pgtable_debug" as place holder of all needed information. With it, the old and new implementation can coexist. PATCH[2-10] uses "struct vm_pgtable_debug" in various test functions. PATCH[11] removes the old implementation. PATCH[12] fixes the issue of corrupted page flag for ARM64 Gavin Shan (12): mm/debug_vm_pgtable: Introduce struct vm_pgtable_debug mm/debug_vm_pgtable: Use struct vm_pgtable_debug in basic tests mm/debug_vm_pgtable: Use struct vm_pgtable_debug in leaf and savewrite tests mm/debug_vm_pgtable: Use struct vm_pgtable_debug in protnone and devmap tests mm/vm_debug_pgtable: Use struct vm_pgtable_debug in soft_dirty and swap tests mm/debug_vm_pgtable: Use struct vm_pgtable_debug in migration and thp tests mm/debug_vm_pgtable: Use struct vm_pgtable_debug in PTE modifying tests mm/debug_vm_pgtable: Use struct vm_pgtable_debug in PMD modifying tests mm/vm_debug_pgtable: Use struct vm_pgtable_debug in PUD modifying tests mm/debug_vm_pgtable: Use struct vm_pgtable_debug in PGD and P4D modifying tests mm/debug_vm_pgtable: Remove unused code mm/debug_vm_pgtable: Fix corrupted page flag mm/debug_vm_pgtable.c | 875 ++++++++++++++++++++++++------------------ 1 file changed, 500 insertions(+), 375 deletions(-) --=20 2.23.0