From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21ECDC07E99 for ; Mon, 5 Jul 2021 15:43:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ADD0061968 for ; Mon, 5 Jul 2021 15:43:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADD0061968 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 366776B0080; Mon, 5 Jul 2021 11:43:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3160E6B0082; Mon, 5 Jul 2021 11:43:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C75F6B0083; Mon, 5 Jul 2021 11:43:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id ED56E6B0080 for ; Mon, 5 Jul 2021 11:43:28 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7003520318 for ; Mon, 5 Jul 2021 15:43:28 +0000 (UTC) X-FDA: 78328953696.25.DC94090 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by imf15.hostedemail.com (Postfix) with ESMTP id 35914D00009C for ; Mon, 5 Jul 2021 15:43:28 +0000 (UTC) Received: by mail-lj1-f169.google.com with SMTP id q4so25158786ljp.13 for ; Mon, 05 Jul 2021 08:43:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2I5OKuYkuayNi3jHus1jYSAwzTCOsFOu/KrA6yZe8wQ=; b=UwdjJmRC2FPpEevnGhbuOw8NfdenTTA5NuAYSOYRBGGZyzkiNBu9flp8dnM/L3c+7W tn44osMbt1E7x3ikTawc2+hef7gL+U0mhsA4UTCqnoQMRSZSJfion5EWCzJVEVj2k/Iv +3yytyfgzON+MSikkOdTdFoYMfvzYujBJZwKRmlPlxxZkB7NpM+FSmnWszX/x9vt2wSJ Qr1h/JV9JckqEHatGNs8Urm5Co6StHOQLoNIuJ99GMcveIjICpNaNln6i5BX60p6mdkv ID/MRdwNvSiqiVFPb3TcAft6yMTIRAza4cuVmetNvDP2ewWM8IJ4TBDklknriN4s57Xa SLZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2I5OKuYkuayNi3jHus1jYSAwzTCOsFOu/KrA6yZe8wQ=; b=hdOhkeoU2oBvXTMszH7j8NjpSabL7g32LWVCoe6OKh1jNKMb+1YoHY15ZYRDDKAPC1 uMNBjo+zbvudRqtyqWpGm48M+vsTjbElV6r+0xBhRJaRQE42VF6e2T/yBTpwtxUAPbgH zzbafZ1iSTjDlmi5f59ykNnRkP0NZo+lw9tRLU5u6ROGBmy0xncGLHKvz/PGoWdVxy8R OXoHZwThyiHdlrAhS96rZ3Bx5xFD7iKZsG7thDLaI3jqebCzvKClioCqSmfHy18+M0Hm sF06cNMuKtsfO4lrdvueGNIk0CgtX64f9hYI8faFnD/hMGRy1LI6eOsKlVsYt3+/yuVC LsRw== X-Gm-Message-State: AOAM5300yOHI1xu2FVd9VxpEePweVkW2j2nSvzlRizDH5aAp7hLPaWL1 6Tt5Eb73Rim0ndpaRxq+Vp0= X-Google-Smtp-Source: ABdhPJx231U6ypU1O4mZwtPAtUZFzUu5GDqICu5JX6qZcz3iV7wQ9IusC0/Q9rboDx05O31nh/kvdQ== X-Received: by 2002:a05:651c:1689:: with SMTP id bd9mr11250046ljb.373.1625499806661; Mon, 05 Jul 2021 08:43:26 -0700 (PDT) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id i130sm1112860lfd.304.2021.07.05.08.43.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jul 2021 08:43:26 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 5 Jul 2021 17:43:24 +0200 To: Matthew Wilcox Cc: "Uladzislau Rezki (Sony)" , Andrew Morton , linux-mm@kvack.org, LKML , Mel Gorman , Christoph Hellwig , Nicholas Piggin , Hillf Danton , Michal Hocko , Oleksiy Avramchenko , Steven Rostedt Subject: Re: [PATCH] mm/vmalloc: Use batched page requests in bulk-allocator Message-ID: <20210705154324.GA41292@pc638.lan> References: <20210705145547.41206-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=UwdjJmRC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=urezki@gmail.com X-Rspamd-Server: rspam02 X-Stat-Signature: kkhga5dswsjw7g5ndqagtn9jrd93w7st X-Rspamd-Queue-Id: 35914D00009C X-HE-Tag: 1625499808-218394 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Mon, Jul 05, 2021 at 04:55:47PM +0200, Uladzislau Rezki (Sony) wrote: > > + if (gfpflags_allow_blocking(gfp)) > > + cond_resched(); > > How does one call vmalloc() with gfp flags that _don't_ allow blocking? > They have to allow a GFP_KERNEL allocation of the page tables. > So I think this should be an unconditional cond_resched(). Historically it is there. I decided to align with below code. But i agree vmalloc is sleepable anyway, so blocking is supposed. OK, i will respin and send out two patches. -- Vlad Rezki