From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46458C11F66 for ; Thu, 1 Jul 2021 01:53:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0B2F761468 for ; Thu, 1 Jul 2021 01:53:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B2F761468 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8AEFC8D0242; Wed, 30 Jun 2021 21:53:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 886908D0236; Wed, 30 Jun 2021 21:53:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74D358D0242; Wed, 30 Jun 2021 21:53:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 50F188D0236 for ; Wed, 30 Jun 2021 21:53:09 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2B62C250CF for ; Thu, 1 Jul 2021 01:53:09 +0000 (UTC) X-FDA: 78312346098.35.C614FA3 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf04.hostedemail.com (Postfix) with ESMTP id DCD935000098 for ; Thu, 1 Jul 2021 01:53:08 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id BEFF36105A; Thu, 1 Jul 2021 01:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1625104388; bh=qRlUoZqlfmnGmyW2QHh7SLhKVxgwA/JqiVj3PKTOkRg=; h=Date:From:To:Subject:In-Reply-To:From; b=t0sy5+tBcrORpQOFMKI85BgpTEmT4w3nYcK/PGkSiQ/h8IBvJG+b0a/ggAa6Sz7iL 96AtpS+L1YVWyHk2+cQzp/IstcdxweoEOSchXgiym/HI6za7Noha2VJSjhJte2Wmr3 SaTO8A3AXfFyZ6hOxVmS7HSKtXfeYMBvhg1kkPY4= Date: Wed, 30 Jun 2021 18:53:07 -0700 From: Andrew Morton To: akpm@linux-foundation.org, huyue2@yulong.com, linux-mm@kvack.org, minchan@kernel.org, mm-commits@vger.kernel.org, senozhatsky@chromium.org, sergey.senozhatsky@gmail.com, torvalds@linux-foundation.org Subject: [patch 111/192] zram: move backing_dev under macro CONFIG_ZRAM_WRITEBACK Message-ID: <20210701015307.EtNdJcvyZ%akpm@linux-foundation.org> In-Reply-To: <20210630184624.9ca1937310b0dd5ce66b30e7@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: DCD935000098 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=t0sy5+tB; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: kmczgnjqxgjbou4yjmt6ikx5dfy445ad X-HE-Tag: 1625104388-649178 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Yue Hu Subject: zram: move backing_dev under macro CONFIG_ZRAM_WRITEBACK backing_dev is never used when not enable CONFIG_ZRAM_WRITEBACK and it's introduced from writeback feature. So it's needless also affect readability in that case. Link: https://lkml.kernel.org/r/20210521060544.2385-1-zbestahu@gmail.com Signed-off-by: Yue Hu Reviewed-by: Sergey Senozhatsky Acked-by: Minchan Kim Cc: Sergey Senozhatsky Signed-off-by: Andrew Morton --- drivers/block/zram/zram_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/block/zram/zram_drv.h~zram-move-backing_dev-under-macro-config_zram_writeback +++ a/drivers/block/zram/zram_drv.h @@ -113,8 +113,8 @@ struct zram { * zram is claimed so open request will be failed */ bool claim; /* Protected by bdev->bd_mutex */ - struct file *backing_dev; #ifdef CONFIG_ZRAM_WRITEBACK + struct file *backing_dev; spinlock_t wb_limit_lock; bool wb_limit_enable; u64 bd_wb_limit; _