From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E565C11F64 for ; Mon, 28 Jun 2021 23:00:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A7C2A61D01 for ; Mon, 28 Jun 2021 23:00:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7C2A61D01 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BB27E8D0071; Mon, 28 Jun 2021 19:00:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B89B58D0016; Mon, 28 Jun 2021 19:00:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2CF38D0071; Mon, 28 Jun 2021 19:00:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id 8029C8D0016 for ; Mon, 28 Jun 2021 19:00:08 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 704AA1809B0AD for ; Mon, 28 Jun 2021 23:00:08 +0000 (UTC) X-FDA: 78304652496.26.E832A95 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf17.hostedemail.com (Postfix) with ESMTP id E38D44202A0E for ; Mon, 28 Jun 2021 23:00:07 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 24A7461CF8; Mon, 28 Jun 2021 23:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1624921205; bh=ZsWXc9FKF9jThbjc7um9yI6tcNaF+KHjq8t5fFUWmrc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=l1Zz2/tgvo1jyws/qAAFhigF8Ji8mVZa67ZBwc7L4Z/eMFlUg6ea9eZPnW14/lGO/ T40NIIeTtGjzYibo4b1ahhUd+nquuolDPjU/RqK60dldHkZHScuun1Wm8ptLYW9hyk xeb2ycRQWVmPW/4xxPSW6iZbPhbacFkO4KvTFq28= Date: Mon, 28 Jun 2021 16:00:04 -0700 From: Andrew Morton To: Uladzislau Rezki Cc: Christoph Hellwig , Mel Gorman , linux-mm@kvack.org, LKML , Matthew Wilcox , Nicholas Piggin , Hillf Danton , Michal Hocko , Oleksiy Avramchenko , Steven Rostedt Subject: Re: [PATCH 2/3] mm/vmalloc: Switch to bulk allocator in __vmalloc_area_node() Message-Id: <20210628160004.ad39038af33e4be17df0d7f6@linux-foundation.org> In-Reply-To: <20210519210750.GA5615@pc638.lan> References: <20210516202056.2120-1-urezki@gmail.com> <20210516202056.2120-3-urezki@gmail.com> <20210519143900.GA2262@pc638.lan> <20210519155630.GD3672@suse.de> <20210519195214.GA2343@pc638.lan> <20210519210750.GA5615@pc638.lan> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="l1Zz2/tg"; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E38D44202A0E X-Stat-Signature: gh1symjcy4s5sugdeft5udjt6kc6dqp3 X-HE-Tag: 1624921207-206793 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 19 May 2021 23:07:50 +0200 Uladzislau Rezki wrote: > > Basically a single-page allocator is more permissive so it is a higher > > chance to success. Therefore a fallback to it makes sense. > > > Hello, Christoph. > > See below the patch. Does it sound good for you? It is about moving > page allocation part into separate function: Please just send over a patch which addresses this and Christoph's other review comments. I don't think the discussion with Mel against this patch identified any needed changes, so I'll send this series to Linus.