From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45BF3C2B9F4 for ; Mon, 28 Jun 2021 12:49:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D4F3D61954 for ; Mon, 28 Jun 2021 12:49:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4F3D61954 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2429C8D0035; Mon, 28 Jun 2021 08:49:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 219508D0016; Mon, 28 Jun 2021 08:49:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BB188D0035; Mon, 28 Jun 2021 08:49:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0084.hostedemail.com [216.40.44.84]) by kanga.kvack.org (Postfix) with ESMTP id D394F8D0016 for ; Mon, 28 Jun 2021 08:49:07 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CA0CE180ABF60 for ; Mon, 28 Jun 2021 12:49:07 +0000 (UTC) X-FDA: 78303112734.10.940E6EA Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf26.hostedemail.com (Postfix) with ESMTP id 8D9C140002FA for ; Mon, 28 Jun 2021 12:49:07 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id a15so24588997lfr.6 for ; Mon, 28 Jun 2021 05:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9YjsxWTv0kQVrcHNY3VGvdRvBxzuUPPPSmtpb6NmJ50=; b=YNZnxgyvRhhJNb3vzFToay8JPWo3nncmo9cy1cuzW1SihA1UiLkcTzuPnrj/dmzP10 wAH2RSJ0Zj9dWhI/N6Y1GE4oM69cwn1xYNddwr0OPJlrujrDWLxrpk8TaHLzV95Qwq0B 5jDonBN6O7j45FbnFnZVZVKouSsweskeWu8G3F+Sz79ognFxAcdgiBg0SSXOF5qfaRgv VWdp60u1N9fKrX/ACQBvzCNIGJ5RSGV2LR2aEuFNKPJ8A+Dw2MMCNwCtCnqozaDK0aBS 3nunYq4hfSF2BrvP0XAayvthPFo3UyoNMsLxGP3YpuB4I0oLs9CshX+kdvP7ny8oKK2U 81vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9YjsxWTv0kQVrcHNY3VGvdRvBxzuUPPPSmtpb6NmJ50=; b=ueIWsNczVodyfK4apVweHWisTGFi4ufMOH73uiaUgkmZEXifA0W3h0lHDp0B5tUJWO u5hVMNCwM9J1Rnahvm4ujQ6a6zOV8oemPPyf3BLEQ4THqnQztsJGKulFgj+KPNWuF9ho KxmvZpOOMRRRUf7wb/caPJil+7bDqeykuvyO6N8Y1IGW+gSp0MXU2Tn/HjXzH+0IoB0n WQThg9CKtNCsoK+gJBPwPwGaRw3s9KUSG5mkTG7pcYQ5zt2onSGAfVBBT8VlgeXlr57K NH/iaq2uoycNRopjzUbN87/RomTOS0+cyGLRk8+E4lNvJZ5f63cGq8gLmIMD5y3rKcHC txbQ== X-Gm-Message-State: AOAM5331MYVTtYd3rhcfA0hQnHk6WSiZ8+Ddf736WFcoRvH36bi9ZoCv Wd1cV3DKBsMOYBulHmfB2Vs+Hg== X-Google-Smtp-Source: ABdhPJy5doUOoTBWEbaiUSSG4ylkr1yyjwbZH0tbB92CloI0zoeov7u71L3C4nVfRk5umkBFFcSPWw== X-Received: by 2002:ac2:4211:: with SMTP id y17mr17641025lfh.607.1624884546282; Mon, 28 Jun 2021 05:49:06 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id j2sm1216847lfb.212.2021.06.28.05.49.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 05:49:05 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 3A79010280E; Mon, 28 Jun 2021 15:49:05 +0300 (+03) Date: Mon, 28 Jun 2021 15:49:05 +0300 From: "Kirill A. Shutemov" To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , William Kucharski , Christoph Hellwig Subject: Re: [PATCH v12 32/33] fs/netfs: Add folio fscache functions Message-ID: <20210628124905.5ndzvzltnuycrf2k@box.shutemov.name> References: <20210622114118.3388190-1-willy@infradead.org> <20210622114118.3388190-33-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622114118.3388190-33-willy@infradead.org> Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=YNZnxgyv; spf=none (imf26.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.50) smtp.mailfrom=kirill@shutemov.name; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8D9C140002FA X-Stat-Signature: 1b5xoy4ntwxestypde66nrqwgh38k5qt X-HE-Tag: 1624884547-869825 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 22, 2021 at 12:41:17PM +0100, Matthew Wilcox (Oracle) wrote: > Match the page writeback functions by adding > folio_start_fscache(), folio_end_fscache(), folio_wait_fscache() and > folio_wait_fscache_killable(). Remove set_page_private_2(). Also rewrite > the kernel-doc to describe when to use the function rather than what the > function does, and include the kernel-doc in the appropriate rst file. > Saves 31 bytes of text in netfs_rreq_unlock() due to set_page_fscache() > calling page_folio() once instead of three times. > > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Vlastimil Babka > Reviewed-by: William Kucharski > Reviewed-by: Christoph Hellwig Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov