From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D537CC2B9F4 for ; Mon, 28 Jun 2021 12:35:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5845861C6A for ; Mon, 28 Jun 2021 12:35:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5845861C6A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 930798D0030; Mon, 28 Jun 2021 08:35:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E0A18D0016; Mon, 28 Jun 2021 08:35:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 781318D0030; Mon, 28 Jun 2021 08:35:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id 4639D8D0016 for ; Mon, 28 Jun 2021 08:35:11 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3BF30180CA1AD for ; Mon, 28 Jun 2021 12:35:11 +0000 (UTC) X-FDA: 78303077622.23.99A99AB Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by imf24.hostedemail.com (Postfix) with ESMTP id E5C98A001A67 for ; Mon, 28 Jun 2021 12:35:10 +0000 (UTC) Received: by mail-lj1-f181.google.com with SMTP id u25so9848489ljj.11 for ; Mon, 28 Jun 2021 05:35:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=b4cWCmiDmq2f7gAA0xos0gUPIaEGtZleOLH3TntBbjU=; b=hNXeh7nZH0tYje8UHbWOl9pCANcbvnisVkD3HC3/SSju9adfXxY09laZVxCXe2rBer woHbUYrAB5t48FfkqlO5flfTsYpteDH58VduuLVfKAFdVnQoGhT794hGVvEXuicmBu4H HgR7BMC5ULaF3RdDM0YoC1gG8ESOJba1pvcNKZoI0KczsoZFqQDAOxZ5NaP7QgQRSNfB LDVBTZpKO6o8TDPow9pPSYxxXqHtjjBmc+OJ5SLF2LVunV5GDw5kCoL1gUgBK3XMyKcA rShKFeL+hWfr0t7M0+BoSjzFh5At11CoOUBpn5SWgXL4L5AfuhBTzWyAzfu9xSHBuWCA 8EBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=b4cWCmiDmq2f7gAA0xos0gUPIaEGtZleOLH3TntBbjU=; b=tJvCpOn4yjX4KLzc8R9v5DWoInvW1sNu3kBU69+abZX9Rq1qtckg+qYSKbSrEiag/p 4lGTTRpSNMzYyNCi5ZLv0OkuKpHN/hP1rtNyjCx6iolsnezWpjYgZSLk1+TceatTwqMl Naxn7NNISiawLBJ2RQWyJWw3ZyJuYdLODCG2GhVvQHyw7M0iB+BxtdVymQRnd/64jp/C PS/Z2zqRczaqn1EGVfin/f4WuYaxPHDzjKIVO5qjAPJHCnyHkpGNnVccglFtirDS10Mh No/WGlaHhTfxEQUa5Rbqmb3Z/bRW6/iu7Yedf5E1InHw8QGMjweo86kqoyrjiSGFcSvR ALfg== X-Gm-Message-State: AOAM530j9N7kmqXsm33VcX+2O+z8NtbM4RBPxknqs7NMgPZdjGQ8H4dB v8p9spzacFEl7QpbIdvvU+8lPg== X-Google-Smtp-Source: ABdhPJyGtljRlnH949VrIi90DObhw8FvDOwb37VkxKqAmbo2VV7b/5j6NJ3N9DkrAUy1cQrcKrs1HQ== X-Received: by 2002:a2e:890d:: with SMTP id d13mr19944241lji.327.1624883709620; Mon, 28 Jun 2021 05:35:09 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id n20sm1302356lfu.206.2021.06.28.05.35.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 05:35:09 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 69CA910280E; Mon, 28 Jun 2021 15:35:08 +0300 (+03) Date: Mon, 28 Jun 2021 15:35:08 +0300 From: "Kirill A. Shutemov" To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v12 01/33] mm: Convert get_page_unless_zero() to return bool Message-ID: <20210628123508.bckqc72hrnpuyip4@box.shutemov.name> References: <20210622114118.3388190-1-willy@infradead.org> <20210622114118.3388190-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622114118.3388190-2-willy@infradead.org> Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=hNXeh7nZ; dmarc=none; spf=none (imf24.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.208.181) smtp.mailfrom=kirill@shutemov.name X-Rspamd-Server: rspam02 X-Stat-Signature: qy5iiymkd9hcqamj8nmg9goiph9pwmp8 X-Rspamd-Queue-Id: E5C98A001A67 X-HE-Tag: 1624883710-177369 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 22, 2021 at 12:40:46PM +0100, Matthew Wilcox (Oracle) wrote: > atomic_add_unless() returns bool, so remove the widening casts to int > in page_ref_add_unless() and get_page_unless_zero(). This causes gcc > to produce slightly larger code in isolate_migratepages_block(), but > it's not clear that it's worse code. Net +19 bytes of text. > > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov