From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DF49C2B9F4 for ; Fri, 25 Jun 2021 05:02:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E05F96140E for ; Fri, 25 Jun 2021 05:02:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E05F96140E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fromorbit.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DDB7B6B005D; Fri, 25 Jun 2021 01:02:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8B5A8D0001; Fri, 25 Jun 2021 01:02:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C54136B0070; Fri, 25 Jun 2021 01:02:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id 93EE36B005D for ; Fri, 25 Jun 2021 01:02:44 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C2E402311B for ; Fri, 25 Jun 2021 05:02:44 +0000 (UTC) X-FDA: 78291051048.16.0106BF2 Received: from mail109.syd.optusnet.com.au (mail109.syd.optusnet.com.au [211.29.132.80]) by imf29.hostedemail.com (Postfix) with ESMTP id 1AFF9F2 for ; Fri, 25 Jun 2021 05:02:44 +0000 (UTC) Received: from dread.disaster.area (pa49-179-138-183.pa.nsw.optusnet.com.au [49.179.138.183]) by mail109.syd.optusnet.com.au (Postfix) with ESMTPS id 50B3E684AB; Fri, 25 Jun 2021 15:02:41 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1lwdzC-00Giwn-Lw; Fri, 25 Jun 2021 15:02:38 +1000 Date: Fri, 25 Jun 2021 15:02:38 +1000 From: Dave Chinner To: Matthew Wilcox Cc: linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm: Add kvrealloc() Message-ID: <20210625050238.GA664593@dread.disaster.area> References: <20210625023029.1472466-1-david@fromorbit.com> <20210625023029.1472466-2-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=Tu+Yewfh c=1 sm=1 tr=0 a=MnllW2CieawZLw/OcHE/Ng==:117 a=MnllW2CieawZLw/OcHE/Ng==:17 a=kj9zAlcOel0A:10 a=r6YtysWOX24A:10 a=7-415B0cAAAA:8 a=k1IS4gJYJm307DBGtdEA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Authentication-Results: imf29.hostedemail.com; dkim=none; spf=none (imf29.hostedemail.com: domain of david@fromorbit.com has no SPF policy when checking 211.29.132.80) smtp.mailfrom=david@fromorbit.com; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1AFF9F2 X-Stat-Signature: a5wos3ej487anitx9i1nt7nho98ebgi9 X-HE-Tag: 1624597364-363765 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 25, 2021 at 04:54:11AM +0100, Matthew Wilcox wrote: > On Fri, Jun 25, 2021 at 12:30:27PM +1000, Dave Chinner wrote: > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index 8ae31622deef..34d88ff00f31 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -830,6 +830,20 @@ static inline void *kvcalloc(size_t n, size_t size, gfp_t flags) > > extern void kvfree(const void *addr); > > extern void kvfree_sensitive(const void *addr, size_t len); > > > > +static inline void *kvrealloc(void *p, size_t oldsize, size_t newsize, > > + gfp_t flags) > > +{ > > + void *newp; > > + > > + if (oldsize >= newsize) > > + return p; > > + newp = kvmalloc(newsize, flags); > > + memcpy(newp, p, oldsize); > > + kvfree(p); > > + return newp; > > +} > > Why make this an inline function instead of putting it in mm/util.c? Not fussed, I can do that. Cheers, Dave. -- Dave Chinner david@fromorbit.com