From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6C49C48BC2 for ; Fri, 25 Jun 2021 05:53:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7266761424 for ; Fri, 25 Jun 2021 05:53:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7266761424 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6167A6B0036; Fri, 25 Jun 2021 01:53:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59F806B005D; Fri, 25 Jun 2021 01:53:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F2D66B006C; Fri, 25 Jun 2021 01:53:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0225.hostedemail.com [216.40.44.225]) by kanga.kvack.org (Postfix) with ESMTP id F37416B0036 for ; Fri, 25 Jun 2021 01:53:24 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 16DDF801BDC2 for ; Fri, 25 Jun 2021 05:53:25 +0000 (UTC) X-FDA: 78291178770.12.3AD6763 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id B0371376 for ; Fri, 25 Jun 2021 05:53:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624600404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=42YjOqbIy9DlhDO/iMrmfgYXOpw7YyaWJVvHtjTwroY=; b=iJY0flUQF+LTRn5fh9KHDToYf3l4eIuts7pXkWpOtYbVXzoxfu0Z0bcRsgUiIEqVjAIaZZ RaRzreDpHwf5+1sH6sF1QeybBIGMGGyG3pHZFGYFl7fd78k+PH1hur3fPwRj7ukJKGEuwy 4M+4BxX+SJW4s/OhDi844X8krTvZFaw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-122-V8q5Q9OfOO2GamBXZ4kAgg-1; Fri, 25 Jun 2021 01:53:20 -0400 X-MC-Unique: V8q5Q9OfOO2GamBXZ4kAgg-1 Received: by mail-wr1-f72.google.com with SMTP id u16-20020a5d51500000b029011a6a17cf62so3052289wrt.13 for ; Thu, 24 Jun 2021 22:53:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=42YjOqbIy9DlhDO/iMrmfgYXOpw7YyaWJVvHtjTwroY=; b=PiLvBwOWhLsRD9svoAI2f/bbSY01pyHxz8WyTzVEB7gDfcmUEnFiygTv9sJ03b+biO q0WOCnJ8W9SquaGDkpEFNdxrm24Peor+eRxDL7uFMOisgzsAC0j/TXAAwyIWq4m93CDT iXKXduEEdyFpm/H4OO46nTgBsMEgeLwjMqiCH4Po4msvtTXAcLJ3Izscw14kQUts8bdX HcMsOk6RxN0eE3lg7K5opv7HV3CGpTusAMP2B2ZMpWaN32Irzjv6gWJCCzXHKSpuuLlY 3fSBoOjJm+pHHyX0K0yHXkcJV6e455kZHo/UAAX9m64L7omIpc6roBUjUQzQjiWoNhdA E6FA== X-Gm-Message-State: AOAM530QHM4e0JuFm+pjNKgYEAiMuTElJSOpY+AhGp6mAEtmjhyGvoH1 WryFzFMp38oRPyFAKS9vOmUhJnDtyZ07j5kCIuiz3wk8ZAmE8fxy7UBanP2tsV4spppInwxj73Z ss7zqK6Wp5nQ= X-Received: by 2002:a05:600c:4145:: with SMTP id h5mr8281446wmm.108.1624600399074; Thu, 24 Jun 2021 22:53:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcUHFPpvQ43FOWnrf0yQ88HiSNzzAPe6FNjsxlny7a3arjXm7gb+2d0KpRQeI2D2XiGqHyMg== X-Received: by 2002:a05:600c:4145:: with SMTP id h5mr8281417wmm.108.1624600398838; Thu, 24 Jun 2021 22:53:18 -0700 (PDT) Received: from redhat.com ([77.124.79.210]) by smtp.gmail.com with ESMTPSA id x18sm5070450wrw.19.2021.06.24.22.53.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 22:53:18 -0700 (PDT) Date: Fri, 25 Jun 2021 01:53:15 -0400 From: "Michael S. Tsirkin" To: Gavin Shan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, alexander.duyck@gmail.com, david@redhat.com, akpm@linux-foundation.org, anshuman.khandual@arm.com, catalin.marinas@arm.com, will@kernel.org, shan.gavin@gmail.com Subject: Re: [PATCH v4 2/4] mm/page_reporting: Export reporting order as module parameter Message-ID: <20210625014928-mutt-send-email-mst@kernel.org> References: <20210625014710.42954-1-gshan@redhat.com> <20210625014710.42954-3-gshan@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210625014710.42954-3-gshan@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B0371376 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iJY0flUQ; spf=none (imf20.hostedemail.com: domain of mst@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: x3y95bjxk15oyg481pkr8ojr6n5hidgj X-HE-Tag: 1624600404-644378 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 25, 2021 at 09:47:08AM +0800, Gavin Shan wrote: > The macro PAGE_REPORTING_MIN_ORDER is defined as the page reporting > threshold. It can't be adjusted at runtime. > > This introduces a variable (@page_reporting_order) to replace the > marcro (PAGE_REPORTING_MIN_ORDER). MAX_ORDER is assigned to it initially, > meaning the page reporting is disabled. It will be specified by driver > if valid one is provided. Otherwise, it will fall back to @pageblock_order. > It's also exported so that the page reporting order can be adjusted at > runtime. > > Suggested-by: David Hildenbrand > Signed-off-by: Gavin Shan > Reviewed-by: Alexander Duyck > --- > Documentation/admin-guide/kernel-parameters.txt | 6 ++++++ > mm/page_reporting.c | 9 +++++++-- > mm/page_reporting.h | 5 ++--- > 3 files changed, 15 insertions(+), 5 deletions(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index cb89dbdedc46..566c4b9af3cd 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -3566,6 +3566,12 @@ > off: turn off poisoning (default) > on: turn on poisoning > > + page_reporting.page_reporting_order= > + [KNL] Minimal page reporting order > + Format: > + Adjust the minimal page reporting order. The page > + reporting is disabled when it exceeds (MAX_ORDER-1). Which the admin knows how? Run grep in the kernel source? > + > panic= [KNL] Kernel behaviour on panic: delay > timeout > 0: seconds before rebooting > timeout = 0: wait forever > diff --git a/mm/page_reporting.c b/mm/page_reporting.c > index df9c5054e1b4..34bf4d26c2c4 100644 > --- a/mm/page_reporting.c > +++ b/mm/page_reporting.c > @@ -4,12 +4,17 @@ > #include > #include > #include > +#include > #include > #include > > #include "page_reporting.h" > #include "internal.h" > > +unsigned int page_reporting_order = MAX_ORDER; > +module_param(page_reporting_order, uint, 0644); > +MODULE_PARM_DESC(page_reporting_order, "Set page reporting order"); > + > #define PAGE_REPORTING_DELAY (2 * HZ) > static struct page_reporting_dev_info __rcu *pr_dev_info __read_mostly; > > @@ -229,7 +234,7 @@ page_reporting_process_zone(struct page_reporting_dev_info *prdev, > > /* Generate minimum watermark to be able to guarantee progress */ > watermark = low_wmark_pages(zone) + > - (PAGE_REPORTING_CAPACITY << PAGE_REPORTING_MIN_ORDER); > + (PAGE_REPORTING_CAPACITY << page_reporting_order); Looks like this makes it easy to trigger undefined behaviour. Just use any value > 31. > > /* > * Cancel request if insufficient free memory or if we failed > @@ -239,7 +244,7 @@ page_reporting_process_zone(struct page_reporting_dev_info *prdev, > return err; > > /* Process each free list starting from lowest order/mt */ > - for (order = PAGE_REPORTING_MIN_ORDER; order < MAX_ORDER; order++) { > + for (order = page_reporting_order; order < MAX_ORDER; order++) { > for (mt = 0; mt < MIGRATE_TYPES; mt++) { > /* We do not pull pages from the isolate free list */ > if (is_migrate_isolate(mt)) > diff --git a/mm/page_reporting.h b/mm/page_reporting.h > index 2c385dd4ddbd..c51dbc228b94 100644 > --- a/mm/page_reporting.h > +++ b/mm/page_reporting.h > @@ -10,10 +10,9 @@ > #include > #include > > -#define PAGE_REPORTING_MIN_ORDER pageblock_order > - > #ifdef CONFIG_PAGE_REPORTING > DECLARE_STATIC_KEY_FALSE(page_reporting_enabled); > +extern unsigned int page_reporting_order; > void __page_reporting_notify(void); > > static inline bool page_reported(struct page *page) > @@ -38,7 +37,7 @@ static inline void page_reporting_notify_free(unsigned int order) > return; > > /* Determine if we have crossed reporting threshold */ > - if (order < PAGE_REPORTING_MIN_ORDER) > + if (order < page_reporting_order) > return; > > /* This will add a few cycles, but should be called infrequently */ > -- > 2.23.0