From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF215C49EA6 for ; Thu, 24 Jun 2021 19:06:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 722A1613E3 for ; Thu, 24 Jun 2021 19:06:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 722A1613E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7737A6B0011; Thu, 24 Jun 2021 15:06:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74B2D6B005D; Thu, 24 Jun 2021 15:06:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EBAB6B006C; Thu, 24 Jun 2021 15:06:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 07F476B0011 for ; Thu, 24 Jun 2021 15:06:04 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 246DB1F343 for ; Thu, 24 Jun 2021 19:06:05 +0000 (UTC) X-FDA: 78289547490.05.B8F282C Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by imf22.hostedemail.com (Postfix) with ESMTP id D3168C00F78E for ; Thu, 24 Jun 2021 19:06:04 +0000 (UTC) Received: by mail-il1-f178.google.com with SMTP id q9so7417681ilj.3 for ; Thu, 24 Jun 2021 12:06:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sASZIh0JylD5nlffYVNx6Q2qk0hslOsxCidZn+CssBE=; b=bmm+QGGOy5h/zQ5klLCpj+vv2Q53KQvSrrFxN1sloSW1mWyR6f4UDmYR7tVL7OTg8K 9VTQXwOeEX637PADqmiYdCHtf2N2DtHr/JawIg21KUWknOB7mB8rRYG9N+PopPDfWhtp NEyLn1e5jnDKqmZV776NL3pjRHFW5Ik/acucE42l7nubShfjHaczbsEcr680gmPuidyg +U+hUZbnAr31e29sV1N8D+aZG/gcB0M4mscFYDBrA8dLMzL7wrWI5yvjujnid2Wo3Cpm 9Sk/cAhH1yussw83/1ZgJ995gs9P+uk52lEP4jnrA7oAbnSdzOCqMqgBF1HuWATYw1rj QSPw== X-Gm-Message-State: AOAM533M6iN07tLO1YQTSEWVgJpR8FfL8xL6JxEjPBXnCi6Zrc/+kmsy 1sfrbfLUKuqGbFaWfH3A8A== X-Google-Smtp-Source: ABdhPJxiwyiyjZcStomRiRQofvBh6rElZg/J0wGTTpumXIvqvLnGEtvk/m1fPQNTbXqxoAPf9KEGDg== X-Received: by 2002:a05:6e02:1aa7:: with SMTP id l7mr4537589ilv.187.1624561564334; Thu, 24 Jun 2021 12:06:04 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id h8sm975531ile.45.2021.06.24.12.06.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 12:06:02 -0700 (PDT) Received: (nullmailer pid 1820092 invoked by uid 1000); Thu, 24 Jun 2021 19:05:58 -0000 Date: Thu, 24 Jun 2021 13:05:58 -0600 From: Rob Herring To: Dong Aisheng Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, Rob Herring , devicetree@vger.kernel.org, dongas86@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] of: of_reserved_mem: only call memblock_free for normal reserved memory Message-ID: <20210624190558.GA1819995@robh.at.kernel.org> References: <20210611131153.3731147-1-aisheng.dong@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210611131153.3731147-1-aisheng.dong@nxp.com> Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of robherring2@gmail.com designates 209.85.166.178 as permitted sender) smtp.mailfrom=robherring2@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) X-Stat-Signature: ryxow3ymdu73f51oqtgynoe6yt9f8px5 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D3168C00F78E X-HE-Tag: 1624561564-389020 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000453, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 11 Jun 2021 21:11:52 +0800, Dong Aisheng wrote: > For nomap case, the memory block will be removed by memblock_remove() > in early_init_dt_alloc_reserved_memory_arch(). So it's meaningless to > call memblock_free() on error path. > > Cc: Rob Herring > Cc: devicetree@vger.kernel.org > Signed-off-by: Dong Aisheng > --- > drivers/of/of_reserved_mem.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Applied, thanks!