From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1BFFC49EA6 for ; Thu, 24 Jun 2021 15:21:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9F73F600D1 for ; Thu, 24 Jun 2021 15:21:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F73F600D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 858B86B0036; Thu, 24 Jun 2021 11:21:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 807956B005D; Thu, 24 Jun 2021 11:21:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 659F56B006C; Thu, 24 Jun 2021 11:21:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 272526B0036 for ; Thu, 24 Jun 2021 11:21:37 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3F8BE81075CE for ; Thu, 24 Jun 2021 15:21:37 +0000 (UTC) X-FDA: 78288981834.06.F498EA1 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by imf26.hostedemail.com (Postfix) with ESMTP id 92CEA4202A19 for ; Thu, 24 Jun 2021 15:21:36 +0000 (UTC) Received: by mail-qt1-f173.google.com with SMTP id b3so4403374qtq.6 for ; Thu, 24 Jun 2021 08:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to; bh=XTZcBFmJD64rk0L0Ti7cLCSZOK6HZ1i75AWgRbmnkT0=; b=DTWibfbFd03qYiZGv8C80cChp1eOSQiI21lvhjpC4tj8lC6nSetbmAiFCyXo/JicEh 4ObQ/MekbB9/HJ7I02SIaLcRG4zjb8XHfRZrGU9yglcYCZqR7aLVGINU3CAJR+QIcBRo 1+P8j5KD/T7x37XHZBfSlFJnn7fj19cACdYFSRfeYdWX9PfVXaZ7iJ4o8hnKUUQoBVFS whvHg8Pnq+tjsTgU4wi+QTL8yHMvRugPSrEw3oIMlwRNrKGByzIgxOjkGKTQwIJpKbu7 /HCWvj92kEF3aHp0D6gzJi5ACJRbGVajYxGvEEE/haNiMe7urLOSNTyH0B9FUZUXTC68 LRdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to; bh=XTZcBFmJD64rk0L0Ti7cLCSZOK6HZ1i75AWgRbmnkT0=; b=LegzCc58xGKGlFjrRCGPiNxtPzXJTdMIoMOtfMl1YJ+v/HYAVkaKXa0RirZYfCxPE/ 3jjhGqWvpr4R+t9qhI+CeJUAO801uO4KsA69TnXGohhQxmH8uroufBB8iPpZY7cUVtOJ HEj3tfO0OtbwW0BS9cKgiaEnaDKNLUpmNcmjCEl6rj2h0cnaImsa2HDkdtXVWNYjJjZx usBYpTYoWVIzQdTbyr6+3uPvlj0s0dougJjiXchnMQDVWsKq8Jyp8enZ2Px07pEXCzQI oeOd6W6gv1IZZWatDyAG6AsfUiUx1aqABxWFg9WysxjlGLPgVWrihAME0ONfHv3OlDZV 03Xw== X-Gm-Message-State: AOAM532IRMq/5gGWCFi018OL+F0oBb8Q8q8mdBe1ELT/l4w8+BRgPSb4 u6hEieINfvr4WfDb0REpY5M= X-Google-Smtp-Source: ABdhPJwuYrd3WsqGm7dLq9ddX8OCu6a+36K8C3d4Ru9zdbUjafqg7nYbhAE1pOb+IQPgZNSujUy5jQ== X-Received: by 2002:ac8:5ec3:: with SMTP id s3mr5372912qtx.312.1624548095857; Thu, 24 Jun 2021 08:21:35 -0700 (PDT) Received: from localhost.localdomain (ec2-35-169-212-159.compute-1.amazonaws.com. [35.169.212.159]) by smtp.gmail.com with ESMTPSA id 6sm2849236qks.0.2021.06.24.08.21.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 08:21:35 -0700 (PDT) From: SeongJae Park X-Google-Original-From: SeongJae Park To: Shakeel Butt Cc: SeongJae Park , Jonathan.Cameron@huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, Brendan Higgins , Jonathan Corbet , David Hildenbrand , dwmw@amazon.com, Marco Elver , "Du, Fan" , foersleo@amazon.de, greg@kroah.com, Greg Thelen , guoju.fgj@alibaba-inc.com, jgowans@amazon.com, Mel Gorman , mheyne@amazon.de, Minchan Kim , Ingo Molnar , namhyung@kernel.org, "Peter Zijlstra (Intel)" , Rik van Riel , David Rientjes , Steven Rostedt , Mike Rapoport , Shuah Khan , sieberf@amazon.com, snu@zelle79.org, Vlastimil Babka , Vladimir Davydov , zgf574564920@gmail.com, linux-damon@amazon.com, Linux MM , linux-doc@vger.kernel.org, LKML Subject: Re: [PATCH v31 05/13] mm/damon: Implement primitives for the virtual memory address spaces Date: Thu, 24 Jun 2021 15:21:30 +0000 Message-Id: <20210624152130.877-1-sjpark@amazon.de> X-Mailer: git-send-email 2.17.1 In-Reply-To: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=DTWibfbF; spf=pass (imf26.hostedemail.com: domain of sj38park@gmail.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=sj38park@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 92CEA4202A19 X-Stat-Signature: ccd6tc6cm6jtnfuo9t59n1ja46nhqkc3 X-HE-Tag: 1624548096-689459 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: SeongJae Park On Thu, 24 Jun 2021 07:42:44 -0700 Shakeel Butt wrote: > On Thu, Jun 24, 2021 at 3:26 AM SeongJae Park wrote: > > > [...] > > > > +/* > > > > + * Get the three regions in the given target (task) > > > > + * > > > > + * Returns 0 on success, negative error code otherwise. > > > > + */ > > > > +static int damon_va_three_regions(struct damon_target *t, > > > > + struct damon_addr_range regions[3]) > > > > +{ > > > > + struct mm_struct *mm; > > > > + int rc; > > > > + > > > > + mm = damon_get_mm(t); > > > > + if (!mm) > > > > + return -EINVAL; > > > > + > > > > + mmap_read_lock(mm); > > > > + rc = __damon_va_three_regions(mm->mmap, regions); > > > > + mmap_read_unlock(mm); > > > > > > This is being called for each target every second by default. Seems > > > too aggressive. Applications don't change their address space every > > > second. I would recommend to default ctx->primitive_update_interval to > > > a higher default value. > > > > Good point. If there are many targets and each target has a huge number of > > VMAs, the overhead could be high. Nevertheless, I couldn't find the overhead > > in my test setup. Also, it seems someone are already started exploring DAMON > > patchset with the default value. and usages from others. Silently changing the > > default value could distract such people. So, if you think it's ok, I'd like > > to change the default value only after someone finds the overhead from their > > usages and asks a change. > > > > If you disagree or you found the overhead from your usage, please feel free to > > let me know. > > > > mmap lock is a source contention in the real world workloads. We do > observe in our fleet and many others (like Facebook) do complain on > this issue. This is the whole motivation behind SFP, maple tree and > many other mmap lock scalability work. I would be really careful to > add another source of contention on mmap lock. Yes, the user can > change this interval themselves but we should not burden them with > this internal knowledge like "oh if you observe high mmap contention > you may want to increase this specific interval". We should set a good > default value to avoid such situations (most of the time). Thank you for this nice clarification. I can understand your concern because I also worked for an HTM-based solution of the scalability issue before. However, I have neither strong preference nor confidence for the new default value at the moment. Could you please recommend one if you have? Thanks, SeongJae Park