From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEEC5C4743C for ; Wed, 23 Jun 2021 12:11:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4C64161002 for ; Wed, 23 Jun 2021 12:11:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C64161002 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 127D56B0011; Wed, 23 Jun 2021 08:11:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D8396B0036; Wed, 23 Jun 2021 08:11:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E94616B006C; Wed, 23 Jun 2021 08:11:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id A84E96B0011 for ; Wed, 23 Jun 2021 08:11:08 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DAC6D18209BFE for ; Wed, 23 Jun 2021 12:11:08 +0000 (UTC) X-FDA: 78284873016.35.828D379 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 7526D546 for ; Wed, 23 Jun 2021 12:11:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624450268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y7IeWZw2CPbiYZL1JnOyC6QUdKdmMKEr/ocK1ccli4U=; b=ErycYuQj4S5GBkYGxM/8vjjOJmBi2TArlPD2VAeziMErtOzJ5ti2txXmczg03kTHnpZy+X oGyA2u3EFV5vw622XR5gnmE3cydiCF6oYvYymDkyCszTmnFvbe8bmTTz1+cTgTghYfWEBy LiMsL0Kh3z95CNHIUa60iBD4PNTyBqU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-17-7efqrS8BMPmoojezkFE5kQ-1; Wed, 23 Jun 2021 08:11:05 -0400 X-MC-Unique: 7efqrS8BMPmoojezkFE5kQ-1 Received: by mail-wr1-f72.google.com with SMTP id u16-20020a5d51500000b029011a6a17cf62so986431wrt.13 for ; Wed, 23 Jun 2021 05:11:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rkYp3LLWN5Q5TY6AlEvPE9OLWA8THWduAdr4xKTfq9M=; b=iQnx8vcIvXJyLQajGAJ9w08hmcIIiFi41gEWtPDejAaHvkmbyeYDA4j1kqpk1ZRnhc IorydjtJw65tAbnyjJhA2xF0mAju3MAi/lLAxkcLV/nqH+jS6z8vV5cTB2nj4+6a74rP tlPMu0o5CeMwFDLUIyJr0AqKI9zSyBaMkZtHQB4BTbvXvKKIOxWcoNKcw/pElMof+5bv 4xOVaOwggEpCWYLt1a8pbqJWHIodpek8siXhSct4EhmOOAOmi72opIdjEa1vWDCbHGz4 LmUWCk+q+pMEpIuo/djrKP86rXe/85epGGRgW6cGx7NWX/rxtM92RLj+NG1j/DXxeK2o S80A== X-Gm-Message-State: AOAM531GI4mRt8IOfzkbZqZ6alKun8KxvUwb7uxJhJl81WSdLM5EFjlu bOv9HpdsDVD9EaaRcUDZQBlNhGivecdWfWT2CmUJ7Piu1V9dx+Ks7WAC/Cvln8cmDVM3+og9LgW TlGtirEe4Wg== X-Received: by 2002:a1c:5985:: with SMTP id n127mr10220006wmb.75.1624450264881; Wed, 23 Jun 2021 05:11:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwyTUiAuyq6x1LsXIDbUkLanDbniN3nvIi066ic/Yjpf5+S8hl4T4Fw6JI/eT0m8lNHcnACcA== X-Received: by 2002:a1c:5985:: with SMTP id n127mr10219975wmb.75.1624450264656; Wed, 23 Jun 2021 05:11:04 -0700 (PDT) Received: from localhost (cpc111743-lutn13-2-0-cust979.9-3.cable.virginm.net. [82.17.115.212]) by smtp.gmail.com with ESMTPSA id y20sm5356222wmi.25.2021.06.23.05.11.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 05:11:04 -0700 (PDT) Date: Wed, 23 Jun 2021 13:11:03 +0100 From: Aaron Tomlin To: Rafael Aquini Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: vmalloc: add cond_resched() in __vunmap() Message-ID: <20210623121103.i2xpvhxqyf7wopl4@ava.usersys.com> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 References: <20210622225030.478384-1-aquini@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210622225030.478384-1-aquini@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3bx5yvu2w757xdna" Content-Disposition: inline Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ErycYuQj; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf20.hostedemail.com: domain of atomlin@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=atomlin@redhat.com X-Stat-Signature: g4qmd6hx9fedwwgjixhsjgsfwajxsbrd X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7526D546 X-HE-Tag: 1624450268-681805 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --3bx5yvu2w757xdna Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2021-06-22 18:50 -0400, Rafael Aquini wrote: > Like in other range zapping routines that iterate over > a large list, lets just add cond_resched() within __vunmap()'s > page-releasing loop in order to avoid the watchdog splats. >=20 > Signed-off-by: Rafael Aquini > --- > mm/vmalloc.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index a13ac524f6ff..cd4b23d65748 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2564,6 +2564,7 @@ static void __vunmap(const void *addr, int dealloca= te_pages) > =20 > =09=09=09BUG_ON(!page); > =09=09=09__free_pages(page, page_order); > +=09=09=09cond_resched(); > =09=09} > =09=09atomic_long_sub(area->nr_pages, &nr_vmalloc_pages); > =20 > --=20 > 2.26.3 >=20 Good catch. Reviewed-by: Aaron Tomlin --=20 Aaron Tomlin --3bx5yvu2w757xdna Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEeQaE6/qKljiNHm6b4t6WWBnMd9YFAmDTJMoACgkQ4t6WWBnM d9adUA//RZS30uRgLfgY43El1uG1oRgqrxUpEmqJrljrdAetNuuhOQZ+D2kX8Lir vohwyAIvp8rhXVZCnmqNpwSnsfcNOg65jU3MaQteHjSrW6JmJ/+G+JBrbjcKYKcf 2BIhqf6VRRPBVJ3fnjXtg5FkZTQR/BfukLcXrQFDomeXlDVCU4IzB+9OMFrQlDag OAHlwtgFI9nlAmhV+gEWl9kPWjaG7idj5U1/jgjQTeqcj1Wqk68msztbJCZs4hP/ BDCZcRyfWC0fpOzC/W01qzsmYtFacSQmS7rLOD7osKNgtN0aard7Po+qAI+Jvlnp bbx/xGZaEQe/WcDacp28UXfAgKUTgHaE/pS/bLSWR9XktkUPQOZt6YhjygwZzIAE r7SjAvUQwtqEn1RMsNP4Cp7a329ETn2rOUlu9+rYeQaO+8DrHmDvKcmIRkz+kpFK OfjTiT6dxcUmuzd0dkPJ0F/jfWTYt82NN+HvsYc1Ql69fLUqIvM1wYIzJeeNesg6 Io1igNu6/QceVwXoGbsjSXLaPTuXxyiPxfGC8am7Ssre4j2/7hNEfYmAdf6MR6NR t79lIOo47yXvI4591aXjigXtT288CCZafc0wXUlbVkWosQ1ircBWxGqzsGlGXCOO 5hTzUGoXHewhTsgrHw0ushszF7WJ/lzuujZGt43x4fXpkqWTe/M= =UDj0 -----END PGP SIGNATURE----- --3bx5yvu2w757xdna--